From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B5BC43381 for ; Mon, 4 Mar 2019 13:17:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E2BC20830 for ; Mon, 4 Mar 2019 13:17:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rlY5ORVD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2BC20830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ARpg9s6y8sNYSSsV5LTpwg70ID8B2bqa0LLwywldtZo=; b=rlY5ORVDEuW1a8 pq5FAgwmmnet3Zk0xFiAHmJxFwEBN8rRe7qyIHHQGCv4GNsuR6KSuJlA9NA+Lp+CSvXjETELXZZfK pxph5iLVDrsL//GP6lqjWLfcgdTK6clWIsdkhqqtsyn1vEYAUZq0maFlHkKKK5TpZnO+Lo0lPO3aV 8gD+uyIvB/EwWjRbs5cf3vs6tlDbWK56OSZmbXtk3JF1gCKxebvGoxiLU5hQZLZnRIL6BizQgE7jZ bTB2fzBT2Ahfiy29goikbPeQpSgwuuGl7mQ5SC8tUenM/FAhLqrNOgJM0sf3lf9rfhco8bSkIouVk +sKrm4hGj5FNsDsfb82A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0nSl-0001u4-5N; Mon, 04 Mar 2019 13:16:59 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0nSg-0001tA-Fa for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 13:16:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F35CEEBD; Mon, 4 Mar 2019 05:16:52 -0800 (PST) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F6333F575; Mon, 4 Mar 2019 05:16:49 -0800 (PST) Subject: Re: [PATCH v3 08/34] ia64: mm: Add p?d_large() definitions To: "Kirill A. Shutemov" References: <20190227170608.27963-1-steven.price@arm.com> <20190227170608.27963-9-steven.price@arm.com> <20190301215728.nk7466zohdlgelcb@kshutemo-mobl1> From: Steven Price Message-ID: <15100043-26e4-2ee1-28fe-101e12f74926@arm.com> Date: Mon, 4 Mar 2019 13:16:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190301215728.nk7466zohdlgelcb@kshutemo-mobl1> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_051655_884654_79E1551F X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , linux-mm@kvack.org, "H. Peter Anvin" , "Liang, Kan" , x86@kernel.org, Ingo Molnar , Fenghua Yu , Arnd Bergmann , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Tony Luck , Ard Biesheuvel , linux-kernel@vger.kernel.org, James Morse Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/03/2019 21:57, Kirill A. Shutemov wrote: > On Wed, Feb 27, 2019 at 05:05:42PM +0000, Steven Price wrote: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information is provided by the >> p?d_large() functions/macros. >> >> For ia64 leaf entries are always at the lowest level, so implement >> stubs returning 0. > > Are you sure about this? I see pte_mkhuge defined for ia64 and Kconfig > contains hugetlb references. > I'm not completely familiar with ia64, but my understanding is that it doesn't have the situation where a page table walk ends early - there is always the full depth of entries. The p?d_huge() functions always return 0. However my understanding is that it does support huge TLB entries, so when populating the TLB a region larger than a standard page can be mapped. I'd definitely welcome review by someone more familiar with ia64 to check my assumptions. Thanks, Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel