* [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node
@ 2017-11-08 13:30 Ioana Ciornei
2017-11-16 8:39 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Ioana Ciornei @ 2017-11-08 13:30 UTC (permalink / raw)
To: linux-arm-kernel
Add the fsl-mc node in the LS1088A device tree.
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 62 ++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index bd80e9a..aa37ffe 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -166,6 +166,68 @@
<1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */
};
+ fsl_mc: fsl-mc at 80c000000 {
+ compatible = "fsl,qoriq-mc";
+ reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
+ <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
+ msi-parent = <&its>;
+ #address-cells = <3>;
+ #size-cells = <1>;
+
+ /*
+ * Region type 0x0 - MC portals
+ * Region type 0x1 - QBMAN portals
+ */
+ ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
+ 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
+
+ dpmacs {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dpmac1: dpmac at 1 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <1>;
+ };
+ dpmac2: dpmac at 2 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <2>;
+ };
+ dpmac3: dpmac at 3 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <3>;
+ };
+ dpmac4: dpmac at 4 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <4>;
+ };
+ dpmac5: dpmac at 5 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <5>;
+ };
+ dpmac6: dpmac at 6 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <6>;
+ };
+ dpmac7: dpmac at 7 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <7>;
+ };
+ dpmac8: dpmac at 8 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <8>;
+ };
+ dpmac9: dpmac at 9 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <9>;
+ };
+ dpmac10: dpmac at 10 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <0xa>;
+ };
+ };
+ };
+
psci {
compatible = "arm,psci-0.2";
method = "smc";
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node
2017-11-08 13:30 [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node Ioana Ciornei
@ 2017-11-16 8:39 ` Shawn Guo
2017-11-16 14:24 ` Ioana Ciornei
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2017-11-16 8:39 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 08, 2017 at 03:30:05PM +0200, Ioana Ciornei wrote:
> Add the fsl-mc node in the LS1088A device tree.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 62 ++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index bd80e9a..aa37ffe 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -166,6 +166,68 @@
> <1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */
> };
>
> + fsl_mc: fsl-mc at 80c000000 {
The unit-address of the node should be somehow related to 'reg'
property. Can you please help me understand how they are related?
> + compatible = "fsl,qoriq-mc";
> + reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> + <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> + msi-parent = <&its>;
> + #address-cells = <3>;
> + #size-cells = <1>;
> +
> + /*
> + * Region type 0x0 - MC portals
> + * Region type 0x1 - QBMAN portals
> + */
> + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> +
> + dpmacs {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dpmac1: dpmac at 1 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <1>;
> + };
Please have a newline in between nodes.
Shawn
> + dpmac2: dpmac at 2 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <2>;
> + };
> + dpmac3: dpmac at 3 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <3>;
> + };
> + dpmac4: dpmac at 4 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <4>;
> + };
> + dpmac5: dpmac at 5 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <5>;
> + };
> + dpmac6: dpmac at 6 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <6>;
> + };
> + dpmac7: dpmac at 7 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <7>;
> + };
> + dpmac8: dpmac at 8 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <8>;
> + };
> + dpmac9: dpmac at 9 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <9>;
> + };
> + dpmac10: dpmac at 10 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0xa>;
> + };
> + };
> + };
> +
> psci {
> compatible = "arm,psci-0.2";
> method = "smc";
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node
2017-11-16 8:39 ` Shawn Guo
@ 2017-11-16 14:24 ` Ioana Ciornei
2017-11-17 12:35 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Ioana Ciornei @ 2017-11-16 14:24 UTC (permalink / raw)
To: linux-arm-kernel
See comments inline.
>
> On Wed, Nov 08, 2017 at 03:30:05PM +0200, Ioana Ciornei wrote:
> > Add the fsl-mc node in the LS1088A device tree.
> >
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 62
> ++++++++++++++++++++++++++
> > 1 file changed, 62 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index bd80e9a..aa37ffe 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -166,6 +166,68 @@
> > <1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */
> > };
> >
> > + fsl_mc: fsl-mc at 80c000000 {
>
> The unit-address of the node should be somehow related to 'reg'
> property. Can you please help me understand how they are related?
The unit-address of the fsl-mc node is the base address of the MC portal described in the first region of the 'reg' property and formed using the 2 address cells.
Hope this helps.
>
> > + compatible = "fsl,qoriq-mc";
> > + reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> > + <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> > + msi-parent = <&its>;
> > + #address-cells = <3>;
> > + #size-cells = <1>;
> > +
> > + /*
> > + * Region type 0x0 - MC portals
> > + * Region type 0x1 - QBMAN portals
> > + */
> > + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> > + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> > +
> > + dpmacs {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + dpmac1: dpmac at 1 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <1>;
> > + };
>
> Please have a newline in between nodes.
Will do.
Should I send a rework of this patch right away or better to wait for the merge window to close?
Ioana
>
> Shawn
>
> > + dpmac2: dpmac at 2 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <2>;
> > + };
> > + dpmac3: dpmac at 3 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <3>;
> > + };
> > + dpmac4: dpmac at 4 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <4>;
> > + };
> > + dpmac5: dpmac at 5 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <5>;
> > + };
> > + dpmac6: dpmac at 6 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <6>;
> > + };
> > + dpmac7: dpmac at 7 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <7>;
> > + };
> > + dpmac8: dpmac at 8 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <8>;
> > + };
> > + dpmac9: dpmac at 9 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <9>;
> > + };
> > + dpmac10: dpmac at 10 {
> > + compatible = "fsl,qoriq-mc-dpmac";
> > + reg = <0xa>;
> > + };
> > + };
> > + };
> > +
> > psci {
> > compatible = "arm,psci-0.2";
> > method = "smc";
> > --
> > 1.9.1
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node
2017-11-16 14:24 ` Ioana Ciornei
@ 2017-11-17 12:35 ` Shawn Guo
2017-11-17 13:59 ` Ioana Ciornei
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2017-11-17 12:35 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 16, 2017 at 02:24:49PM +0000, Ioana Ciornei wrote:
...
> > > + fsl_mc: fsl-mc at 80c000000 {
> >
> > The unit-address of the node should be somehow related to 'reg'
> > property. Can you please help me understand how they are related?
>
> The unit-address of the fsl-mc node is the base address of the MC portal described in the first region of the 'reg' property and formed using the 2 address cells.
> Hope this helps.
Ah, sorry, I forgot that the address-cells is 2.
>
> >
> > > + compatible = "fsl,qoriq-mc";
> > > + reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> > > + <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> > > + msi-parent = <&its>;
> > > + #address-cells = <3>;
> > > + #size-cells = <1>;
> > > +
> > > + /*
> > > + * Region type 0x0 - MC portals
> > > + * Region type 0x1 - QBMAN portals
> > > + */
> > > + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> > > + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> > > +
> > > + dpmacs {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + dpmac1: dpmac at 1 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <1>;
> > > + };
> >
> > Please have a newline in between nodes.
>
> Will do.
>
> Should I send a rework of this patch right away or better to wait for the merge window to close?
Either way is fine, as I will rebase my branch to v4.15-rc1 after merge
window closes.
> > > + dpmac2: dpmac at 2 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <2>;
> > > + };
> > > + dpmac3: dpmac at 3 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <3>;
> > > + };
> > > + dpmac4: dpmac at 4 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <4>;
> > > + };
> > > + dpmac5: dpmac at 5 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <5>;
> > > + };
> > > + dpmac6: dpmac at 6 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <6>;
> > > + };
> > > + dpmac7: dpmac at 7 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <7>;
> > > + };
> > > + dpmac8: dpmac at 8 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <8>;
> > > + };
> > > + dpmac9: dpmac at 9 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <9>;
> > > + };
> > > + dpmac10: dpmac at 10 {
Just noticed this - the unit-address should be hex number, so it should
be dpmac at a rather than dpmac at 10, I think.
Shawn
> > > + compatible = "fsl,qoriq-mc-dpmac";
> > > + reg = <0xa>;
> > > + };
> > > + };
> > > + };
> > > +
> > > psci {
> > > compatible = "arm,psci-0.2";
> > > method = "smc";
> > > --
> > > 1.9.1
> > >
> > >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node
2017-11-17 12:35 ` Shawn Guo
@ 2017-11-17 13:59 ` Ioana Ciornei
0 siblings, 0 replies; 5+ messages in thread
From: Ioana Ciornei @ 2017-11-17 13:59 UTC (permalink / raw)
To: linux-arm-kernel
> On Thu, Nov 16, 2017 at 02:24:49PM +0000, Ioana Ciornei wrote:
> ...
> > > > + fsl_mc: fsl-mc at 80c000000 {
> > >
> > > The unit-address of the node should be somehow related to 'reg'
> > > property. Can you please help me understand how they are related?
> >
> > The unit-address of the fsl-mc node is the base address of the MC portal
> described in the first region of the 'reg' property and formed using the 2
> address cells.
> > Hope this helps.
>
> Ah, sorry, I forgot that the address-cells is 2.
>
> >
> > >
> > > > + compatible = "fsl,qoriq-mc";
> > > > + reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal
> base */
> > > > + <0x00000000 0x08340000 0 0x40000>; /* MC control
> reg */
> > > > + msi-parent = <&its>;
> > > > + #address-cells = <3>;
> > > > + #size-cells = <1>;
> > > > +
> > > > + /*
> > > > + * Region type 0x0 - MC portals
> > > > + * Region type 0x1 - QBMAN portals
> > > > + */
> > > > + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> > > > + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> > > > +
> > > > + dpmacs {
> > > > + #address-cells = <1>;
> > > > + #size-cells = <0>;
> > > > +
> > > > + dpmac1: dpmac at 1 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <1>;
> > > > + };
> > >
> > > Please have a newline in between nodes.
> >
> > Will do.
> >
> > Should I send a rework of this patch right away or better to wait for the
> merge window to close?
>
> Either way is fine, as I will rebase my branch to v4.15-rc1 after merge window
> closes.
>
> > > > + dpmac2: dpmac at 2 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <2>;
> > > > + };
> > > > + dpmac3: dpmac at 3 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <3>;
> > > > + };
> > > > + dpmac4: dpmac at 4 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <4>;
> > > > + };
> > > > + dpmac5: dpmac at 5 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <5>;
> > > > + };
> > > > + dpmac6: dpmac at 6 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <6>;
> > > > + };
> > > > + dpmac7: dpmac at 7 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <7>;
> > > > + };
> > > > + dpmac8: dpmac at 8 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <8>;
> > > > + };
> > > > + dpmac9: dpmac at 9 {
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <9>;
> > > > + };
> > > > + dpmac10: dpmac at 10 {
>
> Just noticed this - the unit-address should be hex number, so it should be
> dpmac at a rather than dpmac at 10, I think.
>
Yes, that is right, it should be dpmac at a. Will change it.
Ioana
> Shawn
>
> > > > + compatible = "fsl,qoriq-mc-dpmac";
> > > > + reg = <0xa>;
> > > > + };
> > > > + };
> > > > + };
> > > > +
> > > > psci {
> > > > compatible = "arm,psci-0.2";
> > > > method = "smc";
> > > > --
> > > > 1.9.1
> > > >
> > > >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-17 13:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-08 13:30 [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node Ioana Ciornei
2017-11-16 8:39 ` Shawn Guo
2017-11-16 14:24 ` Ioana Ciornei
2017-11-17 12:35 ` Shawn Guo
2017-11-17 13:59 ` Ioana Ciornei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).