linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jlu@pengutronix.de (Jan Lübbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] EDAC: ti: add support for TI keystone and DRA7xx EDAC
Date: Thu, 09 Nov 2017 12:50:04 +0100	[thread overview]
Message-ID: <1510228204.3471.44.camel@pengutronix.de> (raw)
In-Reply-To: <1510087139-21885-3-git-send-email-t-kristo@ti.com>

On Tue, 2017-11-07 at 22:38 +0200, Tero Kristo wrote:
> +       if (edac_mc_add_mc(mci)) {
> +               pr_err("%s: Failed to register mci.\n", __func__);
> +               return -ENOMEM;
This leaks the allocated mci structure in the error case.

> +       }
> +
> +       /* add EMIF ECC error handler */
> +       error_irq = platform_get_irq(pdev, 0);
> +       if (!error_irq) {
> +               dev_err(dev, "DDR3 EDAC irq number not defined\n");
> +               return ret;
This leaves the mc registered in the error case.

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2017-11-09 11:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 20:38 [PATCH 0/3] EDAC: TI: add support for DRA7 and keystone EDAC Tero Kristo
2017-11-07 20:38 ` [PATCH 1/3] Documentation: dt: memory: ti-emif: add edac support under emif Tero Kristo
2017-11-10  8:25   ` [PATCHv2 2/3] EDAC: ti: add support for TI keystone and DRA7xx EDAC Tero Kristo
2017-11-11 10:46     ` Borislav Petkov
2017-11-13  9:03       ` Tero Kristo
2017-12-07  9:03   ` [PATCH 1/3] Documentation: dt: memory: ti-emif: add edac support under emif Tero Kristo
2017-11-07 20:38 ` [PATCH 2/3] EDAC: ti: add support for TI keystone and DRA7xx EDAC Tero Kristo
2017-11-09 10:14   ` Borislav Petkov
2017-11-09 10:38     ` Tero Kristo
2017-11-09 12:12       ` Borislav Petkov
2017-11-09 11:50   ` Jan Lübbe [this message]
2017-11-09 12:40     ` Tero Kristo
2017-11-13 13:08   ` [PATCHv3 " Tero Kristo
2017-11-13 17:10     ` Santosh Shilimkar
2017-11-13 17:58       ` Borislav Petkov
2017-11-13 18:04         ` Santosh Shilimkar
2017-11-13 18:08           ` Borislav Petkov
2017-11-13 18:49             ` Tero Kristo
2017-11-13 19:17               ` Santosh Shilimkar
2017-11-27 13:12     ` Borislav Petkov
2017-11-07 20:38 ` [PATCH 3/3] ARM: dts: Keystone: add ECC error handler support Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510228204.3471.44.camel@pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).