From: arvind.yadav.cs@gmail.com (Arvind Yadav)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ASoC: mt8173: Fix platform_get_irq's error checking
Date: Sat, 18 Nov 2017 01:03:25 +0530 [thread overview]
Message-ID: <1510947208-17134-3-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1510947208-17134-1-git-send-email-arvind.yadav.cs@gmail.com>
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
index 8a643a3..eee27bc 100644
--- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
+++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
@@ -1105,9 +1105,9 @@ static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
afe->dev = &pdev->dev;
irq_id = platform_get_irq(pdev, 0);
- if (!irq_id) {
+ if (irq_id < 0) {
dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name);
- return -ENXIO;
+ return irq_id;
}
ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler,
0, "Afe_ISR_Handle", (void *)afe);
--
2.7.4
next prev parent reply other threads:[~2017-11-17 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 19:33 [PATCH 0/5] ASoC: Handle platform_get_irq's error checking and return Arvind Yadav
2017-11-17 19:33 ` [PATCH 1/5] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking Arvind Yadav
2017-11-17 19:33 ` Arvind Yadav [this message]
2017-11-17 19:33 ` [PATCH 3/5] ASoC: nuc900: " Arvind Yadav
2017-11-17 19:33 ` [PATCH 4/5] ASoC: intel: sst: Handle return value of platform_get_irq Arvind Yadav
2017-11-17 19:33 ` [PATCH 5/5] ASoC: intel: mfld: " Arvind Yadav
2017-11-18 8:19 ` [PATCH 0/5] ASoC: Handle platform_get_irq's error checking and return Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510947208-17134-3-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).