From: arvind.yadav.cs@gmail.com (Arvind Yadav)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] mmc: sh_mmcif: Handle return value of platform_get_irq
Date: Sat, 18 Nov 2017 01:58:21 +0530 [thread overview]
Message-ID: <1510950502-22565-6-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com>
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/mmc/host/sh_mmcif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 53fb18b..481f2c4 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -1405,7 +1405,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
irq[0] = platform_get_irq(pdev, 0);
irq[1] = platform_get_irq(pdev, 1);
- if (irq[0] < 0) {
+ if (irq[0] < 0 || irq[1] < 0) {
dev_err(dev, "Get irq error\n");
return -ENXIO;
}
--
2.7.4
next prev parent reply other threads:[~2017-11-17 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 20:28 [PATCH 0/6] mmc: Handle platform_get_irq's error checking and return Arvind Yadav
2017-11-17 20:28 ` [PATCH 1/6] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
2017-12-07 0:55 ` Kevin Hilman
2017-11-17 20:28 ` [PATCH 2/6] mmc: s3cmci: " Arvind Yadav
2017-11-17 20:28 ` [PATCH 3/6] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
2017-11-17 20:28 ` [PATCH 4/6] mmc: sdhci-spear: " Arvind Yadav
2017-11-20 5:43 ` Viresh Kumar
2017-11-20 6:43 ` Arvind Yadav
2017-11-17 20:28 ` Arvind Yadav [this message]
2017-11-17 20:28 ` [PATCH 6/6] mmc: sunxi-mmc: " Arvind Yadav
2017-11-18 8:19 ` [PATCH 0/6] mmc: Handle platform_get_irq's error checking and return Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510950502-22565-6-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).