[PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity

[PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
phy-reset-gpios is active high only if the 'phy-reset-active-high' is
present.

As 'phy-reset-active-high' is not used here, fix the device tree
description by passing GPIO_ACTIVE_LOW flag.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx53-cx9020.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx53-cx9020.dts b/arch/arm/boot/dts/imx53-cx9020.dts
index 4f54fd4..5e67e43 100644
--- a/arch/arm/boot/dts/imx53-cx9020.dts
+++ b/arch/arm/boot/dts/imx53-cx9020.dts
@@ -152,7 +152,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec>;
 	phy-mode = "rmii";
-	phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>;
+	phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
 
-- 
2.7.4

[PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity

[Patrick Brünn]

>From: Fabio Estevam [mailto:festevam at gmail.com]
>Sent: Samstag, 25. November 2017 23:51
>From: Fabio Estevam <fabio.estevam@nxp.com>
>
>As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
>phy-reset-gpios is active high only if the 'phy-reset-active-high' is
>present.
>
>As 'phy-reset-active-high' is not used here, fix the device tree
>description by passing GPIO_ACTIVE_LOW flag.
>
>Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>---
> arch/arm/boot/dts/imx53-cx9020.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/arm/boot/dts/imx53-cx9020.dts b/arch/arm/boot/dts/imx53-
>cx9020.dts
>index 4f54fd4..5e67e43 100644
>--- a/arch/arm/boot/dts/imx53-cx9020.dts
>+++ b/arch/arm/boot/dts/imx53-cx9020.dts
>@@ -152,7 +152,7 @@
>       pinctrl-names = "default";
>       pinctrl-0 = <&pinctrl_fec>;
>       phy-mode = "rmii";
>-      phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>;
>+      phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_LOW>;
>       status = "okay";
> };
>
>--
>2.7.4
Tested-by: Patrick Bruenn <p.bruenn@beckhoff.com>

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

[PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity

[Andrew Lunn]

On Sat, Nov 25, 2017 at 08:51:07PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
> phy-reset-gpios is active high only if the 'phy-reset-active-high' is
> present.
> 
> As 'phy-reset-active-high' is not used here, fix the device tree
> description by passing GPIO_ACTIVE_LOW flag.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Hi Fabio

Do you have a bigger plan than just 'documentation'. Given that device
tree is an ABI, the GPIO_ACTIVE_ flag has to be ignored. Having it
correct is just documentation.

If you want to fix them all, is it worth adding in a warning to detect
a miss match between the GPIO_ACTIVE_* and phy-reset-active-high?

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity

[Fabio Estevam]

Hi Andrew,

On Mon, Nov 27, 2017 at 11:29 AM, Andrew Lunn <andrew@lunn.ch> wrote:

> Hi Fabio
>
> Do you have a bigger plan than just 'documentation'. Given that device
> tree is an ABI, the GPIO_ACTIVE_ flag has to be ignored. Having it
> correct is just documentation.
>
> If you want to fix them all, is it worth adding in a warning to detect
> a miss match between the GPIO_ACTIVE_* and phy-reset-active-high?

This was the only dts with a mismatch.

> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Thanks

[PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity

[Shawn Guo]

On Sat, Nov 25, 2017 at 08:51:07PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
> phy-reset-gpios is active high only if the 'phy-reset-active-high' is
> present.
> 
> As 'phy-reset-active-high' is not used here, fix the device tree
> description by passing GPIO_ACTIVE_LOW flag.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.