* [PATCH] coresight: Use PTR_ERR_OR_ZERO()
@ 2017-11-28 22:16 Vasyl Gomonovych
2017-11-29 16:52 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Vasyl Gomonovych @ 2017-11-28 22:16 UTC (permalink / raw)
To: linux-arm-kernel
Fix ptr_ret.cocci warnings:
drivers/hwtracing/coresight/coresight-tpiu.c:163:1-3: WARNING: PTR_ERR_OR_ZERO can be used
drivers/hwtracing/coresight/coresight-funnel.c:217:1-3: WARNING: PTR_ERR_OR_ZERO can be used
drivers/hwtracing/coresight/coresight-dynamic-replicator.c:166:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/hwtracing/coresight/coresight-dynamic-replicator.c | 4 +---
drivers/hwtracing/coresight/coresight-funnel.c | 4 +---
drivers/hwtracing/coresight/coresight-tpiu.c | 4 +---
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-dynamic-replicator.c b/drivers/hwtracing/coresight/coresight-dynamic-replicator.c
index 8f4357e2626c..043da86b0fe9 100644
--- a/drivers/hwtracing/coresight/coresight-dynamic-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-dynamic-replicator.c
@@ -163,10 +163,8 @@ static int replicator_probe(struct amba_device *adev, const struct amba_id *id)
desc.dev = &adev->dev;
desc.groups = replicator_groups;
drvdata->csdev = coresight_register(&desc);
- if (IS_ERR(drvdata->csdev))
- return PTR_ERR(drvdata->csdev);
- return 0;
+ return PTR_ERR_OR_ZERO(drvdata->csdev);
}
#ifdef CONFIG_PM
diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
index fd3c396717f6..9f8ac0bef853 100644
--- a/drivers/hwtracing/coresight/coresight-funnel.c
+++ b/drivers/hwtracing/coresight/coresight-funnel.c
@@ -214,10 +214,8 @@ static int funnel_probe(struct amba_device *adev, const struct amba_id *id)
desc.dev = dev;
desc.groups = coresight_funnel_groups;
drvdata->csdev = coresight_register(&desc);
- if (IS_ERR(drvdata->csdev))
- return PTR_ERR(drvdata->csdev);
- return 0;
+ return PTR_ERR_OR_ZERO(drvdata->csdev);
}
#ifdef CONFIG_PM
diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c
index bef49a3a5ca7..76ea1b8d4db5 100644
--- a/drivers/hwtracing/coresight/coresight-tpiu.c
+++ b/drivers/hwtracing/coresight/coresight-tpiu.c
@@ -160,10 +160,8 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id)
desc.pdata = pdata;
desc.dev = dev;
drvdata->csdev = coresight_register(&desc);
- if (IS_ERR(drvdata->csdev))
- return PTR_ERR(drvdata->csdev);
- return 0;
+ return PTR_ERR_OR_ZERO(drvdata->csdev);
}
#ifdef CONFIG_PM
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] coresight: Use PTR_ERR_OR_ZERO()
2017-11-28 22:16 [PATCH] coresight: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-11-29 16:52 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2017-11-29 16:52 UTC (permalink / raw)
To: linux-arm-kernel
On 28 November 2017 at 15:16, Vasyl Gomonovych <gomonovych@gmail.com> wrote:
> Fix ptr_ret.cocci warnings:
> drivers/hwtracing/coresight/coresight-tpiu.c:163:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> drivers/hwtracing/coresight/coresight-funnel.c:217:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> drivers/hwtracing/coresight/coresight-dynamic-replicator.c:166:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> drivers/hwtracing/coresight/coresight-dynamic-replicator.c | 4 +---
> drivers/hwtracing/coresight/coresight-funnel.c | 4 +---
> drivers/hwtracing/coresight/coresight-tpiu.c | 4 +---
> 3 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-dynamic-replicator.c b/drivers/hwtracing/coresight/coresight-dynamic-replicator.c
> index 8f4357e2626c..043da86b0fe9 100644
> --- a/drivers/hwtracing/coresight/coresight-dynamic-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-dynamic-replicator.c
> @@ -163,10 +163,8 @@ static int replicator_probe(struct amba_device *adev, const struct amba_id *id)
> desc.dev = &adev->dev;
> desc.groups = replicator_groups;
> drvdata->csdev = coresight_register(&desc);
> - if (IS_ERR(drvdata->csdev))
> - return PTR_ERR(drvdata->csdev);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(drvdata->csdev);
> }
>
> #ifdef CONFIG_PM
> diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
> index fd3c396717f6..9f8ac0bef853 100644
> --- a/drivers/hwtracing/coresight/coresight-funnel.c
> +++ b/drivers/hwtracing/coresight/coresight-funnel.c
> @@ -214,10 +214,8 @@ static int funnel_probe(struct amba_device *adev, const struct amba_id *id)
> desc.dev = dev;
> desc.groups = coresight_funnel_groups;
> drvdata->csdev = coresight_register(&desc);
> - if (IS_ERR(drvdata->csdev))
> - return PTR_ERR(drvdata->csdev);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(drvdata->csdev);
> }
>
> #ifdef CONFIG_PM
> diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c
> index bef49a3a5ca7..76ea1b8d4db5 100644
> --- a/drivers/hwtracing/coresight/coresight-tpiu.c
> +++ b/drivers/hwtracing/coresight/coresight-tpiu.c
> @@ -160,10 +160,8 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id)
> desc.pdata = pdata;
> desc.dev = dev;
> drvdata->csdev = coresight_register(&desc);
> - if (IS_ERR(drvdata->csdev))
> - return PTR_ERR(drvdata->csdev);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(drvdata->csdev);
> }
Applied - thanks,
Mathieu
>
> #ifdef CONFIG_PM
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-29 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-28 22:16 [PATCH] coresight: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-29 16:52 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).