* [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation
[not found] <20171214165352.27902-1-malat@debian.org>
@ 2017-12-14 18:03 ` Matthias Brugger
2017-12-14 18:29 ` Joe Perches
2017-12-20 6:49 ` Andy Gross
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Matthias Brugger @ 2017-12-14 18:03 UTC (permalink / raw)
To: linux-arm-kernel
On 12/14/2017 05:53 PM, Mathieu Malaterre wrote:
[...]
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 26396ef53bde..0446b122a6e2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -249,7 +249,7 @@
> reg = <0 0x10005000 0 0x1000>;
> };
>
> - pio: pinctrl at 0x10005000 {
> + pio: pinctrl at 10005000 {
> compatible = "mediatek,mt8173-pinctrl";
> reg = <0 0x1000b000 0 0x1000>;
> mediatek,pctl-regmap = <&syscfg_pctl_a>;
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation
2017-12-14 18:03 ` [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation Matthias Brugger
@ 2017-12-14 18:29 ` Joe Perches
2017-12-14 18:42 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2017-12-14 18:29 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2017-12-14 at 19:03 +0100, Matthias Brugger wrote:
>
> On 12/14/2017 05:53 PM, Mathieu Malaterre wrote:
> [...]
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 26396ef53bde..0446b122a6e2 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -249,7 +249,7 @@
> > reg = <0 0x10005000 0 0x1000>;
> > };
> >
> > - pio: pinctrl at 0x10005000 {
> > + pio: pinctrl at 10005000 {
> > compatible = "mediatek,mt8173-pinctrl";
> > reg = <0 0x1000b000 0 0x1000>;
> > mediatek,pctl-regmap = <&syscfg_pctl_a>;
>
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Should all of these be fixed?
$ git grep -P "^\s*\w+:\s*[\w\-]+ at 0[xX]" -- "*.dts*" | wc -l
69
Is this a pattern that should be added to checkpatch?
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation
2017-12-14 18:29 ` Joe Perches
@ 2017-12-14 18:42 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2017-12-14 18:42 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 14, 2017 at 12:29 PM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2017-12-14 at 19:03 +0100, Matthias Brugger wrote:
>>
>> On 12/14/2017 05:53 PM, Mathieu Malaterre wrote:
>> [...]
>> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> > index 26396ef53bde..0446b122a6e2 100644
>> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> > @@ -249,7 +249,7 @@
>> > reg = <0 0x10005000 0 0x1000>;
>> > };
>> >
>> > - pio: pinctrl at 0x10005000 {
>> > + pio: pinctrl at 10005000 {
>> > compatible = "mediatek,mt8173-pinctrl";
>> > reg = <0 0x1000b000 0 0x1000>;
>> > mediatek,pctl-regmap = <&syscfg_pctl_a>;
>>
>> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> Should all of these be fixed?
>
> $ git grep -P "^\s*\w+:\s*[\w\-]+ at 0[xX]" -- "*.dts*" | wc -l
> 69
Yes, there's patches for all arches.
>
> Is this a pattern that should be added to checkpatch?
No, because dtc provides the warnings.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation
[not found] <20171214165352.27902-1-malat@debian.org>
2017-12-14 18:03 ` [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation Matthias Brugger
@ 2017-12-20 6:49 ` Andy Gross
2018-02-13 15:32 ` Rob Herring
2018-02-22 16:38 ` Arnd Bergmann
3 siblings, 0 replies; 6+ messages in thread
From: Andy Gross @ 2017-12-20 6:49 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 14, 2017 at 05:53:52PM +0100, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Acked-by: Andy Gross <andy.gross@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation
[not found] <20171214165352.27902-1-malat@debian.org>
2017-12-14 18:03 ` [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation Matthias Brugger
2017-12-20 6:49 ` Andy Gross
@ 2018-02-13 15:32 ` Rob Herring
2018-02-22 16:38 ` Arnd Bergmann
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2018-02-13 15:32 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 14, 2017 at 10:53 AM, Mathieu Malaterre <malat@debian.org> wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 2 +-
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 6 +++---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++---
> 4 files changed, 8 insertions(+), 8 deletions(-)
Arnd, Olof, Looks like this got missed. Can you pick up for 4.16.
There's some arm32 ones too, but most of them need to be respun to
mention upper to lower case fixes.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation
[not found] <20171214165352.27902-1-malat@debian.org>
` (2 preceding siblings ...)
2018-02-13 15:32 ` Rob Herring
@ 2018-02-22 16:38 ` Arnd Bergmann
3 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2018-02-22 16:38 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 14, 2017 at 5:53 PM, Mathieu Malaterre <malat@debian.org> wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied to fixes, thanks!
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread