From: appana.durga.rao@xilinx.com (Kedareswara rao Appana)
To: linux-arm-kernel@lists.infradead.org
Subject: [LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures
Date: Thu, 21 Dec 2017 15:41:35 +0530 [thread overview]
Message-ID: <1513851098-15787-2-git-send-email-appanad@xilinx.com> (raw)
In-Reply-To: <1513851098-15787-1-git-send-email-appanad@xilinx.com>
When client driver uses dma_get_slave_caps() api,
it checks for certain fields of dma_device struct
currently driver is not settings few fields resulting
dma_get_slave_caps() returning failure.
This patch fixes this issue by populating proper values
to the struct dma_device fields.
Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
---
drivers/dma/xilinx/xilinx_dma.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index 88d317d..21ac954 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -2398,6 +2398,7 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
chan->direction = DMA_MEM_TO_DEV;
chan->id = chan_id;
chan->tdest = chan_id;
+ xdev->common.directions = BIT(DMA_MEM_TO_DEV);
chan->ctrl_offset = XILINX_DMA_MM2S_CTRL_OFFSET;
if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) {
@@ -2415,6 +2416,7 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
chan->direction = DMA_DEV_TO_MEM;
chan->id = chan_id;
chan->tdest = chan_id - xdev->nr_channels;
+ xdev->common.directions |= BIT(DMA_DEV_TO_MEM);
chan->ctrl_offset = XILINX_DMA_S2MM_CTRL_OFFSET;
if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) {
@@ -2629,6 +2631,8 @@ static int xilinx_dma_probe(struct platform_device *pdev)
dma_cap_set(DMA_PRIVATE, xdev->common.cap_mask);
}
+ xdev->common.dst_addr_widths = BIT(addr_width / 8);
+ xdev->common.src_addr_widths = BIT(addr_width / 8);
xdev->common.device_alloc_chan_resources =
xilinx_dma_alloc_chan_resources;
xdev->common.device_free_chan_resources =
--
2.7.4
next prev parent reply other threads:[~2017-12-21 10:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 10:11 [LINUX PATCH 0/4] dmaengine: xilinx_dma: Bug fixes Kedareswara rao Appana
2017-12-21 10:11 ` Kedareswara rao Appana [this message]
2018-01-03 3:57 ` [LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures Vinod Koul
2018-01-03 5:09 ` Appana Durga Kedareswara Rao
2017-12-21 10:11 ` [LINUX PATCH 2/4] dmaengine: xilinx_dma: Fix race condition in the driver for cdma Kedareswara rao Appana
2018-01-03 3:58 ` Vinod Koul
2018-01-03 5:10 ` Appana Durga Kedareswara Rao
2017-12-21 10:11 ` [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning Kedareswara rao Appana
2018-01-03 3:59 ` Vinod Koul
2018-01-03 5:13 ` Appana Durga Kedareswara Rao
2018-01-03 5:27 ` Vinod Koul
2018-01-03 6:10 ` Appana Durga Kedareswara Rao
2018-01-03 9:09 ` Appana Durga Kedareswara Rao
2017-12-21 10:11 ` [LINUX PATCH 4/4] dmaengine: xilinx_dma: Free BD consistent memory Kedareswara rao Appana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513851098-15787-2-git-send-email-appanad@xilinx.com \
--to=appana.durga.rao@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).