From: appana.durga.rao@xilinx.com (Kedareswara rao Appana)
To: linux-arm-kernel@lists.infradead.org
Subject: [LINUX PATCH 2/4] dmaengine: xilinx_dma: Fix race condition in the driver for cdma
Date: Thu, 21 Dec 2017 15:41:36 +0530 [thread overview]
Message-ID: <1513851098-15787-3-git-send-email-appanad@xilinx.com> (raw)
In-Reply-To: <1513851098-15787-1-git-send-email-appanad@xilinx.com>
when hardware is idle we need to toggle the SG bit
in the control register, inorder to update new value to the
current descriptor register other wise undefined
results will occur.
This patch updates the same.
Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
---
drivers/dma/xilinx/xilinx_dma.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index 21ac954..8467671 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -1204,6 +1204,12 @@ static void xilinx_cdma_start_transfer(struct xilinx_dma_chan *chan)
}
if (chan->has_sg) {
+ dma_ctrl_clr(chan, XILINX_DMA_REG_DMACR,
+ XILINX_CDMA_CR_SGMODE);
+
+ dma_ctrl_set(chan, XILINX_DMA_REG_DMACR,
+ XILINX_CDMA_CR_SGMODE);
+
xilinx_write(chan, XILINX_DMA_REG_CURDESC,
head_desc->async_tx.phys);
@@ -2052,6 +2058,10 @@ static int xilinx_dma_terminate_all(struct dma_chan *dchan)
chan->cyclic = false;
}
+ if ((chan->xdev->dma_config->dmatype == XDMA_TYPE_CDMA) && chan->has_sg)
+ dma_ctrl_clr(chan, XILINX_DMA_REG_DMACR,
+ XILINX_CDMA_CR_SGMODE);
+
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2017-12-21 10:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 10:11 [LINUX PATCH 0/4] dmaengine: xilinx_dma: Bug fixes Kedareswara rao Appana
2017-12-21 10:11 ` [LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures Kedareswara rao Appana
2018-01-03 3:57 ` Vinod Koul
2018-01-03 5:09 ` Appana Durga Kedareswara Rao
2017-12-21 10:11 ` Kedareswara rao Appana [this message]
2018-01-03 3:58 ` [LINUX PATCH 2/4] dmaengine: xilinx_dma: Fix race condition in the driver for cdma Vinod Koul
2018-01-03 5:10 ` Appana Durga Kedareswara Rao
2017-12-21 10:11 ` [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning Kedareswara rao Appana
2018-01-03 3:59 ` Vinod Koul
2018-01-03 5:13 ` Appana Durga Kedareswara Rao
2018-01-03 5:27 ` Vinod Koul
2018-01-03 6:10 ` Appana Durga Kedareswara Rao
2018-01-03 9:09 ` Appana Durga Kedareswara Rao
2017-12-21 10:11 ` [LINUX PATCH 4/4] dmaengine: xilinx_dma: Free BD consistent memory Kedareswara rao Appana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513851098-15787-3-git-send-email-appanad@xilinx.com \
--to=appana.durga.rao@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).