* [PATCH 2/5] ARM: dts: imx28: Pass unit address and reg to IOMUX node
2017-12-27 14:04 [PATCH 1/5] ARM: dts: imx23: Pass unit address and reg to IOMUX node Fabio Estevam
@ 2017-12-27 14:04 ` Fabio Estevam
2017-12-27 14:04 ` [PATCH 3/5] ARM: dts: imx28-tx28: " Fabio Estevam
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2017-12-27 14:04 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Pass unit address and reg to IOMUX node to fix the following build
warning with W=1:
arch/arm/boot/dts/imx28-apf28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/gpmi-status-cfg missing or empty reg/ranges property
arch/arm/boot/dts/imx28-apf28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/mmc0-cd-cfg missing or empty reg/ranges property
arch/arm/boot/dts/imx28-apf28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/mmc0-sck-cfg missing or empty reg/ranges property
arch/arm/boot/dts/imx28-apf28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/mmc1-cd-cfg missing or empty reg/ranges property
arch/arm/boot/dts/imx28-apf28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/mmc1-sck-cfg missing or empty reg/ranges property
arch/arm/boot/dts/imx28-apf28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/mmc2-cd-cfg missing or empty reg/ranges property
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/boot/dts/imx28.dtsi | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 2f4ebe0..8a6f3e0 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -283,7 +283,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- gpmi_status_cfg: gpmi-status-cfg {
+ gpmi_status_cfg: gpmi-status-cfg at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_GPMI_RDN__GPMI_RDN
MX28_PAD_GPMI_WRN__GPMI_WRN
@@ -527,14 +528,16 @@
fsl,pull-up = <MXS_PULL_ENABLE>;
};
- mmc0_cd_cfg: mmc0-cd-cfg {
+ mmc0_cd_cfg: mmc0-cd-cfg at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT
>;
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- mmc0_sck_cfg: mmc0-sck-cfg {
+ mmc0_sck_cfg: mmc0-sck-cfg at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_SSP0_SCK__SSP0_SCK
>;
@@ -558,14 +561,16 @@
fsl,pull-up = <MXS_PULL_ENABLE>;
};
- mmc1_cd_cfg: mmc1-cd-cfg {
+ mmc1_cd_cfg: mmc1-cd-cfg at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_GPMI_RDY0__SSP1_CARD_DETECT
>;
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- mmc1_sck_cfg: mmc1-sck-cfg {
+ mmc1_sck_cfg: mmc1-sck-cfg at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_GPMI_WRN__SSP1_SCK
>;
@@ -606,7 +611,8 @@
fsl,pull-up = <MXS_PULL_ENABLE>;
};
- mmc2_cd_cfg: mmc2-cd-cfg {
+ mmc2_cd_cfg: mmc2-cd-cfg at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_AUART1_RX__SSP2_CARD_DETECT
>;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/5] ARM: dts: imx28-tx28: Pass unit address and reg to IOMUX node
2017-12-27 14:04 [PATCH 1/5] ARM: dts: imx23: Pass unit address and reg to IOMUX node Fabio Estevam
2017-12-27 14:04 ` [PATCH 2/5] ARM: dts: imx28: " Fabio Estevam
@ 2017-12-27 14:04 ` Fabio Estevam
2018-01-08 8:15 ` Lothar Waßmann
2017-12-27 14:04 ` [PATCH 4/5] ARM: dts: imx28-apx4devkit: " Fabio Estevam
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2017-12-27 14:04 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Pass unit address and reg to IOMUX node to fix the following build
warning with W=1:
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-edt-ft5x06-pins missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-flexcan-xcvr-pins missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-lcdif-23bit missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-lcdif-ctrl missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-mac0-gpio-pins missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-pca9554-pins missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/spi-gpiogrp missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-tsc2007-pins missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-usbphy0-pins missing or empty reg/ranges property
arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-usbphy1-pins missing or empty reg/ranges property
Cc: Lothar Wa?mann <LW@KARO-electronics.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/boot/dts/imx28-tx28.dts | 30 ++++++++++++++++++++----------
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 152621e..8a4f5bc 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -531,7 +531,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_edt_ft5x06_pins: tx28-edt-ft5x06-pins {
+ tx28_edt_ft5x06_pins: tx28-edt-ft5x06-pins at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_SSP0_DATA6__GPIO_2_6 /* RESET */
MX28_PAD_SSP0_DATA5__GPIO_2_5 /* IRQ */
@@ -542,7 +543,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_flexcan_xcvr_pins: tx28-flexcan-xcvr-pins {
+ tx28_flexcan_xcvr_pins: tx28-flexcan-xcvr-pins at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_LCD_D00__GPIO_1_0
>;
@@ -551,7 +553,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_lcdif_23bit_pins: tx28-lcdif-23bit {
+ tx28_lcdif_23bit_pins: tx28-lcdif-23bit at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
/* LCD_D00 may be used as Flexcan Transceiver Enable on STK5-V5 */
MX28_PAD_LCD_D01__LCD_D1
@@ -583,7 +586,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_lcdif_ctrl_pins: tx28-lcdif-ctrl {
+ tx28_lcdif_ctrl_pins: tx28-lcdif-ctrl at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_LCD_ENABLE__GPIO_1_31 /* Enable */
MX28_PAD_LCD_RESET__GPIO_3_30 /* Reset */
@@ -593,7 +597,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_mac0_pins_gpio: tx28-mac0-gpio-pins {
+ tx28_mac0_pins_gpio: tx28-mac0-gpio-pins at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_ENET0_MDC__GPIO_4_0
MX28_PAD_ENET0_MDIO__GPIO_4_1
@@ -610,7 +615,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_pca9554_pins: tx28-pca9554-pins {
+ tx28_pca9554_pins: tx28-pca9554-pins at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_PWM3__GPIO_3_28
>;
@@ -619,7 +625,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_spi_gpio_pins: spi-gpiogrp {
+ tx28_spi_gpio_pins: spi-gpiogrp at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_AUART2_RX__GPIO_3_8
MX28_PAD_AUART2_TX__GPIO_3_9
@@ -633,7 +640,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_tsc2007_pins: tx28-tsc2007-pins {
+ tx28_tsc2007_pins: tx28-tsc2007-pins at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_SAIF0_MCLK__GPIO_3_20 /* TSC2007 IRQ */
>;
@@ -643,7 +651,8 @@
};
- tx28_usbphy0_pins: tx28-usbphy0-pins {
+ tx28_usbphy0_pins: tx28-usbphy0-pins at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_GPMI_CE2N__GPIO_0_18 /* USBOTG_VBUSEN */
MX28_PAD_GPMI_CE3N__GPIO_0_19 /* USBOTH_OC */
@@ -653,7 +662,8 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
- tx28_usbphy1_pins: tx28-usbphy1-pins {
+ tx28_usbphy1_pins: tx28-usbphy1-pins at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_SPDIF__GPIO_3_27 /* USBH_VBUSEN */
MX28_PAD_JTAG_RTCK__GPIO_4_20 /* USBH_OC */
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/5] ARM: dts: imx28-tx28: Pass unit address and reg to IOMUX node
2017-12-27 14:04 ` [PATCH 3/5] ARM: dts: imx28-tx28: " Fabio Estevam
@ 2018-01-08 8:15 ` Lothar Waßmann
0 siblings, 0 replies; 8+ messages in thread
From: Lothar Waßmann @ 2018-01-08 8:15 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Wed, 27 Dec 2017 12:04:36 -0200 Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass unit address and reg to IOMUX node to fix the following build
> warning with W=1:
>
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-edt-ft5x06-pins missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-flexcan-xcvr-pins missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-lcdif-23bit missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-lcdif-ctrl missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-mac0-gpio-pins missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-pca9554-pins missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/spi-gpiogrp missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-tsc2007-pins missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-usbphy0-pins missing or empty reg/ranges property
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/tx28-usbphy1-pins missing or empty reg/ranges property
>
> Cc: Lothar Wa?mann <LW@KARO-electronics.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/boot/dts/imx28-tx28.dts | 30 ++++++++++++++++++++----------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 152621e..8a4f5bc 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -531,7 +531,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_edt_ft5x06_pins: tx28-edt-ft5x06-pins {
> + tx28_edt_ft5x06_pins: tx28-edt-ft5x06-pins at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_SSP0_DATA6__GPIO_2_6 /* RESET */
> MX28_PAD_SSP0_DATA5__GPIO_2_5 /* IRQ */
> @@ -542,7 +543,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_flexcan_xcvr_pins: tx28-flexcan-xcvr-pins {
> + tx28_flexcan_xcvr_pins: tx28-flexcan-xcvr-pins at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_LCD_D00__GPIO_1_0
> >;
> @@ -551,7 +553,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_lcdif_23bit_pins: tx28-lcdif-23bit {
> + tx28_lcdif_23bit_pins: tx28-lcdif-23bit at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> /* LCD_D00 may be used as Flexcan Transceiver Enable on STK5-V5 */
> MX28_PAD_LCD_D01__LCD_D1
> @@ -583,7 +586,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_lcdif_ctrl_pins: tx28-lcdif-ctrl {
> + tx28_lcdif_ctrl_pins: tx28-lcdif-ctrl at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_LCD_ENABLE__GPIO_1_31 /* Enable */
> MX28_PAD_LCD_RESET__GPIO_3_30 /* Reset */
> @@ -593,7 +597,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_mac0_pins_gpio: tx28-mac0-gpio-pins {
> + tx28_mac0_pins_gpio: tx28-mac0-gpio-pins at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_ENET0_MDC__GPIO_4_0
> MX28_PAD_ENET0_MDIO__GPIO_4_1
> @@ -610,7 +615,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_pca9554_pins: tx28-pca9554-pins {
> + tx28_pca9554_pins: tx28-pca9554-pins at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_PWM3__GPIO_3_28
> >;
> @@ -619,7 +625,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_spi_gpio_pins: spi-gpiogrp {
> + tx28_spi_gpio_pins: spi-gpiogrp at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_AUART2_RX__GPIO_3_8
> MX28_PAD_AUART2_TX__GPIO_3_9
> @@ -633,7 +640,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_tsc2007_pins: tx28-tsc2007-pins {
> + tx28_tsc2007_pins: tx28-tsc2007-pins at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_SAIF0_MCLK__GPIO_3_20 /* TSC2007 IRQ */
> >;
> @@ -643,7 +651,8 @@
> };
>
>
> - tx28_usbphy0_pins: tx28-usbphy0-pins {
> + tx28_usbphy0_pins: tx28-usbphy0-pins at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_GPMI_CE2N__GPIO_0_18 /* USBOTG_VBUSEN */
> MX28_PAD_GPMI_CE3N__GPIO_0_19 /* USBOTH_OC */
> @@ -653,7 +662,8 @@
> fsl,pull-up = <MXS_PULL_DISABLE>;
> };
>
> - tx28_usbphy1_pins: tx28-usbphy1-pins {
> + tx28_usbphy1_pins: tx28-usbphy1-pins at 0 {
> + reg = <0>;
> fsl,pinmux-ids = <
> MX28_PAD_SPDIF__GPIO_3_27 /* USBH_VBUSEN */
> MX28_PAD_JTAG_RTCK__GPIO_4_20 /* USBH_OC */
Acked-By: Lothar Wa?mann <LW@KARO-electronics.de>
Lothar Wa?mann
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/5] ARM: dts: imx28-apx4devkit: Pass unit address and reg to IOMUX node
2017-12-27 14:04 [PATCH 1/5] ARM: dts: imx23: Pass unit address and reg to IOMUX node Fabio Estevam
2017-12-27 14:04 ` [PATCH 2/5] ARM: dts: imx28: " Fabio Estevam
2017-12-27 14:04 ` [PATCH 3/5] ARM: dts: imx28-tx28: " Fabio Estevam
@ 2017-12-27 14:04 ` Fabio Estevam
2017-12-27 14:04 ` [PATCH 5/5] ARM: dts: imx28-cfa10049: Move i2cmux out of bus node Fabio Estevam
2018-01-25 7:40 ` [PATCH 1/5] ARM: dts: imx23: Pass unit address and reg to IOMUX node Shawn Guo
4 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2017-12-27 14:04 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Pass unit address and reg to IOMUX node to fix the following build
warning with W=1:
arch/arm/boot/dts/imx28-apx4devkit.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/mmc2-sck-cfg-apx4 missing or empty reg/ranges property
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/boot/dts/imx28-apx4devkit.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx28-apx4devkit.dts b/arch/arm/boot/dts/imx28-apx4devkit.dts
index ae07834..91456bc 100644
--- a/arch/arm/boot/dts/imx28-apx4devkit.dts
+++ b/arch/arm/boot/dts/imx28-apx4devkit.dts
@@ -82,7 +82,8 @@
fsl,pull-up = <MXS_PULL_ENABLE>;
};
- mmc2_sck_cfg_apx4: mmc2-sck-cfg-apx4 {
+ mmc2_sck_cfg_apx4: mmc2-sck-cfg-apx4 at 0 {
+ reg = <0>;
fsl,pinmux-ids = <
MX28_PAD_SSP0_DATA7__SSP2_SCK
>;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 5/5] ARM: dts: imx28-cfa10049: Move i2cmux out of bus node
2017-12-27 14:04 [PATCH 1/5] ARM: dts: imx23: Pass unit address and reg to IOMUX node Fabio Estevam
` (2 preceding siblings ...)
2017-12-27 14:04 ` [PATCH 4/5] ARM: dts: imx28-apx4devkit: " Fabio Estevam
@ 2017-12-27 14:04 ` Fabio Estevam
2018-01-04 12:53 ` Maxime Ripard
2018-01-25 7:40 ` [PATCH 1/5] ARM: dts: imx23: Pass unit address and reg to IOMUX node Shawn Guo
4 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2017-12-27 14:04 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Move i2cmux node from soc node to root node.
i2cmux node does not have any register properties and thus shouldn't be
placed on the bus.
This fixes the following build warnings with W=1:
arch/arm/boot/dts/imx28-cfa10049.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbx at 80040000/i2cmux missing or empty reg/ranges property
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/boot/dts/imx28-cfa10049.dts | 130 +++++++++++++++++------------------
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/arch/arm/boot/dts/imx28-cfa10049.dts b/arch/arm/boot/dts/imx28-cfa10049.dts
index 4cd52d5..60e5c7f 100644
--- a/arch/arm/boot/dts/imx28-cfa10049.dts
+++ b/arch/arm/boot/dts/imx28-cfa10049.dts
@@ -19,6 +19,71 @@
model = "Crystalfontz CFA-10049 Board";
compatible = "crystalfontz,cfa10049", "crystalfontz,cfa10036", "fsl,imx28";
+ i2cmux {
+ compatible = "i2c-mux-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2cmux_pins_cfa10049>;
+ mux-gpios = <&gpio1 22 0 &gpio1 23 0>;
+ i2c-parent = <&i2c1>;
+
+ i2c at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+
+ adc0: nau7802 at 2a {
+ compatible = "nuvoton,nau7802";
+ reg = <0x2a>;
+ nuvoton,vldo = <3000>;
+ };
+ };
+
+ i2c at 1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+
+ adc1: nau7802 at 2a {
+ compatible = "nuvoton,nau7802";
+ reg = <0x2a>;
+ nuvoton,vldo = <3000>;
+ };
+ };
+
+ i2c at 2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+
+ adc2: nau7802 at 2a {
+ compatible = "nuvoton,nau7802";
+ reg = <0x2a>;
+ nuvoton,vldo = <3000>;
+ };
+ };
+
+ i2c at 3 {
+ reg = <3>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pca9555: pca9555 at 20 {
+ compatible = "nxp,pca9555";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pca_pins_cfa10049>;
+ interrupt-parent = <&gpio2>;
+ interrupts = <19 0x2>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ reg = <0x20>;
+ };
+ };
+ };
+
apb at 80000000 {
apbh at 80000000 {
pinctrl at 80018000 {
@@ -219,71 +284,6 @@
status = "okay";
};
- i2cmux {
- compatible = "i2c-mux-gpio";
- #address-cells = <1>;
- #size-cells = <0>;
- pinctrl-names = "default";
- pinctrl-0 = <&i2cmux_pins_cfa10049>;
- mux-gpios = <&gpio1 22 0 &gpio1 23 0>;
- i2c-parent = <&i2c1>;
-
- i2c at 0 {
- #address-cells = <1>;
- #size-cells = <0>;
- reg = <0>;
-
- adc0: nau7802 at 2a {
- compatible = "nuvoton,nau7802";
- reg = <0x2a>;
- nuvoton,vldo = <3000>;
- };
- };
-
- i2c at 1 {
- #address-cells = <1>;
- #size-cells = <0>;
- reg = <1>;
-
- adc1: nau7802 at 2a {
- compatible = "nuvoton,nau7802";
- reg = <0x2a>;
- nuvoton,vldo = <3000>;
- };
- };
-
- i2c at 2 {
- #address-cells = <1>;
- #size-cells = <0>;
- reg = <2>;
-
- adc2: nau7802 at 2a {
- compatible = "nuvoton,nau7802";
- reg = <0x2a>;
- nuvoton,vldo = <3000>;
- };
- };
-
- i2c at 3 {
- reg = <3>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- pca9555: pca9555 at 20 {
- compatible = "nxp,pca9555";
- pinctrl-names = "default";
- pinctrl-0 = <&pca_pins_cfa10049>;
- interrupt-parent = <&gpio2>;
- interrupts = <19 0x2>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- reg = <0x20>;
- };
- };
- };
-
usbphy1: usbphy at 8007e000 {
status = "okay";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 1/5] ARM: dts: imx23: Pass unit address and reg to IOMUX node
2017-12-27 14:04 [PATCH 1/5] ARM: dts: imx23: Pass unit address and reg to IOMUX node Fabio Estevam
` (3 preceding siblings ...)
2017-12-27 14:04 ` [PATCH 5/5] ARM: dts: imx28-cfa10049: Move i2cmux out of bus node Fabio Estevam
@ 2018-01-25 7:40 ` Shawn Guo
4 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2018-01-25 7:40 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 27, 2017 at 12:04:34PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass unit address and reg to IOMUX node to fix the following build
> warning with W=1:
>
> arch/arm/boot/dts/imx23-evk.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/gpmi-pins-fixup missing or empty reg/ranges property
> arch/arm/boot/dts/imx23-evk.dtb: Warning (simple_bus_reg): Node /apb at 80000000/apbh at 80000000/pinctrl at 80018000/mmc0-pins-fixup missing or empty reg/ranges property
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied all, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread