From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Fri, 05 Jan 2018 10:09:30 +0100 Subject: [PATCH -next] clk: meson-axg: fix potential NULL dereference in axg_clkc_probe() In-Reply-To: <1515117059-176004-1-git-send-email-weiyongjun1@huawei.com> References: <1515117059-176004-1-git-send-email-weiyongjun1@huawei.com> Message-ID: <1515143370.7439.62.camel@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2018-01-05 at 01:50 +0000, Wei Yongjun wrote: > platform_get_resource() may return NULL, add proper > check to avoid potential NULL dereferencing. > > This is detected by Coccinelle semantic patch. > > @@ > expression pdev, res, n, t, e, e1, e2; > @@ > > res = platform_get_resource(pdev, t, n); > + if (!res) > + return -EINVAL; > ... when != res == NULL > e = devm_ioremap(e1, res->start, e2); > > Signed-off-by: Wei Yongjun > --- Looks good. Thank you. Stephen, do you prefer to take this directly ?