From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: soc: imx: gpcv2: removing and probing fails
Date: Tue, 09 Jan 2018 15:24:46 +0100 [thread overview]
Message-ID: <1515507886.12538.33.camel@pengutronix.de> (raw)
In-Reply-To: <3f836677c6e98aaf01bc1ac8c3410083@agner.ch>
Am Sonntag, den 07.01.2018, 11:48 +0100 schrieb Stefan Agner:
> Hi Andrew,
>
> I noticed that the driver fails when removing and probing again. As far
> as I can see due to duplicate add of the platform devices.
>
> As far as I can tell the driver should register the remove callback and
> do a platform_device_unregister on the newly created platform devices.
> However, as far as I can tell we don't hold on to a reference to them...
> I guess we could keep references in imx_gpcv2_probe, but maybe there is
> an easier way?
The GPC v1 driver adds the necessary device dependency between the
power domain devices and the GPC parent device. See the
device_link_add() in imx_pgc_power_domain_probe().
Probably something similar can be done to the GPC v2 driver.
Regards,
Lucas
next prev parent reply other threads:[~2018-01-09 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 10:48 soc: imx: gpcv2: removing and probing fails Stefan Agner
2018-01-08 0:22 ` Andrey Smirnov
2018-01-08 6:24 ` Andrey Smirnov
2018-01-08 21:12 ` Stefan Agner
2018-01-09 14:24 ` Lucas Stach [this message]
2018-01-09 14:44 ` Stefan Agner
2018-01-09 14:55 ` Lucas Stach
2018-01-09 19:26 ` Stefan Agner
2018-01-09 21:08 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515507886.12538.33.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).