From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers
Date: Thu, 11 Jan 2018 20:06:23 +1100 [thread overview]
Message-ID: <1515661583.31850.34.camel@kernel.crashing.org> (raw)
In-Reply-To: <20180109223126.13093-4-jae.hyun.yoo@linux.intel.com>
On Tue, 2018-01-09 at 14:31 -0800, Jae Hyun Yoo wrote:
> +struct peci_rd_ia_msr_msg {
> + unsigned char target;
> + unsigned char thread_id;
> + unsigned short address;
> + unsigned long value;
> +};
Those types are representing messages on the wire ?
In that case those types aren't suitable. For example "long" will have
a different size and alignment for 32 and 64-bit userspace. There are
size-explicit userspace types available.
Also I didn't see any endianness annotations in there. Is that expected
? IE are those wire format packets ?
Cheers,
Ben.
next prev parent reply other threads:[~2018-01-11 9:06 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 22:31 [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 1/6] Documentation: dt-bindings: Add Aspeed PECI Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 2/6] ARM: dts: aspeed: peci: " Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers Jae Hyun Yoo
2018-01-10 10:18 ` Greg KH
2018-01-10 19:32 ` Jae Hyun Yoo
2018-01-11 9:02 ` Benjamin Herrenschmidt
2018-01-11 20:33 ` Jae Hyun Yoo
2018-01-10 10:20 ` Greg KH
2018-01-10 19:34 ` Jae Hyun Yoo
2018-01-10 11:55 ` Arnd Bergmann
2018-01-10 23:11 ` Jae Hyun Yoo
2018-01-11 9:06 ` Benjamin Herrenschmidt [this message]
2018-01-11 20:42 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 4/6] Documentation: dt-bindings: Add a generic PECI hwmon Jae Hyun Yoo
2018-01-10 12:20 ` Arnd Bergmann
2018-01-10 23:20 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 5/6] Documentation: hwmon: " Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for " Jae Hyun Yoo
2018-01-10 12:29 ` Arnd Bergmann
2018-01-10 23:45 ` Jae Hyun Yoo
2018-01-11 13:22 ` Arnd Bergmann
2018-01-11 20:49 ` Jae Hyun Yoo
2018-01-10 21:47 ` [linux, dev-4.10, " Guenter Roeck
2018-01-11 19:47 ` Jae Hyun Yoo
2018-01-11 21:40 ` Guenter Roeck
2018-01-11 22:18 ` Andrew Lunn
2018-01-11 23:14 ` Jae Hyun Yoo
2018-01-11 23:53 ` Andrew Lunn
2018-01-12 0:26 ` Jae Hyun Yoo
2018-01-11 23:03 ` Jae Hyun Yoo
2018-01-10 10:17 ` [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers Greg KH
2018-01-10 19:14 ` Jae Hyun Yoo
2018-01-10 19:17 ` Greg KH
2018-01-10 19:30 ` Jae Hyun Yoo
2018-01-10 20:27 ` Greg KH
2018-01-10 21:46 ` Jae Hyun Yoo
2018-01-11 7:30 ` Greg KH
2018-01-11 8:28 ` Joel Stanley
2018-01-11 8:41 ` Greg KH
2018-01-11 9:17 ` Arnd Bergmann
2018-01-11 9:21 ` Benjamin Herrenschmidt
2018-01-11 8:56 ` Benjamin Herrenschmidt
2018-01-11 9:59 ` Greg KH
2018-01-11 20:49 ` Benjamin Herrenschmidt
2018-01-11 19:54 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515661583.31850.34.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).