linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog
Date: Mon, 05 Feb 2018 12:12:53 +0100	[thread overview]
Message-ID: <1517829173.3175.11.camel@pengutronix.de> (raw)
In-Reply-To: <78318e96c952c5f84644e7035cdefe76f27a9e3c.1517816731.git.baruch@tkos.co.il>

Am Montag, den 05.02.2018, 09:45 +0200 schrieb Baruch Siach:
> The external nWDOG signal connects to the EVK board reset circuit.
> 
> Tested on the i.MX8MQ EVK rev B3.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> ?arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 15 +++++++++++++++
> ?1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index c0e5ee5d6243..757ba226a2fc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -170,6 +170,13 @@
> ?	status = "okay";
> ?};
> ?
> +&wdog1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_wdog>;
> +	fsl,ext-reset-output;
> +	status = "okay";
> +};
> +
> ?&iomuxc {
> ?	pinctrl_fec1_mdc: fec1mdcgrp {
> ?		pinmux = <MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC>;
> @@ -402,4 +409,12 @@
> ?		bias-pull-up;
> ?		input-schmitt-enable;
> ?	};
> +
> +	pinctrl_wdog: wdoggrp {
> +		fsl,pins = <MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B>;
> +		drive-strength = <6>;
> +		slew-rate = <0>;
> +		bias-pull-up;
> +		input-schmitt-enable;

This might be a plain copy of the downstream pinctrl, but the watchdog
pin being an output, does it really make sense to enable the schmitt-
trigger?

Regards,
Lucas

  reply	other threads:[~2018-02-05 11:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05  7:45 [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Baruch Siach
2018-02-05  7:45 ` [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog Baruch Siach
2018-02-05 11:12   ` Lucas Stach [this message]
2018-02-05 10:27 ` [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Fabio Estevam
2018-02-05 11:21 ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517829173.3175.11.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).