* [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices
@ 2018-02-05 7:45 Baruch Siach
2018-02-05 7:45 ` [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog Baruch Siach
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Baruch Siach @ 2018-02-05 7:45 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 50ed302d299a..740457e2a0bf 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -250,6 +250,30 @@
"clk_ext1", "clk_ext2",
"clk_ext3", "clk_ext4";
};
+
+ wdog1: wdog at 30280000 {
+ compatible = "fsl,imx21-wdt";
+ reg = <0x30280000 0x10000>;
+ interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_WDOG1_ROOT>;
+ status = "disabled";
+ };
+
+ wdog2: wdog at 30290000 {
+ compatible = "fsl,imx21-wdt";
+ reg = <0x30290000 0x10000>;
+ interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_WDOG2_ROOT>;
+ status = "disabled";
+ };
+
+ wdog3: wdog at 302a0000 {
+ compatible = "fsl,imx21-wdt";
+ reg = <0x302a0000 0x10000>;
+ interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>;
+ status = "disabled";
+ };
};
bus at 30400000 { /* AIPS2 */
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog
2018-02-05 7:45 [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Baruch Siach
@ 2018-02-05 7:45 ` Baruch Siach
2018-02-05 11:12 ` Lucas Stach
2018-02-05 10:27 ` [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Fabio Estevam
2018-02-05 11:21 ` Lucas Stach
2 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2018-02-05 7:45 UTC (permalink / raw)
To: linux-arm-kernel
The external nWDOG signal connects to the EVK board reset circuit.
Tested on the i.MX8MQ EVK rev B3.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
index c0e5ee5d6243..757ba226a2fc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
@@ -170,6 +170,13 @@
status = "okay";
};
+&wdog1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wdog>;
+ fsl,ext-reset-output;
+ status = "okay";
+};
+
&iomuxc {
pinctrl_fec1_mdc: fec1mdcgrp {
pinmux = <MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC>;
@@ -402,4 +409,12 @@
bias-pull-up;
input-schmitt-enable;
};
+
+ pinctrl_wdog: wdoggrp {
+ fsl,pins = <MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B>;
+ drive-strength = <6>;
+ slew-rate = <0>;
+ bias-pull-up;
+ input-schmitt-enable;
+ };
};
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog
2018-02-05 7:45 ` [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog Baruch Siach
@ 2018-02-05 11:12 ` Lucas Stach
0 siblings, 0 replies; 5+ messages in thread
From: Lucas Stach @ 2018-02-05 11:12 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, den 05.02.2018, 09:45 +0200 schrieb Baruch Siach:
> The external nWDOG signal connects to the EVK board reset circuit.
>
> Tested on the i.MX8MQ EVK rev B3.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> ?arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 15 +++++++++++++++
> ?1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index c0e5ee5d6243..757ba226a2fc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -170,6 +170,13 @@
> ? status = "okay";
> ?};
> ?
> +&wdog1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_wdog>;
> + fsl,ext-reset-output;
> + status = "okay";
> +};
> +
> ?&iomuxc {
> ? pinctrl_fec1_mdc: fec1mdcgrp {
> ? pinmux = <MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC>;
> @@ -402,4 +409,12 @@
> ? bias-pull-up;
> ? input-schmitt-enable;
> ? };
> +
> + pinctrl_wdog: wdoggrp {
> + fsl,pins = <MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B>;
> + drive-strength = <6>;
> + slew-rate = <0>;
> + bias-pull-up;
> + input-schmitt-enable;
This might be a plain copy of the downstream pinctrl, but the watchdog
pin being an output, does it really make sense to enable the schmitt-
trigger?
Regards,
Lucas
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices
2018-02-05 7:45 [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Baruch Siach
2018-02-05 7:45 ` [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog Baruch Siach
@ 2018-02-05 10:27 ` Fabio Estevam
2018-02-05 11:21 ` Lucas Stach
2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-02-05 10:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi Baruch,
On Mon, Feb 5, 2018 at 5:45 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 50ed302d299a..740457e2a0bf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -250,6 +250,30 @@
> "clk_ext1", "clk_ext2",
> "clk_ext3", "clk_ext4";
> };
> +
> + wdog1: wdog at 30280000 {
> + compatible = "fsl,imx21-wdt";
Please use:
compatible = "fsl,imx8mq-wdt", "fsl,imx21-wdt"; instead.
This is the preferred way as it allows us to apply specific mx8qm
fixes if needed.
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices
2018-02-05 7:45 [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Baruch Siach
2018-02-05 7:45 ` [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog Baruch Siach
2018-02-05 10:27 ` [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Fabio Estevam
@ 2018-02-05 11:21 ` Lucas Stach
2 siblings, 0 replies; 5+ messages in thread
From: Lucas Stach @ 2018-02-05 11:21 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, den 05.02.2018, 09:45 +0200 schrieb Baruch Siach:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> ?arch/arm64/boot/dts/freescale/imx8mq.dtsi | 24 ++++++++++++++++++++++++
> ?1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 50ed302d299a..740457e2a0bf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -250,6 +250,30 @@
> > ? ??????????????"clk_ext1", "clk_ext2",
> > ? ??????????????"clk_ext3", "clk_ext4";
> > ? };
> +
> + wdog1: wdog at 30280000 {
watchdog@, please.
Otherwise looks good to me, so with this fixed:
Reviewed-by: Lucas Stach <l.stach@pengutronix.de
> + compatible = "fsl,imx21-wdt";
> > + reg = <0x30280000 0x10000>;
> > + interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_WDOG1_ROOT>;
> > + status = "disabled";
> > + };
> +
> > > + wdog2: wdog at 30290000 {
> > + compatible = "fsl,imx21-wdt";
> > + reg = <0x30290000 0x10000>;
> > + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_WDOG2_ROOT>;
> > + status = "disabled";
> > + };
> +
> > > + wdog3: wdog at 302a0000 {
> > + compatible = "fsl,imx21-wdt";
> > + reg = <0x302a0000 0x10000>;
> > + interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>;
> > + status = "disabled";
> > + };
> > ? };
> ?
> > ? bus at 30400000 { /* AIPS2 */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-05 11:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-05 7:45 [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Baruch Siach
2018-02-05 7:45 ` [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable watchdog Baruch Siach
2018-02-05 11:12 ` Lucas Stach
2018-02-05 10:27 ` [PATCH 1/2] arm64: dts: fsl: imx8mq: add watchdog devices Fabio Estevam
2018-02-05 11:21 ` Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).