linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] arm64: uaccess: Prevent speculative use of the current addr_limit
Date: Mon,  5 Feb 2018 15:34:21 +0000	[thread overview]
Message-ID: <1517844864-15887-7-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1517844864-15887-1-git-send-email-will.deacon@arm.com>

A mispredicted conditional call to set_fs could result in the wrong
addr_limit being forwarded under speculation to a subsequent access_ok
check, potentially forming part of a spectre-v1 attack using uaccess
routines.

This patch prevents this forwarding from taking place, but putting heavy
barriers in set_fs after writing the addr_limit.

Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
 arch/arm64/include/asm/uaccess.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index e49fe723d72d..2057deed7697 100644
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -42,6 +42,13 @@ static inline void set_fs(mm_segment_t fs)
 {
 	current_thread_info()->addr_limit = fs;
 
+	/*
+	 * Prevent a mispredicted conditional call to set_fs from forwarding
+	 * the wrong address limit to access_ok under speculation.
+	 */
+	dsb(nsh);
+	isb();
+
 	/* On user-mode return, check fs is correct */
 	set_thread_flag(TIF_FSCHECK);
 
-- 
2.1.4

  parent reply	other threads:[~2018-02-05 15:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 15:34 [PATCH 0/9] Mitigations against spectre-v1 in the arm64 Linux kernel Will Deacon
2018-02-05 15:34 ` [PATCH 1/9] arm64: barrier: Add CSDB macros to control data-value prediction Will Deacon
2018-02-05 15:34 ` [PATCH 2/9] arm64: Implement array_index_mask_nospec() Will Deacon
2018-02-05 15:34 ` [PATCH 3/9] arm64: Make USER_DS an inclusive limit Will Deacon
2018-02-05 15:34 ` [PATCH 4/9] arm64: Use pointer masking to limit uaccess speculation Will Deacon
2018-02-05 15:34 ` [PATCH 5/9] arm64: entry: Ensure branch through syscall table is bounded under speculation Will Deacon
2018-02-05 15:34 ` Will Deacon [this message]
2018-02-05 15:34 ` [PATCH 7/9] arm64: uaccess: Don't bother eliding access_ok checks in __{get, put}_user Will Deacon
2018-02-05 15:34 ` [PATCH 8/9] arm64: uaccess: Mask __user pointers for __arch_{clear, copy_*}_user Will Deacon
2018-02-05 15:34 ` [PATCH 9/9] arm64: futex: Mask __user pointers prior to dereference Will Deacon
2018-02-06 22:17 ` [PATCH 0/9] Mitigations against spectre-v1 in the arm64 Linux kernel Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517844864-15887-7-git-send-email-will.deacon@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).