public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: sean.wang@mediatek.com (Sean Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 06/16] arm64: dts: mt7622: add cpufreq related device nodes
Date: Wed, 7 Feb 2018 14:16:18 +0800	[thread overview]
Message-ID: <1517984178.9025.2.camel@mtkswgap22> (raw)
In-Reply-To: <20180207033331.GK28462@vireshk-i7>

On Wed, 2018-02-07 at 09:03 +0530, Viresh Kumar wrote:
> On 06-02-18, 17:52, sean.wang at mediatek.com wrote:
> >  	cpus {
> >  		#address-cells = <2>;
> >  		#size-cells = <0>;
> > @@ -26,6 +70,10 @@
> >  			device_type = "cpu";
> >  			compatible = "arm,cortex-a53", "arm,armv8";
> >  			reg = <0x0 0x0>;
> > +			clocks = <&infracfg CLK_INFRA_MUX1_SEL>,
> > +				 <&apmixedsys CLK_APMIXED_MAIN_CORE_EN>;
> > +			clock-names = "cpu", "intermediate";
> > +			operating-points-v2 = <&cpu_opp_table>;
> >  			enable-method = "psci";
> >  			clock-frequency = <1300000000>;
> >  		};
> > @@ -34,6 +82,7 @@
> >  			device_type = "cpu";
> >  			compatible = "arm,cortex-a53", "arm,armv8";
> >  			reg = <0x0 0x1>;
> > +			operating-points-v2 = <&cpu_opp_table>;
> >  			enable-method = "psci";
> >  			clock-frequency = <1300000000>;
> >  		};
> 
> Sorry for not picking this earlier, but you should probably add the same clock
> related properties for both cpu nodes here. Things will break if CPU1 is used by
> the cpufreq core to bring the cpufreq policy online.
> 
> This can happen if cpufreq driver is a module, CPU0 is hotplugged out and then
> the cpufreq driver is inserted.
> 

mt7622 cpu0 does not support hotplug. do I still need to add same clock
related properties for both cpu nodes here?

  reply	other threads:[~2018-02-07  6:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06  9:52 [PATCH v2 00/16] add dts nodes to MT7622 SoC sean.wang at mediatek.com
2018-02-06  9:52 ` [PATCH v2 01/16] dt-bindings: clock: mediatek: add missing required #reset-cells sean.wang at mediatek.com
2018-02-07 10:45   ` Matthias Brugger
2018-02-09  3:38     ` Sean Wang
2018-02-06  9:52 ` [PATCH v2 02/16] arm64: dts: mt7622: add clock controller device nodes sean.wang at mediatek.com
2018-02-06  9:52 ` [PATCH v2 03/16] arm64: dts: mt7622: add power domain " sean.wang at mediatek.com
2018-02-06  9:52 ` [PATCH v2 04/16] arm64: dts: mt7622: add pinctrl related " sean.wang at mediatek.com
2018-02-07 11:31   ` Matthias Brugger
2018-02-09  3:41     ` Sean Wang
2018-02-06  9:52 ` [PATCH v2 05/16] arm64: dts: mt7622: add PMIC MT6380 related nodes sean.wang at mediatek.com
2018-02-08 14:46   ` Philippe Ombredanne
2018-02-06  9:52 ` [PATCH v2 06/16] arm64: dts: mt7622: add cpufreq related device nodes sean.wang at mediatek.com
2018-02-07  3:33   ` Viresh Kumar
2018-02-07  6:16     ` Sean Wang [this message]
2018-02-07  6:18       ` Viresh Kumar
2018-02-07  8:34         ` Sean Wang
2018-02-06  9:52 ` [PATCH v2 07/16] arm64: dts: mt7622: turn uart0 clock to real ones sean.wang at mediatek.com
2018-02-06  9:52 ` [PATCH v2 08/16] arm64: dts: mt7622: add SoC and peripheral related device nodes sean.wang at mediatek.com
2018-02-06  9:52 ` [PATCH v2 09/16] arm64: dts: mt7622: add flash " sean.wang at mediatek.com
2018-02-06  9:52 ` [PATCH v2 10/16] arm64: dts: mt7622: add ethernet " sean.wang at mediatek.com
2018-02-06  9:53 ` [PATCH v2 11/16] arm64: dts: mt7622: add PCIe " sean.wang at mediatek.com
2018-02-06  9:53 ` [PATCH v2 12/16] arm64: dts: mt7622: add SATA " sean.wang at mediatek.com
2018-02-06  9:53 ` [PATCH v2 13/16] arm64: dts: mt7622: add usb " sean.wang at mediatek.com
2018-02-06  9:53 ` [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes sean.wang at mediatek.com
2018-02-07 11:43   ` Matthias Brugger
2018-02-09  3:51     ` Sean Wang
2018-02-12 11:55       ` Matthias Brugger
2018-02-06  9:53 ` [PATCH v2 15/16] arm64: dts: mt7622: add High-Speed DMA device nodes sean.wang at mediatek.com
2018-02-06  9:53 ` [PATCH v2 16/16] arm64: dts: mt7622: add mmc related " sean.wang at mediatek.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517984178.9025.2.camel@mtkswgap22 \
    --to=sean.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox