From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
Date: Thu, 1 Mar 2018 21:34:44 +0100 [thread overview]
Message-ID: <1519936484-23132-1-git-send-email-krzk@kernel.org> (raw)
Interrupt number 0 (returned by platform_get_irq()) might be a valid IRQ
so do not treat it as an error. If interrupt 0 was configured, the driver
would exit the probe early, before finishing initialization, but with
0-exit status.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable at vger.kernel.org
Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/busses/i2c-s3c2410.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 5d97510ee48b..783a93404f47 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1178,7 +1178,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
*/
if (!(i2c->quirks & QUIRK_POLL)) {
i2c->irq = ret = platform_get_irq(pdev, 0);
- if (ret <= 0) {
+ if (ret < 0) {
dev_err(&pdev->dev, "cannot find IRQ\n");
clk_unprepare(i2c->clk);
return ret;
--
2.7.4
next reply other threads:[~2018-03-01 20:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 20:34 Krzysztof Kozlowski [this message]
2018-03-02 10:29 ` [PATCH] i2c: s3c2410: Properly handle interrupts of number 0 Wolfram Sang
2018-03-02 11:00 ` Dan Carpenter
2018-03-02 11:02 ` Dan Carpenter
2018-03-02 11:08 ` Wolfram Sang
2018-03-02 11:19 ` Russell King - ARM Linux
2018-03-02 11:49 ` Dan Carpenter
2018-03-02 12:19 ` Russell King - ARM Linux
2018-03-02 12:26 ` Dan Carpenter
2018-03-02 12:34 ` Russell King - ARM Linux
2018-03-02 12:46 ` Wolfram Sang
2018-03-02 12:59 ` Russell King - ARM Linux
2018-03-02 13:58 ` Wolfram Sang
2018-03-02 14:09 ` Dan Carpenter
2018-03-02 15:32 ` Russell King - ARM Linux
2018-03-02 16:28 ` Mark Rutland
2018-03-03 16:25 ` Andy Shevchenko
2018-03-03 18:36 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519936484-23132-1-git-send-email-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox