From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 5/7] fm10k: Eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 14:52:58 -0400	[thread overview]
Message-ID: <1521831180-25014-6-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521831180-25014-1-git-send-email-okaya@codeaurora.org>
Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
the register write.
Since code already has an explicit barrier call, changing writel() to
writel_relaxed().
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/net/ethernet/intel/fm10k/fm10k_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
index 409554d..bb94f04 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
@@ -180,7 +180,7 @@ void fm10k_alloc_rx_buffers(struct fm10k_ring *rx_ring, u16 cleaned_count)
 		wmb();
 
 		/* notify hardware of new descriptors */
-		writel(i, rx_ring->tail);
+		writel_relaxed(i, rx_ring->tail);
 	}
 }
 
@@ -1055,7 +1055,7 @@ static void fm10k_tx_map(struct fm10k_ring *tx_ring,
 
 	/* notify HW of packet */
 	if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
-		writel(i, tx_ring->tail);
+		writel_relaxed(i, tx_ring->tail);
 
 		/* we need this if more than one processor can write to our tail
 		 * at a time, it synchronizes IO on IA64/Altix systems
-- 
2.7.4
next prev parent reply	other threads:[~2018-03-23 18:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23 18:52 [PATCH v7 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 1/7] i40e/i40evf: " Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 2/7] ixgbe: eliminate " Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 3/7] igbvf: " Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 4/7] igb: " Sinan Kaya
2018-03-23 18:52 ` Sinan Kaya [this message]
2018-03-23 18:52 ` [PATCH v7 6/7] ixgbevf: keep writel() closer to wmb() Sinan Kaya
2018-03-23 18:53 ` [PATCH v7 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 21:53 ` [PATCH v7 0/7] netdev: intel: Eliminate " Alexander Duyck
2018-03-23 23:58   ` Jeff Kirsher
2018-03-24  2:34     ` okaya at codeaurora.org
2018-03-27 12:42       ` Sinan Kaya
2018-03-27 14:04         ` Lino Sanfilippo
2018-03-27 14:23           ` Sinan Kaya
2018-03-27 14:33             ` Aw: " Lino Sanfilippo
2018-03-27 14:38             ` Alexander Duyck
2018-03-27 14:48               ` Sinan Kaya
2018-03-27 16:54         ` Jeff Kirsher
2018-03-27 17:33           ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1521831180-25014-6-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).