* [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()
@ 2018-03-23 3:44 Ryder Lee
2018-03-23 17:19 ` Matthias Brugger
2018-03-24 2:07 ` Rick Chang
0 siblings, 2 replies; 3+ messages in thread
From: Ryder Lee @ 2018-03-23 3:44 UTC (permalink / raw)
To: linux-arm-kernel
The error return value should be fixed as it may return EPROBE_DEFER.
Cc: Rick Chang <rick.chang@mediatek.com>
Cc: Bin Liu <bin.liu@mediatek.com>
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 226f908..af17aaa 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg)
jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec");
if (IS_ERR(jpeg->clk_jdec))
- return -EINVAL;
+ return PTR_ERR(jpeg->clk_jdec);
jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
if (IS_ERR(jpeg->clk_jdec_smi))
- return -EINVAL;
+ return PTR_ERR(jpeg->clk_jdec_smi);
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()
2018-03-23 3:44 [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init() Ryder Lee
@ 2018-03-23 17:19 ` Matthias Brugger
2018-03-24 2:07 ` Rick Chang
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2018-03-23 17:19 UTC (permalink / raw)
To: linux-arm-kernel
On 03/23/2018 04:44 AM, Ryder Lee wrote:
> The error return value should be fixed as it may return EPROBE_DEFER.
>
> Cc: Rick Chang <rick.chang@mediatek.com>
> Cc: Bin Liu <bin.liu@mediatek.com>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index 226f908..af17aaa 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg)
>
> jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec");
> if (IS_ERR(jpeg->clk_jdec))
> - return -EINVAL;
> + return PTR_ERR(jpeg->clk_jdec);
>
> jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
> if (IS_ERR(jpeg->clk_jdec_smi))
> - return -EINVAL;
> + return PTR_ERR(jpeg->clk_jdec_smi);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()
2018-03-23 3:44 [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init() Ryder Lee
2018-03-23 17:19 ` Matthias Brugger
@ 2018-03-24 2:07 ` Rick Chang
1 sibling, 0 replies; 3+ messages in thread
From: Rick Chang @ 2018-03-24 2:07 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2018-03-23 at 11:44 +0800, Ryder Lee wrote:
> The error return value should be fixed as it may return EPROBE_DEFER.
>
> Cc: Rick Chang <rick.chang@mediatek.com>
> Cc: Bin Liu <bin.liu@mediatek.com>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> ?drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
> ?1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index 226f908..af17aaa 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct
> mtk_jpeg_dev *jpeg)
> ?
> ? jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec");
> ? if (IS_ERR(jpeg->clk_jdec))
> - return -EINVAL;
> + return PTR_ERR(jpeg->clk_jdec);
> ?
> ? jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
> ? if (IS_ERR(jpeg->clk_jdec_smi))
> - return -EINVAL;
> + return PTR_ERR(jpeg->clk_jdec_smi);
> ?
> ? return 0;
> ?}
Acked-by: Rick Chang <rick.chang@mediatek.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-24 2:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-23 3:44 [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init() Ryder Lee
2018-03-23 17:19 ` Matthias Brugger
2018-03-24 2:07 ` Rick Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).