* [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema
@ 2023-06-21 23:09 Rob Herring
2023-06-22 6:00 ` Rafał Miłecki
2023-06-22 8:00 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-06-21 23:09 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Krzysztof Kozlowski,
Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list, Al Cooper
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel
The conditional if/then schema has an error as the "enum" values have
"const" in them. Drop the "const".
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
index 43a4b880534c..580fbe37b37f 100644
--- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
@@ -115,8 +115,8 @@ allOf:
compatible:
contains:
enum:
- - const: brcm,bcm4908-usb-phy
- - const: brcm,brcmstb-usb-phy
+ - brcm,bcm4908-usb-phy
+ - brcm,brcmstb-usb-phy
then:
properties:
reg:
--
2.40.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema
2023-06-21 23:09 [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema Rob Herring
@ 2023-06-22 6:00 ` Rafał Miłecki
2023-06-22 8:00 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2023-06-22 6:00 UTC (permalink / raw)
To: Rob Herring, Vinod Koul, Kishon Vijay Abraham I,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list, Al Cooper
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel
On 22.06.2023 01:09, Rob Herring wrote:
> The conditional if/then schema has an error as the "enum" values have
> "const" in them. Drop the "const".
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Oops, it's my mistake.
Fixes: 46b616c1574d ("dt-bindings: phy: brcm, brcmstb-usb-phy: add BCM4908 binding")
Acked-by: Rafał Miłecki <rafal@milecki.pl>
Thanks!
> ---
> .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> index 43a4b880534c..580fbe37b37f 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> @@ -115,8 +115,8 @@ allOf:
> compatible:
> contains:
> enum:
> - - const: brcm,bcm4908-usb-phy
> - - const: brcm,brcmstb-usb-phy
> + - brcm,bcm4908-usb-phy
> + - brcm,brcmstb-usb-phy
> then:
> properties:
> reg:
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema
2023-06-21 23:09 [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema Rob Herring
2023-06-22 6:00 ` Rafał Miłecki
@ 2023-06-22 8:00 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-06-22 8:00 UTC (permalink / raw)
To: Rob Herring
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Broadcom internal kernel review list, Al Cooper,
linux-phy, devicetree, linux-arm-kernel, linux-kernel
On 21-06-23, 17:09, Rob Herring wrote:
> The conditional if/then schema has an error as the "enum" values have
> "const" in them. Drop the "const".
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-22 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21 23:09 [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema Rob Herring
2023-06-22 6:00 ` Rafał Miłecki
2023-06-22 8:00 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).