From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/6] coresight: Set and clear sink device handler for kdump node
Date: Fri, 30 Mar 2018 11:15:23 +0800 [thread overview]
Message-ID: <1522379724-30648-6-git-send-email-leo.yan@linaro.org> (raw)
In-Reply-To: <1522379724-30648-1-git-send-email-leo.yan@linaro.org>
If Coresight path is enabled for specific CPU, the sink device handler
need to be set to kdump node; on the other hand we also need to clear
sink device handler when path is disabled.
This patch sets sink devices handler for kdump node for two separate
Coresight enabling modes: CS_MODE_SYSFS and CS_MODE_PERF; and clear the
handler when Coresight is disabled.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 5 +++++
drivers/hwtracing/coresight/coresight.c | 16 ++++++++++++++--
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 8a0ad77..f8b159c 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -139,6 +139,8 @@ static void free_event_data(struct work_struct *work)
for_each_cpu(cpu, mask) {
if (!(IS_ERR_OR_NULL(event_data->path[cpu])))
coresight_release_path(event_data->path[cpu]);
+
+ coresight_kdump_sink(cpu, NULL);
}
kfree(event_data->path);
@@ -238,6 +240,9 @@ static void *etm_setup_aux(int event_cpu, void **pages,
event_data->path[cpu] = coresight_build_path(csdev, sink);
if (IS_ERR(event_data->path[cpu]))
goto err;
+
+ if (coresight_kdump_sink(cpu, sink))
+ goto err;
}
if (!sink_ops(sink)->alloc_buffer)
diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
index 389c4ba..483a1f7 100644
--- a/drivers/hwtracing/coresight/coresight.c
+++ b/drivers/hwtracing/coresight/coresight.c
@@ -272,6 +272,7 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode)
static bool coresight_disable_source(struct coresight_device *csdev)
{
if (atomic_dec_return(csdev->refcnt) == 0) {
+
if (source_ops(csdev)->disable)
source_ops(csdev)->disable(csdev, NULL);
csdev->enable = false;
@@ -612,6 +613,13 @@ int coresight_enable(struct coresight_device *csdev)
if (ret)
goto err_source;
+ cpu = source_ops(csdev)->cpu_id(csdev);
+
+ /* Set sink device handler into kdump node */
+ ret = coresight_kdump_sink(cpu, sink);
+ if (ret)
+ goto err_kdump;
+
switch (subtype) {
case CORESIGHT_DEV_SUBTYPE_SOURCE_PROC:
/*
@@ -621,7 +629,6 @@ int coresight_enable(struct coresight_device *csdev)
* be a single session per tracer (when working from sysFS)
* a per-cpu variable will do just fine.
*/
- cpu = source_ops(csdev)->cpu_id(csdev);
per_cpu(tracer_path, cpu) = path;
break;
case CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE:
@@ -636,6 +643,9 @@ int coresight_enable(struct coresight_device *csdev)
mutex_unlock(&coresight_mutex);
return ret;
+err_kdump:
+ coresight_disable_source(csdev);
+
err_source:
coresight_disable_path(path);
@@ -659,9 +669,10 @@ void coresight_disable(struct coresight_device *csdev)
if (!csdev->enable || !coresight_disable_source(csdev))
goto out;
+ cpu = source_ops(csdev)->cpu_id(csdev);
+
switch (csdev->subtype.source_subtype) {
case CORESIGHT_DEV_SUBTYPE_SOURCE_PROC:
- cpu = source_ops(csdev)->cpu_id(csdev);
path = per_cpu(tracer_path, cpu);
per_cpu(tracer_path, cpu) = NULL;
break;
@@ -674,6 +685,7 @@ void coresight_disable(struct coresight_device *csdev)
break;
}
+ coresight_kdump_sink(cpu, NULL);
coresight_disable_path(path);
coresight_release_path(path);
--
2.7.4
next prev parent reply other threads:[~2018-03-30 3:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 3:15 [PATCH v4 0/6] Coresight: Support panic kdump Leo Yan
2018-03-30 3:15 ` [PATCH v4 1/6] doc: Add Coresight documentation directory Leo Yan
2018-03-30 3:15 ` [PATCH v4 2/6] doc: Add documentation for Coresight panic kdump Leo Yan
2018-04-02 17:26 ` Mathieu Poirier
2018-03-30 3:15 ` [PATCH v4 3/6] coresight: Support panic kdump functionality Leo Yan
2018-04-02 20:22 ` Mathieu Poirier
2018-03-30 3:15 ` [PATCH v4 4/6] coresight: tmc: Hook callback for panic kdump Leo Yan
2018-04-02 20:36 ` Mathieu Poirier
2018-03-30 3:15 ` Leo Yan [this message]
2018-04-02 21:34 ` [PATCH v4 5/6] coresight: Set and clear sink device handler for kdump node Mathieu Poirier
2018-03-30 3:15 ` [PATCH v4 6/6] coresight: etm4x: Support panic kdump Leo Yan
2018-04-02 21:57 ` Mathieu Poirier
2018-04-02 16:40 ` [PATCH v4 0/6] Coresight: " Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522379724-30648-6-git-send-email-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).