A200 driver submission for Linux mainline kernel

A200 driver submission for Linux mainline kernel

[abhijit]

Hi All,

I have tested A200/Z430 3D driver for Freescale IMX535/537 SoC by using 
port from freedreno. I wanted to submit driver patch to linux 4.14.1 for 
mainlining A200 driver support

Currently w.r.t 4.14.1 kernel, the patch has, 109 files changes, 279170 
insertions, 60 deletions

Major part of the code is taken from A200 support from Freescale Linux 
(2.6.35, 
http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/?h=imx_2.6.35)

My question was, can I submit the patch for Linux 4.14.1 kernel for 
mainlining purpose instead of linux-next?

Please point me to any case-study where such huge enhancements were 
mainlined in the past.

Any suggestions for optimizing the mainlining process?


Sorry for re-post as I sent earlier mail in html

Regards,
 ?? Abhijit

A200 driver submission for Linux mainline kernel

[Lucas Stach]

Hi Abhijit,

Am Dienstag, den 10.04.2018, 13:28 +0530 schrieb abhijit:
> Hi All,
> 
> I have tested A200/Z430 3D driver for Freescale IMX535/537 SoC by using?
> port from freedreno. I wanted to submit driver patch to linux 4.14.1 for?
> mainlining A200 driver support
> 
> Currently w.r.t 4.14.1 kernel, the patch has, 109 files changes, 279170?
> insertions, 60 deletions
> 
> Major part of the code is taken from A200 support from Freescale Linux?
> (2.6.35,?
> http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/?h=imx_2.6.35)
> 
> My question was, can I submit the patch for Linux 4.14.1 kernel for?
> mainlining purpose instead of linux-next?
> 
> Please point me to any case-study where such huge enhancements were?
> mainlined in the past.
> 
> Any suggestions for optimizing the mainlining process?

The downstream driver will not be acceptable to mainline. It's not just
the size of the driver itself, but it's just full of cruft and doesn't
integrate with any of the modern kernel frameworks.

If you are going to mainline this driver, it likely needs a full
rewrite as a proper DRM driver, with a userspace interface sanctioned
by the Linux DRM community.

Regards,
Lucas

A200 driver submission for Linux mainline kernel

[abhijit]

Hi Lucas,

Thank you very much for reply.

The driver is already integrated with new kernel frame-work and tested 
with 4.14.1 kernel with KGSL interface.

There are some patches for MESA and libdrm patches though

I am planning for pushing MESA and DRM patches later. Are you implying 
to push MESA and libdrm specific changes first?

Regards,

 ? Abhijit


On Tuesday 10 April 2018 02:41 PM, Lucas Stach wrote:
> Hi Abhijit,
>
> Am Dienstag, den 10.04.2018, 13:28 +0530 schrieb abhijit:
>> Hi All,
>>
>> I have tested A200/Z430 3D driver for Freescale IMX535/537 SoC by using
>> port from freedreno. I wanted to submit driver patch to linux 4.14.1 for
>> mainlining A200 driver support
>>
>> Currently w.r.t 4.14.1 kernel, the patch has, 109 files changes, 279170
>> insertions, 60 deletions
>>
>> Major part of the code is taken from A200 support from Freescale Linux
>> (2.6.35,
>> http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/?h=imx_2.6.35)
>>
>> My question was, can I submit the patch for Linux 4.14.1 kernel for
>> mainlining purpose instead of linux-next?
>>
>> Please point me to any case-study where such huge enhancements were
>> mainlined in the past.
>>
>> Any suggestions for optimizing the mainlining process?
> The downstream driver will not be acceptable to mainline. It's not just
> the size of the driver itself, but it's just full of cruft and doesn't
> integrate with any of the modern kernel frameworks.
>
> If you are going to mainline this driver, it likely needs a full
> rewrite as a proper DRM driver, with a userspace interface sanctioned
> by the Linux DRM community.
>
> Regards,
> Lucas

A200 driver submission for Linux mainline kernel

[Fabio Estevam]

Hi Abhijit,

On Tue, Apr 10, 2018 at 4:58 AM, abhijit <abhijitnaik27@gmail.com> wrote:
> Hi All,
>
> I have tested A200/Z430 3D driver for Freescale IMX535/537 SoC by using port
> from freedreno. I wanted to submit driver patch to linux 4.14.1 for
> mainlining A200 driver support
>
> Currently w.r.t 4.14.1 kernel, the patch has, 109 files changes, 279170
> insertions, 60 deletions
>
> Major part of the code is taken from A200 support from Freescale Linux
> (2.6.35,
> http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/?h=imx_2.6.35)
>
> My question was, can I submit the patch for Linux 4.14.1 kernel for
> mainlining purpose instead of linux-next?

As you are adding a new feature, it is better to base your work
against linux-next or against 4.17-rc1 when it becomes available.

> Please point me to any case-study where such huge enhancements were
> mainlined in the past.

You can take a look at:

commit a8c21a5451d831e67b7a6fb910f9ca8bc7b43554
Author: The etnaviv authors <dri-devel@lists.freedesktop.org>
Date:   Thu Dec 3 18:21:29 2015 +0100

    drm/etnaviv: add initial etnaviv DRM driver

    This adds the etnaviv DRM driver and hooks it up in Makefiles
    and Kconfig.

    Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
    Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
    Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
    Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Regards,

Fabio Estevam

A200 driver submission for Linux mainline kernel

[abhijit]

Hi All,

I have tested A200/Z430 3D driver for Freescale IMX535/537 SoC by using 
port from freedreno. I wanted to submit driver patch to linux 4.14.1 for 
mainlining A200 driver support

Currently w.r.t 4.14.1 kernel, the patch has, 109 files changes, 279170 
insertions, 60 deletions

Major part of the code is taken from A200 support from Freescale Linux 
(2.6.35, 
http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/?h=imx_2.6.35)

My question was, can I submit the patch for Linux 4.14.1 kernel for 
mainlining purpose instead of linux-next?

Please point me to any case-study where such huge enhancements were 
mainlined in the past.

Any suggestions for optimizing the mainlining process?

Regards,

 ?? Abhijit