From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [v3 09/10] drm: mediatek: Omit warning on probe defers
Date: Mon, 30 Apr 2018 18:58:36 +0800 [thread overview]
Message-ID: <1525085916.25456.8.camel@mtksdaap41> (raw)
In-Reply-To: <9d514a4ab45f0700663fa756d5aa3913922b6fb7.1524820923.git.mbrugger@suse.com>
Hi, Matthias:
On Fri, 2018-04-27 at 11:24 +0200, matthias.bgg at kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> When probe through the MFD, it can happen that the
> clock drivers wasn't probed before the ddp driver gets
> invoked. The driver used to omit a warning that the driver
> failed to get the clocks. Omit this error on the defered probe path.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
It's better to use 'drm/mediatek:' for title to align drm commits.
For the modification,
Acked-by: CK Hu <ck.hu@mediatek.com>
Regards,
CK
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index bafc5c77c4fb..6b399348a2dc 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -374,7 +374,8 @@ static int mtk_ddp_probe(struct platform_device *pdev)
>
> ddp->clk = devm_clk_get(dev, NULL);
> if (IS_ERR(ddp->clk)) {
> - dev_err(dev, "Failed to get clock\n");
> + if (PTR_ERR(ddp->clk) != -EPROBE_DEFER)
> + dev_err(dev, "Failed to get clock\n");
> return PTR_ERR(ddp->clk);
> }
>
next prev parent reply other threads:[~2018-04-30 10:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 9:23 [v3 00/10] arm/arm64: mediatek: Fix mmsys device probing matthias.bgg at kernel.org
2018-04-27 9:23 ` [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd matthias.bgg at kernel.org
2018-04-30 10:30 ` Lee Jones
2018-06-25 15:39 ` Matthias Brugger
2018-06-26 18:32 ` Rob Herring
2018-07-03 7:04 ` Lee Jones
2018-04-27 9:23 ` [v3 02/10] drm/mediatek: Use regmap for register access matthias.bgg at kernel.org
2018-04-27 9:23 ` [v3 03/10] mfd: mtk-mmsys: Add mmsys driver matthias.bgg at kernel.org
2018-04-30 10:18 ` Lee Jones
2018-05-24 2:52 ` Sean Wang
2018-06-25 15:33 ` Matthias Brugger
2018-07-03 7:11 ` Lee Jones
2018-07-04 16:17 ` Matthias Brugger
2018-07-04 16:45 ` Lee Jones
2018-07-05 11:25 ` Matthias Brugger
2018-07-05 12:22 ` Lee Jones
2018-07-06 13:18 ` Matthias Brugger
2018-07-04 16:52 ` Chen-Yu Tsai
2018-04-27 9:23 ` [v3 04/10] drm/mediatek: mt2701: switch to mfd probing matthias.bgg at kernel.org
2018-04-30 10:42 ` CK Hu
2018-04-27 9:23 ` [v3 05/10] clk: mediatek: mt2701-mm: switch to mfd device matthias.bgg at kernel.org
2018-04-27 9:23 ` [v3 06/10] mfd: mtk-mmsys: Add mt8173 nodes matthias.bgg at kernel.org
2018-04-27 9:23 ` [v3 07/10] drm/mediatek: Add mfd support for mt8173 matthias.bgg at kernel.org
2018-04-27 9:24 ` [v3 08/10] clk: mediatek: mt8173-mm: switch to mfd device matthias.bgg at kernel.org
2018-04-27 9:24 ` [v3 09/10] drm: mediatek: Omit warning on probe defers matthias.bgg at kernel.org
2018-04-30 10:58 ` CK Hu [this message]
2018-04-27 9:24 ` [v3 10/10] MAINTAINERS: update Mediatek Soc entry matthias.bgg at kernel.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525085916.25456.8.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox