linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 02/14] arm64: Use update{,_tsk}_thread_flag()
Date: Fri,  4 May 2018 17:05:23 +0100	[thread overview]
Message-ID: <1525449935-31424-3-git-send-email-Dave.Martin@arm.com> (raw)
In-Reply-To: <1525449935-31424-1-git-send-email-Dave.Martin@arm.com>

This patch uses the new update_thread_flag() helpers to simplify a
couple of if () set; else clear; constructs.

No functional change.

Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
---
 arch/arm64/kernel/fpsimd.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
index 87a3536..0c4e7e0 100644
--- a/arch/arm64/kernel/fpsimd.c
+++ b/arch/arm64/kernel/fpsimd.c
@@ -618,10 +618,8 @@ int sve_set_vector_length(struct task_struct *task,
 	task->thread.sve_vl = vl;
 
 out:
-	if (flags & PR_SVE_VL_INHERIT)
-		set_tsk_thread_flag(task, TIF_SVE_VL_INHERIT);
-	else
-		clear_tsk_thread_flag(task, TIF_SVE_VL_INHERIT);
+	update_tsk_thread_flag(task, TIF_SVE_VL_INHERIT,
+			       flags & PR_SVE_VL_INHERIT);
 
 	return 0;
 }
@@ -902,7 +900,7 @@ void fpsimd_thread_switch(struct task_struct *next)
 	if (current->mm)
 		task_fpsimd_save();
 
-	if (next->mm) {
+	if (next->mm)
 		/*
 		 * If we are switching to a task whose most recent userland
 		 * FPSIMD state is already in the registers of *this* cpu,
@@ -910,13 +908,10 @@ void fpsimd_thread_switch(struct task_struct *next)
 		 * the TIF_FOREIGN_FPSTATE flag so the state will be loaded
 		 * upon the next return to userland.
 		 */
-		if (__this_cpu_read(fpsimd_last_state.st) ==
-			&next->thread.uw.fpsimd_state
-		    && next->thread.fpsimd_cpu == smp_processor_id())
-			clear_tsk_thread_flag(next, TIF_FOREIGN_FPSTATE);
-		else
-			set_tsk_thread_flag(next, TIF_FOREIGN_FPSTATE);
-	}
+		update_tsk_thread_flag(next, TIF_FOREIGN_FPSTATE,
+			__this_cpu_read(fpsimd_last_state.st) !=
+				&next->thread.uw.fpsimd_state ||
+			next->thread.fpsimd_cpu != smp_processor_id());
 }
 
 void fpsimd_flush_thread(void)
-- 
2.1.4

  parent reply	other threads:[~2018-05-04 16:05 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 16:05 [PATCH v5 00/14] KVM: arm64: Optimise FPSIMD context switching Dave Martin
2018-05-04 16:05 ` [PATCH v5 01/14] thread_info: Add update_thread_flag() helpers Dave Martin
2018-05-04 16:05 ` Dave Martin [this message]
2018-05-04 16:05 ` [PATCH v5 03/14] KVM: arm/arm64: Introduce kvm_arch_vcpu_run_pid_change Dave Martin
2018-05-08  8:56   ` Marc Zyngier
2018-05-04 16:05 ` [PATCH v5 04/14] KVM: arm64: Convert lazy FPSIMD context switch trap to C Dave Martin
2018-05-08  9:10   ` Marc Zyngier
2018-05-04 16:05 ` [PATCH v5 05/14] arm64: fpsimd: Generalise context saving for non-task contexts Dave Martin
2018-05-08  9:20   ` Marc Zyngier
2018-05-04 16:05 ` [PATCH v5 06/14] KVM: arm64: Optimise FPSIMD handling to reduce guest/host thrashing Dave Martin
2018-05-08  9:58   ` Marc Zyngier
2018-05-08 10:14     ` Dave Martin
2018-05-04 16:05 ` [PATCH v5 07/14] arm64/sve: Move read_zcr_features() out of cpufeature.h Dave Martin
2018-05-04 16:05 ` [PATCH v5 08/14] arm64/sve: Switch sve_pffr() argument from task to thread Dave Martin
2018-05-04 16:05 ` [PATCH v5 09/14] arm64/sve: Move sve_pffr() to fpsimd.h and make inline Dave Martin
2018-05-04 16:05 ` [PATCH v5 10/14] KVM: arm64: Save host SVE context as appropriate Dave Martin
2018-05-08 10:38   ` Marc Zyngier
2018-05-08 11:25     ` Dave Martin
2018-05-08 11:57       ` Marc Zyngier
2018-05-08 12:40         ` Dave Martin
2018-05-04 16:05 ` [PATCH v5 11/14] KVM: arm64: Remove eager host SVE state saving Dave Martin
2018-05-04 16:05 ` [PATCH v5 12/14] KVM: arm64: Remove redundant *exit_code changes in fpsimd_guest_exit() Dave Martin
2018-05-08 10:51   ` Marc Zyngier
2018-05-04 16:05 ` [PATCH v5 13/14] KVM: arm64: Fold redundant exit code checks out of fixup_guest_exit() Dave Martin
2018-05-08 10:59   ` Marc Zyngier
2018-05-08 11:30     ` Dave Martin
2018-05-08 11:59       ` Marc Zyngier
2018-05-08 12:30         ` Dave Martin
2018-05-04 16:05 ` [PATCH v5 14/14] KVM: arm64: Invoke FPSIMD context switch trap from C Dave Martin
2018-05-08 11:03   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525449935-31424-3-git-send-email-Dave.Martin@arm.com \
    --to=dave.martin@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).