From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: fsl: Fix improperly quoted stdout-path values
Date: Tue, 30 Oct 2018 23:52:46 +0100 [thread overview]
Message-ID: <1526c53ef581afef7bb0ec195185483f@agner.ch> (raw)
In-Reply-To: <20181030190802.20722-1-robh@kernel.org>
On 30.10.2018 20:08, Rob Herring wrote:
> A quoted label reference doesn't expand to the node path and is taken as
> a literal string. Dropping the quotes can fix this unless the baudrate
> string is appended in which case we have to use the alias.
>
> At least on VF610, the problem was masked by setting the console in
> bootargs. Use the alias syntax with baudrate parameter so we can drop
> setting the console in bootargs.
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Stefan Agner <stefan@agner.ch>
--
Stefan
> ---
> arch/arm/boot/dts/imx53-ppd.dts | 2 +-
> arch/arm/boot/dts/vf610m4-colibri.dts | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
> index cdb90bee7b4a..f202396e3f2a 100644
> --- a/arch/arm/boot/dts/imx53-ppd.dts
> +++ b/arch/arm/boot/dts/imx53-ppd.dts
> @@ -55,7 +55,7 @@
> };
>
> chosen {
> - stdout-path = "&uart1:115200n8";
> + stdout-path = "serial0:115200n8";
> };
>
> memory at 70000000 {
> diff --git a/arch/arm/boot/dts/vf610m4-colibri.dts
> b/arch/arm/boot/dts/vf610m4-colibri.dts
> index 41ec66a96990..1a7356b841d2 100644
> --- a/arch/arm/boot/dts/vf610m4-colibri.dts
> +++ b/arch/arm/boot/dts/vf610m4-colibri.dts
> @@ -50,8 +50,8 @@
> compatible = "fsl,vf610m4";
>
> chosen {
> - bootargs = "console=ttyLP2,115200 clk_ignore_unused init=/linuxrc rw";
> - stdout-path = "&uart2";
> + bootargs = "clk_ignore_unused init=/linuxrc rw";
> + stdout-path = "serial2:115200;
> };
>
> memory at 8c000000 {
prev parent reply other threads:[~2018-10-30 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 19:08 [PATCH] ARM: dts: fsl: Fix improperly quoted stdout-path values Rob Herring
2018-10-30 19:25 ` Fabio Estevam
2018-10-30 22:52 ` Stefan Agner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526c53ef581afef7bb0ec195185483f@agner.ch \
--to=stefan@agner.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox