linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c64xx: mini6410: Correct card detect type for HSMMC1
Date: Wed, 16 Oct 2013 20:33:59 +0200	[thread overview]
Message-ID: <1527511.ScaEHrLnaz@flatron> (raw)
In-Reply-To: <1380471121-9478-1-git-send-email-tomasz.figa@gmail.com>

Hi Kukjin,

On Sunday 29 of September 2013 18:12:01 Tomasz Figa wrote:
> According to board schematics, for HSMMC1 a GPIO line is used to detect
> card presence, while currently it is being configured for internal card
> detect line, which is multiplexed with card detect line of HSMMC0 and
> thus breaking it.
> 
> This patch adds proper sdhci platform data setting card detect type to
> external GPIO and fixing operation of HSMMC0.
> 
> Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/mach-mini6410.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Would you mind taking this patch to your tree?

Best regards,
Tomasz

> diff --git a/arch/arm/mach-s3c64xx/mach-mini6410.c
> b/arch/arm/mach-s3c64xx/mach-mini6410.c index 58d46a3..97ae470 100644
> --- a/arch/arm/mach-s3c64xx/mach-mini6410.c
> +++ b/arch/arm/mach-s3c64xx/mach-mini6410.c
> @@ -36,7 +36,9 @@
>  #include <plat/devs.h>
>  #include <plat/fb.h>
>  #include <linux/platform_data/mtd-nand-s3c2410.h>
> +#include <linux/platform_data/mmc-sdhci-s3c.h>
>  #include <plat/regs-serial.h>
> +#include <plat/sdhci.h>
>  #include <linux/platform_data/touchscreen-s3c2410.h>
> 
>  #include <video/platform_lcd.h>
> @@ -214,6 +216,13 @@ static struct platform_device mini6410_lcd_powerdev
> = { .dev.platform_data	= &mini6410_lcd_power_data,
>  };
> 
> +static struct s3c_sdhci_platdata mini6410_hsmmc1_pdata = {
> +	.max_width		= 4,
> +	.cd_type		= S3C_SDHCI_CD_GPIO,
> +	.ext_cd_gpio		= S3C64XX_GPN(10),
> +	.ext_cd_gpio_invert	= true,
> +};
> +
>  static struct platform_device *mini6410_devices[] __initdata = {
>  	&mini6410_device_eth,
>  	&s3c_device_hsmmc0,
> @@ -321,6 +330,7 @@ static void __init mini6410_machine_init(void)
> 
>  	s3c_nand_set_platdata(&mini6410_nand_info);
>  	s3c_fb_set_platdata(&mini6410_lcd_pdata[features.lcd_index]);
> +	s3c_sdhci1_set_platdata(&mini6410_hsmmc1_pdata);
>  	s3c24xx_ts_set_platdata(NULL);
> 
>  	/* configure nCS1 width to 16 bits */

  reply	other threads:[~2013-10-16 18:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-29 16:12 [PATCH] ARM: s3c64xx: mini6410: Correct card detect type for HSMMC1 Tomasz Figa
2013-10-16 18:33 ` Tomasz Figa [this message]
2013-10-17 23:38   ` Kukjin Kim
2013-10-20 22:01     ` Kukjin Kim
2013-10-20 22:42       ` Tomasz Figa
  -- strict thread matches above, loose matches on Subject: below --
2013-12-13 20:19 Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1527511.ScaEHrLnaz@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).