linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/6] add virt-dma support for imx-sdma
Date: Mon, 11 Jun 2018 13:01:17 +0200	[thread overview]
Message-ID: <1528714877.2842.3.camel@pengutronix.de> (raw)
In-Reply-To: <1528729173-28684-1-git-send-email-yibin.gong@nxp.com>

Hi Robin,

this series breaks serial DMA for me. I wasn't able to dig in deeper
yet. Please let me know if you can test/reproduce at your side, if not
I'll try to find some time to collect some more debug info.

Regards,
Lucas

Am Montag, den 11.06.2018, 22:59 +0800 schrieb Robin Gong:
> The legacy sdma driver has below limitations or drawbacks:
> ? 1. Hardcode the max BDs number as "PAGE_SIZE / sizeof(*)", and alloc
> ?????one page size for one channel regardless of only few BDs needed
> ?????most time. But in few cases, the max PAGE_SIZE maybe not enough.
> ? 2. One SDMA channel can't stop immediatley once channel disabled which
> ?????means SDMA interrupt may come in after this channel terminated.There
> ?????are some patches for this corner case such as commit "2746e2c389f9",
> ?????but not cover non-cyclic.
> 
> The common virt-dma overcomes the above limitations. It can alloc bd
> dynamically and free bd once this tx transfer done. No memory wasted or
> maximum limititation here, only depends on how many memory can be requested
> from kernel. For No.2, such issue can be workaround by checking if there
> is available descript("sdmac->desc") now once the unwanted interrupt
> coming. At last the common virt-dma is easier for sdma driver maintain.
> 
> Change from v2:
> ? 1. include Sascha's patch to make the main patch easier to review.
> ?????Thanks Sacha.
> ? 2. remove useless 'desc'/'chan' in struct sdma_channe.
> 
> Change from v1:
> ? 1. split v1 patch into 5 patches.
> ? 2. remove some unnecessary condition check.
> ? 3. remove unnecessary 'pending' list.
> 
> Robin Gong (5):
> ? dmaengine: imx-sdma: add virt-dma support
> ? Revert "dmaengine: imx-sdma: fix pagefault when channel is disabled
> ????during interrupt"
> ? dmaengine: imx-sdma: remove usless lock
> ? dmaengine: imx-sdma: remove the maximum limation for bd numbers
> ? dmaengine: imx-sdma: add sdma_transfer_init to decrease code overlap
> 
> ?drivers/dma/Kconfig????|???1 +
> ?drivers/dma/imx-sdma.c | 392 ++++++++++++++++++++++++++++---------------------
> ?2 files changed, 227 insertions(+), 166 deletions(-)
> 
> --?
> 2.7.4
> 
> Robin Gong (5):
> ? dmaengine: imx-sdma: add virt-dma support
> ? Revert "dmaengine: imx-sdma: fix pagefault when channel is disabled
> ????during interrupt"
> ? dmaengine: imx-sdma: remove usless lock
> ? dmaengine: imx-sdma: remove the maximum limation for bd numbers
> ? dmaengine: imx-sdma: add sdma_transfer_init to decrease code overlap
> 
> Sascha Hauer (1):
> ? dmaengine: imx-sdma: factor out a struct sdma_desc from struct
> ????sdma_channel
> 
> ?drivers/dma/Kconfig????|???1 +
> ?drivers/dma/imx-sdma.c | 391 ++++++++++++++++++++++++++++---------------------
> ?2 files changed, 226 insertions(+), 166 deletions(-)
> 

  reply	other threads:[~2018-06-11 11:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 14:59 [PATCH v3 0/6] add virt-dma support for imx-sdma Robin Gong
2018-06-11 11:01 ` Lucas Stach [this message]
2018-06-11 12:09   ` Robin Gong
2018-06-12  8:58   ` Robin Gong
2018-06-13 16:07     ` Lucas Stach
2018-06-14  3:04       ` Robin Gong
2018-06-11 14:59 ` [PATCH v3 1/6] dmaengine: imx-sdma: factor out a struct sdma_desc from struct sdma_channel Robin Gong
2018-06-11 14:59 ` [PATCH v3 2/6] dmaengine: imx-sdma: add virt-dma support Robin Gong
2018-06-11 14:59 ` [PATCH v3 3/6] Revert "dmaengine: imx-sdma: fix pagefault when channel is disabled during interrupt" Robin Gong
2018-06-11 14:59 ` [PATCH v3 4/6] dmaengine: imx-sdma: remove usless lock Robin Gong
2018-06-13  9:53   ` Sascha Hauer
2018-06-11 14:59 ` [PATCH v3 5/6] dmaengine: imx-sdma: remove the maximum limation for bd numbers Robin Gong
2018-06-13  9:54   ` Sascha Hauer
2018-06-11 14:59 ` [PATCH v3 6/6] dmaengine: imx-sdma: add sdma_transfer_init to decrease code overlap Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528714877.2842.3.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).