linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx51: add CodaHx4 VPU
Date: Fri, 22 Jun 2018 11:43:06 +0200	[thread overview]
Message-ID: <1529660586.2431.6.camel@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5Ahv2F-WeAPFgsBcpAeb2i==SAZ45QBLvnod7jYRG0fMQ@mail.gmail.com>

Hi Fabio,

On Thu, 2018-06-21 at 17:01 -0300, Fabio Estevam wrote:
> Hi Philipp,
> 
> On Thu, Jun 21, 2018 at 4:54 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> 
> > I forgot about this between the years, this patch is safe to be applied.
> 
> In order to get the internal RAM to be functional, I think we also
> need to pass the IRAM clock in the iram node:
> 
>   iram: iram at 1ffe0000 {
>       compatible = "mmio-sram";
>       reg = <0x1ffe0000 0x20000>;
>   +  clocks = <&clks IMX5_CLK_OCRAM>;
>   };
> 
> Thanks

I think i.MX51 doesn't have that clock gate:

????????clk[IMX5_CLK_OCRAM]?????????????= imx_clk_gate2("ocram", "ahb", MXC_CCM_CCGR6, 2);

is added for i.MX53 only. CCGR6 CG1 (bits 3:2) is documented as
"no longer supported, should be cleared" in the i.MX51 reference
manual. I can't find any mention of a gate for the SCC RAM.

regards
Philipp

  reply	other threads:[~2018-06-22  9:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 14:24 [PATCH] ARM: dts: imx51: add CodaHx4 VPU Philipp Zabel
2017-12-26  4:15 ` Shawn Guo
2018-06-21 19:54   ` Philipp Zabel
2018-06-21 20:01     ` Fabio Estevam
2018-06-22  9:43       ` Philipp Zabel [this message]
2018-06-22 15:48         ` Fabio Estevam
2018-06-28  0:42 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529660586.2431.6.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).