From: hejianet@gmail.com (Jia He)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v10 6/6] mm: page_alloc: reduce unnecessary binary search in early_pfn_valid()
Date: Fri, 6 Jul 2018 17:01:15 +0800 [thread overview]
Message-ID: <1530867675-9018-7-git-send-email-hejianet@gmail.com> (raw)
In-Reply-To: <1530867675-9018-1-git-send-email-hejianet@gmail.com>
Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns
where possible") optimized the loop in memmap_init_zone(). But there is
still some room for improvement. E.g. in early_pfn_valid(), if pfn and
pfn+1 are in the same memblock region, we can record the last returned
memblock region index and check whether pfn++ is still in the same
region.
Currently it only improve the performance on arm/arm64 and will have no
impact on other arches.
For the performance improvement, after this set, I can see the time
overhead of memmap_init() is reduced from 27956us to 13537us in my
armv8a server(QDF2400 with 96G memory, pagesize 64k).
Signed-off-by: Jia He <jia.he@hxt-semitech.com>
---
include/linux/mmzone.h | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 57cdc42..83b1d11 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -1267,11 +1267,16 @@ static inline int pfn_present(unsigned long pfn)
#define pfn_to_nid(pfn) (0)
#endif
-#define early_pfn_valid(pfn) pfn_valid(pfn)
#ifdef CONFIG_HAVE_MEMBLOCK_PFN_VALID
extern ulong memblock_next_valid_pfn(ulong pfn);
#define next_valid_pfn(pfn) memblock_next_valid_pfn(pfn)
-#endif
+
+extern int pfn_valid_region(ulong pfn);
+#define early_pfn_valid(pfn) pfn_valid_region(pfn)
+#else
+#define early_pfn_valid(pfn) pfn_valid(pfn)
+#endif /*CONFIG_HAVE_ARCH_PFN_VALID*/
+
void sparse_init(void);
#else
#define sparse_init() do {} while (0)
--
1.8.3.1
next prev parent reply other threads:[~2018-07-06 9:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 9:01 [RESEND PATCH v10 0/6] optimize memblock_next_valid_pfn and early_pfn_valid on arm and arm64 Jia He
2018-07-06 9:01 ` [RESEND PATCH v10 1/6] arm: arm64: introduce CONFIG_HAVE_MEMBLOCK_PFN_VALID Jia He
2018-08-17 14:50 ` Catalin Marinas
2018-08-20 6:27 ` Jia He
2018-07-06 9:01 ` [RESEND PATCH v10 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64 Jia He
2018-07-06 22:37 ` Andrew Morton
2018-07-09 3:30 ` Jia He
2018-08-16 22:54 ` Pasha Tatashin
2018-07-06 9:01 ` [RESEND PATCH v10 3/6] mm: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn() Jia He
2018-08-17 1:08 ` Pasha Tatashin
2018-08-17 1:22 ` Pasha Tatashin
2018-08-21 6:14 ` Jia He
2018-08-21 21:08 ` Andrew Morton
2018-08-22 1:38 ` Jia He
2018-07-06 9:01 ` [RESEND PATCH v10 4/6] mm/memblock: introduce memblock_search_pfn_regions() Jia He
2018-07-06 9:01 ` [RESEND PATCH v10 5/6] mm/memblock: introduce pfn_valid_region() Jia He
2018-07-06 9:01 ` Jia He [this message]
2018-08-17 1:35 ` [RESEND PATCH v10 6/6] mm: page_alloc: reduce unnecessary binary search in early_pfn_valid() Pasha Tatashin
2018-08-17 1:38 ` Pavel Tatashin
2018-08-17 5:38 ` Jia He
2018-07-06 22:41 ` [RESEND PATCH v10 0/6] optimize memblock_next_valid_pfn and early_pfn_valid on arm and arm64 Andrew Morton
2018-08-15 22:34 ` Andrew Morton
2018-08-16 19:02 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530867675-9018-7-git-send-email-hejianet@gmail.com \
--to=hejianet@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).