* [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
2018-07-17 19:47 [PATCH/RFT 0/7] rsnd: add support for r8a77965 Yoshihiro Kaneko
@ 2018-07-17 19:47 ` Yoshihiro Kaneko
2018-07-18 9:05 ` Geert Uytterhoeven
2018-07-18 9:06 ` Geert Uytterhoeven
2018-07-17 19:47 ` [PATCH/RFT 2/7] ASoC: rsnd: Document R-Car M3-N support Yoshihiro Kaneko
` (6 subsequent siblings)
7 siblings, 2 replies; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-17 19:47 UTC (permalink / raw)
To: linux-arm-kernel
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC.
Based on a similar patch of the R8A7796 device tree
by uninori Morimoto <kuninori.morimoto.gx@renesas.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 68 +++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 0cd4446..c0dbabd 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1386,6 +1386,74 @@
status = "disabled";
};
+ audma0: dma-controller at ec700000 {
+ compatible = "renesas,dmac-r8a77965",
+ "renesas,rcar-dmac";
+ reg = <0 0xec700000 0 0x10000>;
+ interrupts = <GIC_SPI 350 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 321 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 322 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 323 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 325 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 326 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 328 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 334 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error",
+ "ch0", "ch1", "ch2", "ch3",
+ "ch4", "ch5", "ch6", "ch7",
+ "ch8", "ch9", "ch10", "ch11",
+ "ch12", "ch13", "ch14", "ch15";
+ clocks = <&cpg CPG_MOD 502>;
+ clock-names = "fck";
+ power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+ resets = <&cpg 502>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ };
+
+ audma1: dma-controller at ec720000 {
+ compatible = "renesas,dmac-r8a77965",
+ "renesas,rcar-dmac";
+ reg = <0 0xec720000 0 0x10000>;
+ interrupts = <GIC_SPI 351 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 343 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 344 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 346 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 347 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 348 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 349 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 382 IRQ_TYPE_LEVEL_HIGH
+ GIC_SPI 383 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "error",
+ "ch0", "ch1", "ch2", "ch3",
+ "ch4", "ch5", "ch6", "ch7",
+ "ch8", "ch9", "ch10", "ch11",
+ "ch12", "ch13", "ch14", "ch15";
+ clocks = <&cpg CPG_MOD 501>;
+ clock-names = "fck";
+ power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+ resets = <&cpg 501>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ };
+
ohci0: usb at ee080000 {
compatible = "generic-ohci";
reg = <0 0xee080000 0 0x100>;
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
2018-07-17 19:47 ` [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes Yoshihiro Kaneko
@ 2018-07-18 9:05 ` Geert Uytterhoeven
2018-07-18 9:06 ` Geert Uytterhoeven
1 sibling, 0 replies; 22+ messages in thread
From: Geert Uytterhoeven @ 2018-07-18 9:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kaneko-san,
On Tue, Jul 17, 2018 at 9:48 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC.
>
> Based on a similar patch of the R8A7796 device tree
> by uninori Morimoto <kuninori.morimoto.gx@renesas.com>.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1386,6 +1386,74 @@
> status = "disabled";
> };
>
> + audma0: dma-controller at ec700000 {
> + };
> +
Please respect sort order (by unit address, per device group).
The two audma nodes should be inserted just before usb at ee000000.
> ohci0: usb at ee080000 {
> compatible = "generic-ohci";
> reg = <0 0xee080000 0 0x100>;
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
2018-07-17 19:47 ` [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes Yoshihiro Kaneko
2018-07-18 9:05 ` Geert Uytterhoeven
@ 2018-07-18 9:06 ` Geert Uytterhoeven
2018-07-23 12:35 ` Yoshihiro Kaneko
1 sibling, 1 reply; 22+ messages in thread
From: Geert Uytterhoeven @ 2018-07-18 9:06 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 17, 2018 at 9:48 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC.
>
> Based on a similar patch of the R8A7796 device tree
> by uninori Morimoto <kuninori.morimoto.gx@renesas.com>.
Kuninori
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
2018-07-18 9:06 ` Geert Uytterhoeven
@ 2018-07-23 12:35 ` Yoshihiro Kaneko
0 siblings, 0 replies; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-23 12:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert-san,
Thank you for your review.
I will correct the sort order of the audma nodes and a typo of the commit log.
Best regards,
Kaneko
2018-07-18 18:06 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> On Tue, Jul 17, 2018 at 9:48 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
>> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>>
>> This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC.
>>
>> Based on a similar patch of the R8A7796 device tree
>> by uninori Morimoto <kuninori.morimoto.gx@renesas.com>.
>
> Kuninori
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH/RFT 2/7] ASoC: rsnd: Document R-Car M3-N support
2018-07-17 19:47 [PATCH/RFT 0/7] rsnd: add support for r8a77965 Yoshihiro Kaneko
2018-07-17 19:47 ` [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes Yoshihiro Kaneko
@ 2018-07-17 19:47 ` Yoshihiro Kaneko
2018-07-18 9:19 ` Geert Uytterhoeven
2018-07-19 23:12 ` Kuninori Morimoto
2018-07-17 19:47 ` [PATCH/RFT 3/7] arm64: dts: renesas: r8a77965: Add Sound device node and SSI support Yoshihiro Kaneko
` (5 subsequent siblings)
7 siblings, 2 replies; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-17 19:47 UTC (permalink / raw)
To: linux-arm-kernel
From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Document support for the sound modules in the Renesas M3-N (r8a77965)
SoC.
No driver update is needed.
Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
index b86d790..9e764270 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
@@ -352,6 +352,7 @@ Required properties:
- "renesas,rcar_sound-r8a7794" (R-Car E2)
- "renesas,rcar_sound-r8a7795" (R-Car H3)
- "renesas,rcar_sound-r8a7796" (R-Car M3-W)
+ - "renesas,rcar_sound-r8a77965" (R-Car M3-N)
- reg : Should contain the register physical address.
required register is
SRU/ADG/SSI if generation1
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH/RFT 2/7] ASoC: rsnd: Document R-Car M3-N support
2018-07-17 19:47 ` [PATCH/RFT 2/7] ASoC: rsnd: Document R-Car M3-N support Yoshihiro Kaneko
@ 2018-07-18 9:19 ` Geert Uytterhoeven
2018-07-19 23:12 ` Kuninori Morimoto
1 sibling, 0 replies; 22+ messages in thread
From: Geert Uytterhoeven @ 2018-07-18 9:19 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 17, 2018 at 9:48 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
>
> Document support for the sound modules in the Renesas M3-N (r8a77965)
> SoC.
>
> No driver update is needed.
>
> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH/RFT 2/7] ASoC: rsnd: Document R-Car M3-N support
2018-07-17 19:47 ` [PATCH/RFT 2/7] ASoC: rsnd: Document R-Car M3-N support Yoshihiro Kaneko
2018-07-18 9:19 ` Geert Uytterhoeven
@ 2018-07-19 23:12 ` Kuninori Morimoto
2018-07-23 12:39 ` Yoshihiro Kaneko
1 sibling, 1 reply; 22+ messages in thread
From: Kuninori Morimoto @ 2018-07-19 23:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi
Thnak you for your patch
> From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
>
> Document support for the sound modules in the Renesas M3-N (r8a77965)
> SoC.
>
> No driver update is needed.
>
> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
But, I think this patch should go to ALSA SoC ML.
> Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
> index b86d790..9e764270 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
> @@ -352,6 +352,7 @@ Required properties:
> - "renesas,rcar_sound-r8a7794" (R-Car E2)
> - "renesas,rcar_sound-r8a7795" (R-Car H3)
> - "renesas,rcar_sound-r8a7796" (R-Car M3-W)
> + - "renesas,rcar_sound-r8a77965" (R-Car M3-N)
> - reg : Should contain the register physical address.
> required register is
> SRU/ADG/SSI if generation1
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH/RFT 2/7] ASoC: rsnd: Document R-Car M3-N support
2018-07-19 23:12 ` Kuninori Morimoto
@ 2018-07-23 12:39 ` Yoshihiro Kaneko
0 siblings, 0 replies; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-23 12:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Morimoto-san,
Thank you for your review.
I will exclude this patch from the series and repost this as a single
patch to ALSA SoC ML.
Best regards,
Kaneko
2018-07-20 8:12 GMT+09:00 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>:
>
> Hi
>
> Thnak you for your patch
>
>> From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
>>
>> Document support for the sound modules in the Renesas M3-N (r8a77965)
>> SoC.
>>
>> No driver update is needed.
>>
>> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> But, I think this patch should go to ALSA SoC ML.
>
>
>> Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
>> index b86d790..9e764270 100644
>> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
>> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
>> @@ -352,6 +352,7 @@ Required properties:
>> - "renesas,rcar_sound-r8a7794" (R-Car E2)
>> - "renesas,rcar_sound-r8a7795" (R-Car H3)
>> - "renesas,rcar_sound-r8a7796" (R-Car M3-W)
>> + - "renesas,rcar_sound-r8a77965" (R-Car M3-N)
>> - reg : Should contain the register physical address.
>> required register is
>> SRU/ADG/SSI if generation1
>> --
>> 1.9.1
>>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH/RFT 3/7] arm64: dts: renesas: r8a77965: Add Sound device node and SSI support
2018-07-17 19:47 [PATCH/RFT 0/7] rsnd: add support for r8a77965 Yoshihiro Kaneko
2018-07-17 19:47 ` [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes Yoshihiro Kaneko
2018-07-17 19:47 ` [PATCH/RFT 2/7] ASoC: rsnd: Document R-Car M3-N support Yoshihiro Kaneko
@ 2018-07-17 19:47 ` Yoshihiro Kaneko
2018-07-19 23:23 ` Kuninori Morimoto
2018-07-17 19:48 ` [PATCH/RFT 4/7] arm64: dts: renesas: r8a77965: Add Sound SRC support Yoshihiro Kaneko
` (4 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-17 19:47 UTC (permalink / raw)
To: linux-arm-kernel
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Based on several similar patches of the R8A7796 device tree
by Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 109 +++++++++++++++++++++++-------
1 file changed, 85 insertions(+), 24 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index c0dbabd..c5d6ab4 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -12,7 +12,7 @@
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/power/r8a77965-sysc.h>
-#define CPG_AUDIO_CLK_I 10
+#define CPG_AUDIO_CLK_I R8A77965_CLK_S0D4
/ {
compatible = "renesas,r8a77965";
@@ -1324,42 +1324,103 @@
};
rcar_sound: sound at ec500000 {
+ /*
+ * #sound-dai-cells is required
+ *
+ * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
+ * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
+ */
+ /*
+ * #clock-cells is required for audio_clkout0/1/2/3
+ *
+ * clkout : #clock-cells = <0>; <&rcar_sound>;
+ * clkout0/1/2/3: #clock-cells = <1>; <&rcar_sound N>;
+ */
+ compatible = "renesas,rcar_sound-r8a7796", "renesas,rcar_sound-gen3";
reg = <0 0xec500000 0 0x1000>, /* SCU */
<0 0xec5a0000 0 0x100>, /* ADG */
<0 0xec540000 0 0x1000>, /* SSIU */
<0 0xec541000 0 0x280>, /* SSI */
<0 0xec740000 0 0x200>; /* Audio DMAC peri peri*/
- /* placeholder */
+ reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
+
+ clocks = <&cpg CPG_MOD 1005>,
+ <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>,
+ <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>,
+ <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
+ <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
+ <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+ <&audio_clk_a>, <&audio_clk_b>,
+ <&audio_clk_c>,
+ <&cpg CPG_CORE R8A77965_CLK_S0D4>;
+ clock-names = "ssi-all",
+ "ssi.9", "ssi.8", "ssi.7", "ssi.6",
+ "ssi.5", "ssi.4", "ssi.3", "ssi.2",
+ "ssi.1", "ssi.0",
+ "clk_a", "clk_b", "clk_c", "clk_i";
+ power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+ resets = <&cpg 1005>,
+ <&cpg 1006>, <&cpg 1007>,
+ <&cpg 1008>, <&cpg 1009>,
+ <&cpg 1010>, <&cpg 1011>,
+ <&cpg 1012>, <&cpg 1013>,
+ <&cpg 1014>, <&cpg 1015>;
+ reset-names = "ssi-all",
+ "ssi.9", "ssi.8", "ssi.7", "ssi.6",
+ "ssi.5", "ssi.4", "ssi.3", "ssi.2",
+ "ssi.1", "ssi.0";
+ status = "disabled";
- rcar_sound,dvc {
- dvc0: dvc-0 {
+ rcar_sound,ssi {
+ ssi0: ssi-0 {
+ interrupts = <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x01>, <&audma1 0x02>, <&audma0 0x15>, <&audma1 0x16>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
- dvc1: dvc-1 {
+ ssi1: ssi-1 {
+ interrupts = <GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x03>, <&audma1 0x04>, <&audma0 0x49>, <&audma1 0x4a>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
- };
-
- rcar_sound,src {
- src0: src-0 {
+ ssi2: ssi-2 {
+ interrupts = <GIC_SPI 372 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x05>, <&audma1 0x06>, <&audma0 0x63>, <&audma1 0x64>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
- src1: src-1 {
+ ssi3: ssi-3 {
+ interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x07>, <&audma1 0x08>, <&audma0 0x6f>, <&audma1 0x70>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
- };
-
- rcar_sound,ssi {
- ssi0: ssi-0 {
+ ssi4: ssi-4 {
+ interrupts = <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x09>, <&audma1 0x0a>, <&audma0 0x71>, <&audma1 0x72>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
- ssi1: ssi-1 {
+ ssi5: ssi-5 {
+ interrupts = <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x0b>, <&audma1 0x0c>, <&audma0 0x73>, <&audma1 0x74>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
- };
-
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- port at 0 {
- reg = <0>;
+ ssi6: ssi-6 {
+ interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x0d>, <&audma1 0x0e>, <&audma0 0x75>, <&audma1 0x76>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
- port at 1 {
- reg = <1>;
+ ssi7: ssi-7 {
+ interrupts = <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x0f>, <&audma1 0x10>, <&audma0 0x79>, <&audma1 0x7a>;
+ dma-names = "rx", "tx", "rxu", "txu";
+ };
+ ssi8: ssi-8 {
+ interrupts = <GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x11>, <&audma1 0x12>, <&audma0 0x7b>, <&audma1 0x7c>;
+ dma-names = "rx", "tx", "rxu", "txu";
+ };
+ ssi9: ssi-9 {
+ interrupts = <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x13>, <&audma1 0x14>, <&audma0 0x7d>, <&audma1 0x7e>;
+ dma-names = "rx", "tx", "rxu", "txu";
};
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH/RFT 3/7] arm64: dts: renesas: r8a77965: Add Sound device node and SSI support
2018-07-17 19:47 ` [PATCH/RFT 3/7] arm64: dts: renesas: r8a77965: Add Sound device node and SSI support Yoshihiro Kaneko
@ 2018-07-19 23:23 ` Kuninori Morimoto
2018-07-23 12:43 ` Yoshihiro Kaneko
0 siblings, 1 reply; 22+ messages in thread
From: Kuninori Morimoto @ 2018-07-19 23:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> Based on several similar patches of the R8A7796 device tree
> by Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
(snip)
> rcar_sound: sound at ec500000 {
> + /*
> + * #sound-dai-cells is required
> + *
> + * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
> + * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
> + */
> + /*
> + * #clock-cells is required for audio_clkout0/1/2/3
> + *
> + * clkout : #clock-cells = <0>; <&rcar_sound>;
> + * clkout0/1/2/3: #clock-cells = <1>; <&rcar_sound N>;
> + */
> + compatible = "renesas,rcar_sound-r8a7796", "renesas,rcar_sound-gen3";
77965 ?
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH/RFT 3/7] arm64: dts: renesas: r8a77965: Add Sound device node and SSI support
2018-07-19 23:23 ` Kuninori Morimoto
@ 2018-07-23 12:43 ` Yoshihiro Kaneko
0 siblings, 0 replies; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-23 12:43 UTC (permalink / raw)
To: linux-arm-kernel
Hi Morimoto-san,
Thank you for your review.
2018-07-20 8:23 GMT+09:00 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>:
>
> Hi
>
>> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>>
>> Based on several similar patches of the R8A7796 device tree
>> by Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>.
>>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
> (snip)
>> rcar_sound: sound at ec500000 {
>> + /*
>> + * #sound-dai-cells is required
>> + *
>> + * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
>> + * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
>> + */
>> + /*
>> + * #clock-cells is required for audio_clkout0/1/2/3
>> + *
>> + * clkout : #clock-cells = <0>; <&rcar_sound>;
>> + * clkout0/1/2/3: #clock-cells = <1>; <&rcar_sound N>;
>> + */
>> + compatible = "renesas,rcar_sound-r8a7796", "renesas,rcar_sound-gen3";
>
> 77965 ?
Will fix.
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Best regards,
Kaneko
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH/RFT 4/7] arm64: dts: renesas: r8a77965: Add Sound SRC support
2018-07-17 19:47 [PATCH/RFT 0/7] rsnd: add support for r8a77965 Yoshihiro Kaneko
` (2 preceding siblings ...)
2018-07-17 19:47 ` [PATCH/RFT 3/7] arm64: dts: renesas: r8a77965: Add Sound device node and SSI support Yoshihiro Kaneko
@ 2018-07-17 19:48 ` Yoshihiro Kaneko
2018-07-19 23:24 ` Kuninori Morimoto
2018-07-17 19:48 ` [PATCH/RFT 5/7] arm64: dts: renesas: r8a77965: Add Sound DVC device nodes Yoshihiro Kaneko
` (3 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-17 19:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Based on a similar patch of the R8A7796 device tree
by Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 61 +++++++++++++++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index c5d6ab4..91cb50f 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1350,6 +1350,11 @@
<&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
<&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
<&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+ <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>,
+ <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>,
+ <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
+ <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
+ <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
<&audio_clk_a>, <&audio_clk_b>,
<&audio_clk_c>,
<&cpg CPG_CORE R8A77965_CLK_S0D4>;
@@ -1357,6 +1362,9 @@
"ssi.9", "ssi.8", "ssi.7", "ssi.6",
"ssi.5", "ssi.4", "ssi.3", "ssi.2",
"ssi.1", "ssi.0",
+ "src.9", "src.8", "src.7", "src.6",
+ "src.5", "src.4", "src.3", "src.2",
+ "src.1", "src.0",
"clk_a", "clk_b", "clk_c", "clk_i";
power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
resets = <&cpg 1005>,
@@ -1371,6 +1379,59 @@
"ssi.1", "ssi.0";
status = "disabled";
+ rcar_sound,src {
+ src0: src-0 {
+ interrupts = <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x85>, <&audma1 0x9a>;
+ dma-names = "rx", "tx";
+ };
+ src1: src-1 {
+ interrupts = <GIC_SPI 353 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x87>, <&audma1 0x9c>;
+ dma-names = "rx", "tx";
+ };
+ src2: src-2 {
+ interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x89>, <&audma1 0x9e>;
+ dma-names = "rx", "tx";
+ };
+ src3: src-3 {
+ interrupts = <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x8b>, <&audma1 0xa0>;
+ dma-names = "rx", "tx";
+ };
+ src4: src-4 {
+ interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x8d>, <&audma1 0xb0>;
+ dma-names = "rx", "tx";
+ };
+ src5: src-5 {
+ interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x8f>, <&audma1 0xb2>;
+ dma-names = "rx", "tx";
+ };
+ src6: src-6 {
+ interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x91>, <&audma1 0xb4>;
+ dma-names = "rx", "tx";
+ };
+ src7: src-7 {
+ interrupts = <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x93>, <&audma1 0xb6>;
+ dma-names = "rx", "tx";
+ };
+ src8: src-8 {
+ interrupts = <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x95>, <&audma1 0xb8>;
+ dma-names = "rx", "tx";
+ };
+ src9: src-9 {
+ interrupts = <GIC_SPI 361 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x97>, <&audma1 0xba>;
+ dma-names = "rx", "tx";
+ };
+ };
+
rcar_sound,ssi {
ssi0: ssi-0 {
interrupts = <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>;
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH/RFT 5/7] arm64: dts: renesas: r8a77965: Add Sound DVC device nodes
2018-07-17 19:47 [PATCH/RFT 0/7] rsnd: add support for r8a77965 Yoshihiro Kaneko
` (3 preceding siblings ...)
2018-07-17 19:48 ` [PATCH/RFT 4/7] arm64: dts: renesas: r8a77965: Add Sound SRC support Yoshihiro Kaneko
@ 2018-07-17 19:48 ` Yoshihiro Kaneko
2018-07-19 23:26 ` Kuninori Morimoto
2018-07-17 19:48 ` [PATCH/RFT 6/7] arm64: dts: renesas: r8a77965: Add Sound CTU support Yoshihiro Kaneko
` (2 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-17 19:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Based on a similar patch of the R8A7796 device tree
by Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 91cb50f..61140e1 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1355,6 +1355,7 @@
<&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
<&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
<&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+ <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
<&audio_clk_a>, <&audio_clk_b>,
<&audio_clk_c>,
<&cpg CPG_CORE R8A77965_CLK_S0D4>;
@@ -1365,6 +1366,7 @@
"src.9", "src.8", "src.7", "src.6",
"src.5", "src.4", "src.3", "src.2",
"src.1", "src.0",
+ "dvc.0", "dvc.1",
"clk_a", "clk_b", "clk_c", "clk_i";
power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
resets = <&cpg 1005>,
@@ -1379,6 +1381,17 @@
"ssi.1", "ssi.0";
status = "disabled";
+ rcar_sound,dvc {
+ dvc0: dvc-0 {
+ dmas = <&audma1 0xbc>;
+ dma-names = "tx";
+ };
+ dvc1: dvc-1 {
+ dmas = <&audma1 0xbe>;
+ dma-names = "tx";
+ };
+ };
+
rcar_sound,src {
src0: src-0 {
interrupts = <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH/RFT 6/7] arm64: dts: renesas: r8a77965: Add Sound CTU support
2018-07-17 19:47 [PATCH/RFT 0/7] rsnd: add support for r8a77965 Yoshihiro Kaneko
` (4 preceding siblings ...)
2018-07-17 19:48 ` [PATCH/RFT 5/7] arm64: dts: renesas: r8a77965: Add Sound DVC device nodes Yoshihiro Kaneko
@ 2018-07-17 19:48 ` Yoshihiro Kaneko
2018-07-19 23:29 ` Kuninori Morimoto
2018-07-17 19:48 ` [PATCH/RFT 7/7] arm64: dts: renesas: r8a77965: Add Sound MIX support Yoshihiro Kaneko
2018-07-23 16:21 ` [PATCH/RFT 0/7] rsnd: add support for r8a77965 Simon Horman
7 siblings, 1 reply; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-17 19:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Based on a similar patch of the R8A7796 device tree
by Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 61140e1..2188ad2 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1355,6 +1355,7 @@
<&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
<&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
<&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+ <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
<&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
<&audio_clk_a>, <&audio_clk_b>,
<&audio_clk_c>,
@@ -1366,6 +1367,7 @@
"src.9", "src.8", "src.7", "src.6",
"src.5", "src.4", "src.3", "src.2",
"src.1", "src.0",
+ "ctu.1", "ctu.0",
"dvc.0", "dvc.1",
"clk_a", "clk_b", "clk_c", "clk_i";
power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
@@ -1392,6 +1394,17 @@
};
};
+ rcar_sound,ctu {
+ ctu00: ctu-0 { };
+ ctu01: ctu-1 { };
+ ctu02: ctu-2 { };
+ ctu03: ctu-3 { };
+ ctu10: ctu-4 { };
+ ctu11: ctu-5 { };
+ ctu12: ctu-6 { };
+ ctu13: ctu-7 { };
+ };
+
rcar_sound,src {
src0: src-0 {
interrupts = <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH/RFT 7/7] arm64: dts: renesas: r8a77965: Add Sound MIX support
2018-07-17 19:47 [PATCH/RFT 0/7] rsnd: add support for r8a77965 Yoshihiro Kaneko
` (5 preceding siblings ...)
2018-07-17 19:48 ` [PATCH/RFT 6/7] arm64: dts: renesas: r8a77965: Add Sound CTU support Yoshihiro Kaneko
@ 2018-07-17 19:48 ` Yoshihiro Kaneko
2018-07-19 23:30 ` Kuninori Morimoto
2018-07-23 16:21 ` [PATCH/RFT 0/7] rsnd: add support for r8a77965 Simon Horman
7 siblings, 1 reply; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-17 19:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Based on a similar patch of the R8A7796 device tree
by Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 2188ad2..56303ac 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1356,6 +1356,7 @@
<&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
<&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
<&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
+ <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
<&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
<&audio_clk_a>, <&audio_clk_b>,
<&audio_clk_c>,
@@ -1367,6 +1368,7 @@
"src.9", "src.8", "src.7", "src.6",
"src.5", "src.4", "src.3", "src.2",
"src.1", "src.0",
+ "mix.1", "mix.0",
"ctu.1", "ctu.0",
"dvc.0", "dvc.1",
"clk_a", "clk_b", "clk_c", "clk_i";
@@ -1394,6 +1396,11 @@
};
};
+ rcar_sound,mix {
+ mix0: mix-0 { };
+ mix1: mix-1 { };
+ };
+
rcar_sound,ctu {
ctu00: ctu-0 { };
ctu01: ctu-1 { };
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH/RFT 0/7] rsnd: add support for r8a77965
2018-07-17 19:47 [PATCH/RFT 0/7] rsnd: add support for r8a77965 Yoshihiro Kaneko
` (6 preceding siblings ...)
2018-07-17 19:48 ` [PATCH/RFT 7/7] arm64: dts: renesas: r8a77965: Add Sound MIX support Yoshihiro Kaneko
@ 2018-07-23 16:21 ` Simon Horman
2018-07-24 14:00 ` Yoshihiro Kaneko
7 siblings, 1 reply; 22+ messages in thread
From: Simon Horman @ 2018-07-23 16:21 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 18, 2018 at 04:47:56AM +0900, Yoshihiro Kaneko wrote:
> This series adds sound support for r8a77965 (R-Car M3-N).
> This series is based on the devel branch of Simon Horman's renesas tree.
>
> Hiroyuki Yokoyama (1):
> ASoC: rsnd: Document R-Car M3-N support
>
> Takeshi Kihara (6):
> arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
> arm64: dts: renesas: r8a77965: Add Sound device node and SSI support
> arm64: dts: renesas: r8a77965: Add Sound SRC support
> arm64: dts: renesas: r8a77965: Add Sound DVC device nodes
> arm64: dts: renesas: r8a77965: Add Sound CTU support
> arm64: dts: renesas: r8a77965: Add Sound MIX support
>
> .../devicetree/bindings/sound/renesas,rsnd.txt | 1 +
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 245 ++++++++++++++++++++-
Thanks Kaneko-san,
in general this series looks good, however, I would like to ask you to
squash all the dts patches (the patches by Kihara-san) into a single patch.
For many years now we have split patches up as this series does.
And no doubt that is why BPS team chose to split up the patches
that you have based this patchset on. However, we were recently
asked by the Olof Johansson to squash patches together to make
the high-level intent of patches clearer to him in his position
of ARM-SoC co-maintainer.
So while what you have done is correct, it is now the "old way".
Please squash the patches together as this is the "new way".
Thanks!
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH/RFT 0/7] rsnd: add support for r8a77965
2018-07-23 16:21 ` [PATCH/RFT 0/7] rsnd: add support for r8a77965 Simon Horman
@ 2018-07-24 14:00 ` Yoshihiro Kaneko
0 siblings, 0 replies; 22+ messages in thread
From: Yoshihiro Kaneko @ 2018-07-24 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon-san,
2018-07-24 1:21 GMT+09:00 Simon Horman <horms@verge.net.au>:
> On Wed, Jul 18, 2018 at 04:47:56AM +0900, Yoshihiro Kaneko wrote:
>> This series adds sound support for r8a77965 (R-Car M3-N).
>> This series is based on the devel branch of Simon Horman's renesas tree.
>>
>> Hiroyuki Yokoyama (1):
>> ASoC: rsnd: Document R-Car M3-N support
>>
>> Takeshi Kihara (6):
>> arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
>> arm64: dts: renesas: r8a77965: Add Sound device node and SSI support
>> arm64: dts: renesas: r8a77965: Add Sound SRC support
>> arm64: dts: renesas: r8a77965: Add Sound DVC device nodes
>> arm64: dts: renesas: r8a77965: Add Sound CTU support
>> arm64: dts: renesas: r8a77965: Add Sound MIX support
>>
>> .../devicetree/bindings/sound/renesas,rsnd.txt | 1 +
>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 245 ++++++++++++++++++++-
>
> Thanks Kaneko-san,
>
> in general this series looks good, however, I would like to ask you to
> squash all the dts patches (the patches by Kihara-san) into a single patch.
>
> For many years now we have split patches up as this series does.
> And no doubt that is why BPS team chose to split up the patches
> that you have based this patchset on. However, we were recently
> asked by the Olof Johansson to squash patches together to make
> the high-level intent of patches clearer to him in his position
> of ARM-SoC co-maintainer.
>
> So while what you have done is correct, it is now the "old way".
> Please squash the patches together as this is the "new way".
Thank you for the detailed explanation.
I will do it.
>
> Thanks!
Best regards,
Kaneko
^ permalink raw reply [flat|nested] 22+ messages in thread