From: sean.wang@mediatek.com (Sean Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [resend PATCH v4 5/5] drm: mediatek: Omit warning on probe defers
Date: Wed, 18 Jul 2018 11:04:17 +0800 [thread overview]
Message-ID: <1531883057.8953.87.camel@mtkswgap22> (raw)
In-Reply-To: <20180717220328.792-6-matthias.bgg@kernel.org>
On Wed, 2018-07-18 at 00:03 +0200, matthias.bgg at kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> It can happen that the clock drivers wasn't probed before the
> ddp driver gets invoked. The driver used to omit a warning
> that the driver failed to get the clocks. Omit this error on
> the defered probe path.
>
so if we list drm device as a child device of mmsys we don't need the
patch, and that make more sense.
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Acked-by: CK Hu <ck.hu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index bafc5c77c4fb..6b399348a2dc 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -374,7 +374,8 @@ static int mtk_ddp_probe(struct platform_device *pdev)
>
> ddp->clk = devm_clk_get(dev, NULL);
> if (IS_ERR(ddp->clk)) {
> - dev_err(dev, "Failed to get clock\n");
> + if (PTR_ERR(ddp->clk) != -EPROBE_DEFER)
> + dev_err(dev, "Failed to get clock\n");
> return PTR_ERR(ddp->clk);
> }
>
prev parent reply other threads:[~2018-07-18 3:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 22:03 [resend PATCH v4 0/5] arm/arm64: mediatek: Fix mmsys device probing matthias.bgg at kernel.org
2018-07-17 22:03 ` [resend PATCH v4 1/5] drm/mediatek: Use regmap for register access matthias.bgg at kernel.org
2018-07-17 22:03 ` [resend PATCH v4 2/5] clk: mediatek: mt2701-mmsys: switch to platform device probing matthias.bgg at kernel.org
2018-07-17 22:03 ` [resend PATCH v4 3/5] clk: mediatek: mt8173: switch mmsys " matthias.bgg at kernel.org
2018-07-17 22:03 ` [resend PATCH v4 4/5] drm/mediatek: Add support for mmsys through a pdev matthias.bgg at kernel.org
2018-07-18 2:57 ` Sean Wang
2018-07-18 7:27 ` Matthias Brugger
2018-07-18 7:28 ` Matthias Brugger
2018-07-18 9:16 ` Sean Wang
2018-07-18 8:05 ` Laurent Pinchart
2018-07-18 10:06 ` Sean Wang
2018-07-26 7:35 ` Stephen Boyd
2018-10-12 18:23 ` Stephen Boyd
2018-07-17 22:03 ` [resend PATCH v4 5/5] drm: mediatek: Omit warning on probe defers matthias.bgg at kernel.org
2018-07-18 3:04 ` Sean Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531883057.8953.87.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox