From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.zabel@pengutronix.de (Philipp Zabel) Date: Tue, 24 Jul 2018 09:51:22 +0200 Subject: [PATCH 06/10] drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic In-Reply-To: <1532418551.4078.3.camel@pengutronix.de> References: <20180713161407.GQ20303@art_vandelay> <20180720211509.23605-1-alexandru-cosmin.gheorghe@arm.com> <20180720211509.23605-7-alexandru-cosmin.gheorghe@arm.com> <1532418551.4078.3.camel@pengutronix.de> Message-ID: <1532418682.4078.5.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2018-07-24 at 09:49 +0200, Philipp Zabel wrote: > Hi Alexandru, > > On Fri, 2018-07-20 at 22:15 +0100, Alexandru Gheorghe wrote: > > Signed-off-by: Alexandru Gheorghe > > --- > > drivers/gpu/drm/imx/ipuv3-plane.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c > > index 203f247d4854..1bd4de03ce9e 100644 > > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > > @@ -281,16 +281,14 @@ static void ipu_plane_state_reset(struct drm_plane *plane) > > ipu_state = to_ipu_plane_state(plane->state); > > __drm_atomic_helper_plane_destroy_state(plane->state); > > kfree(ipu_state); > > + plane->state = NULL; > > With __drm_atomic_helper_plane_reset as-is, this could be dropped ... > > > } > > > > ipu_state = kzalloc(sizeof(*ipu_state), GFP_KERNEL); > > > > - if (ipu_state) { > > - ipu_state->base.plane = plane; > > - ipu_state->base.rotation = DRM_MODE_ROTATE_0; > > - } > > + if (ipu_state) > > + __drm_atomic_helper_plane_reset(plane, &ipu_state->base); > > ... if this is change to just > > __drm_atomic_helper_plane_reset(plane, &ipu_state->base); Euh, obviously that won't be possible, sorry for the noise. I blame the heat. regards Philipp