linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"
Date: Tue, 24 Jul 2018 18:52:32 +0200	[thread overview]
Message-ID: <1532451152.32306.8.camel@pengutronix.de> (raw)
In-Reply-To: <ed0ceaa10da805bc79e85ec7d60fcce9d4327066.1532448745.git.leonard.crestez@nxp.com>

Am Dienstag, den 24.07.2018, 19:14 +0300 schrieb Leonard Crestez:
> This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d.
> 
> That commit followed the reference manual but unfortunately the imx7d
> manual is incorrect.
> 
> Tested with ath9k pcie card and confirmed internally.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

Acked-by: Lucas Stach <l.stach@pengutronix.de>

> ---
> ?arch/arm/boot/dts/imx7d.dtsi | 12 ++++++++----
> ?1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 7cbc2ffa4b3a..7234e8330a57 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -124,14 +124,18 @@
> > ?		num-lanes = <1>;
> > ?		interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>;
> > ?		interrupt-names = "msi";
> > ?		#interrupt-cells = <1>;
> > ?		interrupt-map-mask = <0 0 0 0x7>;
> > -		interrupt-map = <0 0 0 1 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> > -				<0 0 0 2 &intc GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> > -				<0 0 0 3 &intc GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
> > -				<0 0 0 4 &intc GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
> > +		/*
> > +		?* Reference manual lists pci irqs incorrectly
> > +		?* Real hardware ordering is same as imx6: D+MSI, C, B, A
> > +		?*/
> > +		interrupt-map = <0 0 0 1 &intc GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
> > +				<0 0 0 2 &intc GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
> > +				<0 0 0 3 &intc GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> > +				<0 0 0 4 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>;
> > ?		clocks = <&clks IMX7D_PCIE_CTRL_ROOT_CLK>,
> > ?			?<&clks IMX7D_PLL_ENET_MAIN_100M_CLK>,
> > ?			?<&clks IMX7D_PCIE_PHY_ROOT_CLK>;
> > ?		clock-names = "pcie", "pcie_bus", "pcie_phy";
> > ?		assigned-clocks = <&clks IMX7D_PCIE_CTRL_ROOT_SRC>,

  reply	other threads:[~2018-07-24 16:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 16:14 [PATCH v3 0/2] PCI: imx: Initial imx7d pm support Leonard Crestez
2018-07-24 16:14 ` [PATCH v3 1/2] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" Leonard Crestez
2018-07-24 16:52   ` Lucas Stach [this message]
2018-08-21 15:31   ` Shawn Guo
2018-07-24 16:14 ` [PATCH v3 2/2] PCI: imx: Initial imx7d pm support Leonard Crestez
2018-07-24 16:55   ` Lucas Stach
2018-08-08 10:53 ` [PATCH v3 0/2] " Leonard Crestez
2018-08-08 11:14   ` Lorenzo Pieralisi
2018-08-08 11:37     ` Leonard Crestez
2018-08-08 14:19       ` Lorenzo Pieralisi
2018-08-08 14:58         ` Leonard Crestez
2018-08-08 15:27           ` Lorenzo Pieralisi
2018-08-10 11:11             ` Leonard Crestez
2018-08-10 15:13               ` Lorenzo Pieralisi
2018-08-21 15:26                 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532451152.32306.8.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).