From: ada@thorsis.com (Alexander Dahl)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] memory: atmel-ebi: Simplify SMC config code
Date: Tue, 25 Jul 2017 13:43:12 +0200 [thread overview]
Message-ID: <1532488.qfy0e7fcKK@ada> (raw)
In-Reply-To: <20170724212109.586e3512@bbrezillon>
Hello Boris,
Am Montag, 24. Juli 2017, 21:21:09 schrieb Boris Brezillon:
> There is a good reason for this "- 1": the doc says the exact number
> of tDF cycles is TDF_CYCLES + 1. When you are expressing timings in
> ns it does matter, because you don't want to wait more than
> necessary. Say the master clk period is X ns and you want a tDF of X
> ns. If you divide tDF_ns by the clk period you get one, and you only
> want to wait 1 cycle, not two.
This makes sense. I tried several values through the same algorithm with
a small test program and it gives the expected results. Thanks for the
explanation. :-)
> The NAND driver seems to do the right thing already [1].
>
> Below is my suggestion below to fix the problem. Did you have
> something else in mind? In any case, can you send a patch to fix it
> (either using my suggestion or something else if you prefer).
I prepared a small patch series together with two other small fixes for
the atmel ebi driver and will send it to the list in a minute.
Greets
Alex
next prev parent reply other threads:[~2017-07-25 11:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 16:54 [PATCH 0/7] memory: atmel-ebi: Add PM ops Boris Brezillon
2017-02-20 16:54 ` [PATCH 1/7] mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation Boris Brezillon
2017-03-14 17:00 ` Lee Jones
2017-03-14 17:21 ` Boris Brezillon
2017-03-15 12:19 ` Lee Jones
2017-03-15 13:21 ` Boris Brezillon
2017-02-20 16:54 ` [PATCH 2/7] memory: atmel-ebi: Simplify SMC config code Boris Brezillon
2017-03-02 12:02 ` Alexander Dahl
2017-03-02 12:30 ` Boris Brezillon
2017-07-24 9:12 ` Alexander Dahl
2017-07-24 19:21 ` Boris Brezillon
2017-07-25 11:43 ` Alexander Dahl [this message]
2017-02-20 16:54 ` [PATCH 3/7] memory: atmel-ebi: Stop using reg_field objects for simple things Boris Brezillon
2017-02-20 16:54 ` [PATCH 4/7] mfd: syscon: atmel-smc: Remove unused helpers/macros Boris Brezillon
2017-02-20 16:54 ` [PATCH 5/7] memory: atmel-ebi: Change naming scheme Boris Brezillon
2017-02-20 16:55 ` [PATCH 6/7] memory: atmel-ebi: Add missing ->numcs assignment Boris Brezillon
2017-02-20 16:55 ` [PATCH 7/7] memory: atmel-ebi: Add PM ops Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532488.qfy0e7fcKK@ada \
--to=ada@thorsis.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).