linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/mediatek: Convert drm_atomic_helper_suspend/resume()
Date: Mon, 30 Jul 2018 11:53:06 +0800	[thread overview]
Message-ID: <1532922786.3723.1.camel@mtksdaap41> (raw)
In-Reply-To: <20180728133845.GA15261@jordon-HP-15-Notebook-PC>

Hi, Souptick:

On Sat, 2018-07-28 at 19:08 +0530, Souptick Joarder wrote:
> convert drm_atomic_helper_suspend/resume() to use
> drm_mode_config_helper_suspend/resume().
> 

Reviewed-by: CK Hu <ck.hu@mediatek.com>

> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Signed-off-by: Ajit Negi <ajitn.linux@gmail.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index a2ca90f..1fcda2de 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -520,29 +520,24 @@ static int mtk_drm_sys_suspend(struct device *dev)
>  {
>  	struct mtk_drm_private *private = dev_get_drvdata(dev);
>  	struct drm_device *drm = private->drm;
> +	int ret;
>  
> -	drm_kms_helper_poll_disable(drm);
> -
> -	private->suspend_state = drm_atomic_helper_suspend(drm);
> -	if (IS_ERR(private->suspend_state)) {
> -		drm_kms_helper_poll_enable(drm);
> -		return PTR_ERR(private->suspend_state);
> -	}
> -
> +	ret = drm_mode_config_helper_suspend(drm);
>  	DRM_DEBUG_DRIVER("mtk_drm_sys_suspend\n");
> -	return 0;
> +
> +	return ret;
>  }
>  
>  static int mtk_drm_sys_resume(struct device *dev)
>  {
>  	struct mtk_drm_private *private = dev_get_drvdata(dev);
>  	struct drm_device *drm = private->drm;
> +	int ret;
>  
> -	drm_atomic_helper_resume(drm, private->suspend_state);
> -	drm_kms_helper_poll_enable(drm);
> -
> +	ret = drm_mode_config_helper_resume(drm);
>  	DRM_DEBUG_DRIVER("mtk_drm_sys_resume\n");
> -	return 0;
> +
> +	return ret;
>  }
>  #endif
>  

  reply	other threads:[~2018-07-30  3:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-28 13:38 [PATCH] drm/mediatek: Convert drm_atomic_helper_suspend/resume() Souptick Joarder
2018-07-30  3:53 ` CK Hu [this message]
2018-07-30  4:51   ` Souptick Joarder
2018-07-30  7:29     ` [SPAM]Re: " CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532922786.3723.1.camel@mtksdaap41 \
    --to=ck.hu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).