From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [SPAM]Re: [PATCH] drm/mediatek: Convert drm_atomic_helper_suspend/resume()
Date: Mon, 30 Jul 2018 15:29:30 +0800 [thread overview]
Message-ID: <1532935770.22708.2.camel@mtksdaap41> (raw)
In-Reply-To: <CAFqt6zbbVMagJeM53g79RoeYt7edmAZiF8r0_HpyxnS9123vQg@mail.gmail.com>
Hi, Souptick:
On Mon, 2018-07-30 at 10:21 +0530, Souptick Joarder wrote:
> On Mon, Jul 30, 2018 at 9:23 AM, CK Hu <ck.hu@mediatek.com> wrote:
> > Hi, Souptick:
> >
> > On Sat, 2018-07-28 at 19:08 +0530, Souptick Joarder wrote:
> >> convert drm_atomic_helper_suspend/resume() to use
> >> drm_mode_config_helper_suspend/resume().
> >>
> >
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Thank CK, can we get this patch in queue for 4.19 ?
>
Applied to mediatek-drm-fixes-4.19 [1].
[1]
https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-4.19
Regards,
CK
> >
> >> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >> Signed-off-by: Ajit Negi <ajitn.linux@gmail.com>
> >> ---
> >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 21 ++++++++-------------
> >> 1 file changed, 8 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> >> index a2ca90f..1fcda2de 100644
> >> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> >> @@ -520,29 +520,24 @@ static int mtk_drm_sys_suspend(struct device *dev)
> >> {
> >> struct mtk_drm_private *private = dev_get_drvdata(dev);
> >> struct drm_device *drm = private->drm;
> >> + int ret;
> >>
> >> - drm_kms_helper_poll_disable(drm);
> >> -
> >> - private->suspend_state = drm_atomic_helper_suspend(drm);
> >> - if (IS_ERR(private->suspend_state)) {
> >> - drm_kms_helper_poll_enable(drm);
> >> - return PTR_ERR(private->suspend_state);
> >> - }
> >> -
> >> + ret = drm_mode_config_helper_suspend(drm);
> >> DRM_DEBUG_DRIVER("mtk_drm_sys_suspend\n");
> >> - return 0;
> >> +
> >> + return ret;
> >> }
> >>
> >> static int mtk_drm_sys_resume(struct device *dev)
> >> {
> >> struct mtk_drm_private *private = dev_get_drvdata(dev);
> >> struct drm_device *drm = private->drm;
> >> + int ret;
> >>
> >> - drm_atomic_helper_resume(drm, private->suspend_state);
> >> - drm_kms_helper_poll_enable(drm);
> >> -
> >> + ret = drm_mode_config_helper_resume(drm);
> >> DRM_DEBUG_DRIVER("mtk_drm_sys_resume\n");
> >> - return 0;
> >> +
> >> + return ret;
> >> }
> >> #endif
> >>
> >
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2018-07-30 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 13:38 [PATCH] drm/mediatek: Convert drm_atomic_helper_suspend/resume() Souptick Joarder
2018-07-30 3:53 ` CK Hu
2018-07-30 4:51 ` Souptick Joarder
2018-07-30 7:29 ` CK Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532935770.22708.2.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).