* [PATCH] soc: mediatek: pwrap: use true and false for boolean values
@ 2018-08-05 1:02 Gustavo A. R. Silva
2018-08-08 7:35 ` Sean Wang
2018-09-25 14:36 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-05 1:02 UTC (permalink / raw)
To: linux-arm-kernel
Return statements in functions returning bool should use true or false
instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 4e931fd..932470a 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1096,7 +1096,7 @@ static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY],
&rdata);
if (ret)
- return 0;
+ return false;
return rdata == 1;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] soc: mediatek: pwrap: use true and false for boolean values
2018-08-05 1:02 [PATCH] soc: mediatek: pwrap: use true and false for boolean values Gustavo A. R. Silva
@ 2018-08-08 7:35 ` Sean Wang
2018-09-25 14:36 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Sean Wang @ 2018-08-08 7:35 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 2018-08-04 at 20:02 -0500, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 4e931fd..932470a 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1096,7 +1096,7 @@ static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
> ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY],
> &rdata);
> if (ret)
> - return 0;
> + return false;
>
Acked-by: Sean Wang <sean.wang@mediatek.com>
> return rdata == 1;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] soc: mediatek: pwrap: use true and false for boolean values
2018-08-05 1:02 [PATCH] soc: mediatek: pwrap: use true and false for boolean values Gustavo A. R. Silva
2018-08-08 7:35 ` Sean Wang
@ 2018-09-25 14:36 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2018-09-25 14:36 UTC (permalink / raw)
To: linux-arm-kernel
On 05/08/2018 03:02, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
Applied, thanks!
Matthias
> drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 4e931fd..932470a 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1096,7 +1096,7 @@ static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp)
> ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY],
> &rdata);
> if (ret)
> - return 0;
> + return false;
>
> return rdata == 1;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-25 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-05 1:02 [PATCH] soc: mediatek: pwrap: use true and false for boolean values Gustavo A. R. Silva
2018-08-08 7:35 ` Sean Wang
2018-09-25 14:36 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).