From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 06/14] drm/mediatek: add RGB color format support for RDMA
Date: Thu, 9 Aug 2018 10:36:32 +0800 [thread overview]
Message-ID: <1533782192.29986.0.camel@mtksdaap41> (raw)
In-Reply-To: <1533780949-30141-7-git-send-email-stu.hsieh@mediatek.com>
Hi, Stu:
On Thu, 2018-08-09 at 10:15 +0800, Stu Hsieh wrote:
> This patch add RGB color format support for RDMA,
> including RGB565, RGB888, RGBA8888 and ARGB8888.
>
> Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 46 ++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> index 08866550740f..1f57f86c7910 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> @@ -35,6 +35,8 @@
> #define DISP_REG_RDMA_SIZE_CON_0 0x0014
> #define DISP_REG_RDMA_SIZE_CON_1 0x0018
> #define DISP_REG_RDMA_TARGET_LINE 0x001c
> +#define DISP_RDMA_MEM_CON 0x0024
> +#define MEM_MODE_INPUT_SWAP BIT(8)
> #define DISP_RDMA_MEM_SRC_PITCH 0x002c
> #define DISP_RDMA_MEM_GMC_SETTING_0 0x0030
> #define DISP_REG_RDMA_FIFO_CON 0x0040
> @@ -46,6 +48,11 @@
>
> #define RDMA_MEM_GMC 0x40402020
>
> +#define MEM_MODE_INPUT_FORMAT_RGB565 0x0
> +#define MEM_MODE_INPUT_FORMAT_RGB888 (0x001 << 4)
> +#define MEM_MODE_INPUT_FORMAT_RGBA8888 (0x002 << 4)
> +#define MEM_MODE_INPUT_FORMAT_ARGB8888 (0x003 << 4)
> +
> struct mtk_disp_rdma_data {
> unsigned int fifo_size;
> };
> @@ -144,12 +151,51 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width,
> writel(reg, comp->regs + DISP_REG_RDMA_FIFO_CON);
> }
>
> +static unsigned int rdma_fmt_convert(struct mtk_disp_rdma *rdma,
> + unsigned int fmt)
> +{
> + /* The return value in switch "MEM_MODE_INPUT_FORMAT_XXX"
> + * is defined in mediatek HW data sheet.
> + * The alphabet order in XXX is no relation to data
> + * arrangement in memory.
> + */
> + switch (fmt) {
> + default:
> + case DRM_FORMAT_RGB565:
> + return MEM_MODE_INPUT_FORMAT_RGB565;
> + case DRM_FORMAT_BGR565:
> + return MEM_MODE_INPUT_FORMAT_RGB565 | MEM_MODE_INPUT_SWAP;
> + case DRM_FORMAT_RGB888:
> + return MEM_MODE_INPUT_FORMAT_RGB888;
> + case DRM_FORMAT_BGR888:
> + return MEM_MODE_INPUT_FORMAT_RGB888 | MEM_MODE_INPUT_SWAP;
> + case DRM_FORMAT_RGBX8888:
> + case DRM_FORMAT_RGBA8888:
> + return MEM_MODE_INPUT_FORMAT_ARGB8888;
> + case DRM_FORMAT_BGRX8888:
> + case DRM_FORMAT_BGRA8888:
> + return MEM_MODE_INPUT_FORMAT_ARGB8888 | MEM_MODE_INPUT_SWAP;
> + case DRM_FORMAT_XRGB8888:
> + case DRM_FORMAT_ARGB8888:
> + return MEM_MODE_INPUT_FORMAT_RGBA8888;
> + case DRM_FORMAT_XBGR8888:
> + case DRM_FORMAT_ABGR8888:
> + return MEM_MODE_INPUT_FORMAT_RGBA8888 | MEM_MODE_INPUT_SWAP;
> + }
> +}
> +
> static void mtk_rdma_layer_config(struct mtk_ddp_comp *comp, unsigned int idx,
> struct mtk_plane_state *state)
> {
> + struct mtk_disp_rdma *rdma = comp_to_rdma(comp);
> struct mtk_plane_pending_state *pending = &state->pending;
> unsigned int addr = pending->addr;
> unsigned int pitch = pending->pitch & 0xffff;
> + unsigned int fmt = pending->format;
> + unsigned int con;
> +
> + con = rdma_fmt_convert(rdma, fmt);
> + writel_relaxed(con, comp->regs + DISP_RDMA_MEM_CON);
>
> writel_relaxed(addr, comp->regs + DISP_RDMA_MEM_START_ADDR);
> writel_relaxed(pitch, comp->regs + DISP_RDMA_MEM_SRC_PITCH);
next prev parent reply other threads:[~2018-08-09 2:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 2:15 [PATCH v4 00/14] Add RDMA memory mode support for mediatek SOC MT2712 Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 01/14] drm/mediatek: add connection from RDMA0 to DPI1 Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 02/14] drm/mediatek: add connection from RDMA0 to DSI1 Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 03/14] drm/mediatek: add connection from RDMA1 to DSI0 Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 04/14] drm/mediatek: add connection from RDMA2 " Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 05/14] drm/mediatek: add memory mode and layer_config for RDMA Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 06/14] drm/mediatek: add RGB color format support " Stu Hsieh
2018-08-09 2:36 ` CK Hu [this message]
2018-08-09 2:15 ` [PATCH v4 07/14] drm/mediatek: add the comment about color format setting for OVL Stu Hsieh
2018-08-09 2:37 ` CK Hu
2018-08-09 2:15 ` [PATCH v4 08/14] drm/mediatek: add YUYV/UYVY color format support for RDMA Stu Hsieh
2018-08-09 2:41 ` CK Hu
2018-08-09 2:15 ` [PATCH v4 09/14] drm/mediatek: add function to get layer number for component Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 10/14] drm/mediatek: add function to return OVL layer number Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 11/14] drm/mediatek: add function to return RDMA " Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 12/14] drm/mediatek: use layer_nr function to get layer number to init plane Stu Hsieh
2018-08-09 2:46 ` CK Hu
2018-08-09 2:15 ` [PATCH v4 13/14] drm/mediatek: update some variable name from ovl to comp Stu Hsieh
2018-08-09 2:15 ` [PATCH v4 14/14] drm/mediatek: fix connection from RDMA2 to DSI1 Stu Hsieh
2018-08-15 1:55 ` [PATCH v4 00/14] Add RDMA memory mode support for mediatek SOC MT2712 CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533782192.29986.0.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).