linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 08/14] drm/mediatek: add YUYV/UYVY color format support for RDMA
Date: Thu, 9 Aug 2018 10:41:26 +0800	[thread overview]
Message-ID: <1533782486.29986.2.camel@mtksdaap41> (raw)
In-Reply-To: <1533780949-30141-9-git-send-email-stu.hsieh@mediatek.com>

Hi, Stu:

On Thu, 2018-08-09 at 10:15 +0800, Stu Hsieh wrote:
> This patch add YUYV/UYVY color format support for RDMA
> and transform matrix for YUYV/UYVY.
> 
> Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>

Reviewed-by: CK Hu <ck.hu@mediatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> index 1f57f86c7910..8b015c2d4418 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> @@ -33,6 +33,8 @@
>  #define RDMA_ENGINE_EN					BIT(0)
>  #define RDMA_MODE_MEMORY				BIT(1)
>  #define DISP_REG_RDMA_SIZE_CON_0		0x0014
> +#define RDMA_MATRIX_ENABLE				BIT(17)
> +#define RDMA_MATRIX_INT_MTX_BT601_to_RGB		(6 << 20)
>  #define DISP_REG_RDMA_SIZE_CON_1		0x0018
>  #define DISP_REG_RDMA_TARGET_LINE		0x001c
>  #define DISP_RDMA_MEM_CON			0x0024
> @@ -46,12 +48,15 @@
>  #define RDMA_FIFO_SIZE(rdma)			((rdma)->data->fifo_size)
>  #define DISP_RDMA_MEM_START_ADDR		0x0f00
>  
> +#define RDMA_MATRIX_INT_MTX_SEL			GENMASK(23, 20)
>  #define RDMA_MEM_GMC				0x40402020
>  
>  #define MEM_MODE_INPUT_FORMAT_RGB565		0x0
>  #define MEM_MODE_INPUT_FORMAT_RGB888		(0x001 << 4)
>  #define MEM_MODE_INPUT_FORMAT_RGBA8888		(0x002 << 4)
>  #define MEM_MODE_INPUT_FORMAT_ARGB8888		(0x003 << 4)
> +#define MEM_MODE_INPUT_FORMAT_UYVY		(0x004 << 4)
> +#define MEM_MODE_INPUT_FORMAT_YUYV		(0x005 << 4)
>  
>  struct mtk_disp_rdma_data {
>  	unsigned int fifo_size;
> @@ -181,6 +186,10 @@ static unsigned int rdma_fmt_convert(struct mtk_disp_rdma *rdma,
>  	case DRM_FORMAT_XBGR8888:
>  	case DRM_FORMAT_ABGR8888:
>  		return MEM_MODE_INPUT_FORMAT_RGBA8888 | MEM_MODE_INPUT_SWAP;
> +	case DRM_FORMAT_UYVY:
> +		return MEM_MODE_INPUT_FORMAT_UYVY;
> +	case DRM_FORMAT_YUYV:
> +		return MEM_MODE_INPUT_FORMAT_YUYV;
>  	}
>  }
>  
> @@ -197,6 +206,17 @@ static void mtk_rdma_layer_config(struct mtk_ddp_comp *comp, unsigned int idx,
>  	con = rdma_fmt_convert(rdma, fmt);
>  	writel_relaxed(con, comp->regs + DISP_RDMA_MEM_CON);
>  
> +	if (fmt == DRM_FORMAT_UYVY || fmt == DRM_FORMAT_YUYV) {
> +		rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0,
> +				 RDMA_MATRIX_ENABLE, RDMA_MATRIX_ENABLE);
> +		rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0,
> +				 RDMA_MATRIX_INT_MTX_SEL,
> +				 RDMA_MATRIX_INT_MTX_BT601_to_RGB);
> +	} else {
> +		rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0,
> +				 RDMA_MATRIX_ENABLE, 0);
> +	}
> +
>  	writel_relaxed(addr, comp->regs + DISP_RDMA_MEM_START_ADDR);
>  	writel_relaxed(pitch, comp->regs + DISP_RDMA_MEM_SRC_PITCH);
>  	writel(RDMA_MEM_GMC, comp->regs + DISP_RDMA_MEM_GMC_SETTING_0);

  reply	other threads:[~2018-08-09  2:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  2:15 [PATCH v4 00/14] Add RDMA memory mode support for mediatek SOC MT2712 Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 01/14] drm/mediatek: add connection from RDMA0 to DPI1 Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 02/14] drm/mediatek: add connection from RDMA0 to DSI1 Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 03/14] drm/mediatek: add connection from RDMA1 to DSI0 Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 04/14] drm/mediatek: add connection from RDMA2 " Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 05/14] drm/mediatek: add memory mode and layer_config for RDMA Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 06/14] drm/mediatek: add RGB color format support " Stu Hsieh
2018-08-09  2:36   ` CK Hu
2018-08-09  2:15 ` [PATCH v4 07/14] drm/mediatek: add the comment about color format setting for OVL Stu Hsieh
2018-08-09  2:37   ` CK Hu
2018-08-09  2:15 ` [PATCH v4 08/14] drm/mediatek: add YUYV/UYVY color format support for RDMA Stu Hsieh
2018-08-09  2:41   ` CK Hu [this message]
2018-08-09  2:15 ` [PATCH v4 09/14] drm/mediatek: add function to get layer number for component Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 10/14] drm/mediatek: add function to return OVL layer number Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 11/14] drm/mediatek: add function to return RDMA " Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 12/14] drm/mediatek: use layer_nr function to get layer number to init plane Stu Hsieh
2018-08-09  2:46   ` CK Hu
2018-08-09  2:15 ` [PATCH v4 13/14] drm/mediatek: update some variable name from ovl to comp Stu Hsieh
2018-08-09  2:15 ` [PATCH v4 14/14] drm/mediatek: fix connection from RDMA2 to DSI1 Stu Hsieh
2018-08-15  1:55 ` [PATCH v4 00/14] Add RDMA memory mode support for mediatek SOC MT2712 CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533782486.29986.2.camel@mtksdaap41 \
    --to=ck.hu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).