linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)
To: linux-arm-kernel@lists.infradead.org
Subject: Patch "asm-generic/bitops/lock.h: Rewrite using atomic_fetch_" causes kernel crash
Date: Wed, 29 Aug 2018 18:33:53 +0000	[thread overview]
Message-ID: <1535567633.4465.23.camel@synopsys.com> (raw)

Hi Guys,
Since v4.19-rc1 we are getting a serious regression on platforms with ARC architecture.
The kernel have become unstable and spontaneously crashes on LTP tests execution / IO tests or
even on boot.

I don't know exactly what breaks but bisect clearly assign the blame to this commit:
84c6591103db ("locking/atomics, asm-generic/bitops/lock.h: Rewrite using atomic_fetch_*()")
https://github.com/torvalds/linux/commit/84c6591103dbeaf393a092a3fc7b09510825f6b9

Reverting the commit solves this problem.

I tested v4.19-rc1 on ARM (wandboard, i.mx6, 32bit, quard core, ARMv7) which uses same
generic bitops implementation and it works fine.

Do you have any ideas what went wrong?
-- 
 Eugeniy Paltsev

             reply	other threads:[~2018-08-29 18:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 18:33 Eugeniy Paltsev [this message]
2018-08-29 21:16 ` Patch "asm-generic/bitops/lock.h: Rewrite using atomic_fetch_" causes kernel crash Vineet Gupta
2018-08-30  9:35   ` Will Deacon
2018-08-30  9:44   ` Peter Zijlstra
2018-08-30  9:51     ` Will Deacon
2018-08-30 11:53       ` Eugeniy Paltsev
2018-08-30 13:57         ` Will Deacon
2018-08-30 14:17         ` Peter Zijlstra
2018-08-30 14:23           ` Will Deacon
2018-08-30 14:29             ` Peter Zijlstra
2018-08-30 14:43               ` Peter Zijlstra
2020-04-14  1:19                 ` Vineet Gupta
2018-08-30 20:31               ` Vineet Gupta
2018-08-30 20:45                 ` Peter Zijlstra
2018-08-31  0:30                   ` Vineet Gupta
2018-08-31  9:53                     ` Will Deacon
2018-08-30 14:46           ` Eugeniy Paltsev
2018-08-30 17:15             ` Peter Zijlstra
2018-08-31  0:42       ` Vineet Gupta
2018-08-31  0:29     ` __clear_bit_lock to use atomic clear_bit (was Re: Patch "asm-generic/bitops/lock.h) Vineet Gupta
2018-08-31  7:24       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1535567633.4465.23.camel@synopsys.com \
    --to=eugeniy.paltsev@synopsys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).