From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 05/11] drm/mediatek: convert dpi driver to use drm_of_find_panel_or_bridge
Date: Tue, 2 Oct 2018 16:32:16 +0800 [thread overview]
Message-ID: <1538469136.24335.1.camel@mtksdaap41> (raw)
In-Reply-To: <20181002081041.32629-6-bibby.hsieh@mediatek.com>
Hi, Bibby:
On Tue, 2018-10-02 at 16:10 +0800, Bibby Hsieh wrote:
> From: chunhui dai <chunhui.dai@mediatek.com>
>
> Convert dpi driver to use drm_of_find_panel_or_bridge.
> This changes some error messages to debug messages (in the graph core).
> Graph connections are often "no connects" depending on the particular
> board, so we want to avoid spurious messages. Plus the kernel is not a
> DT validator.
> related links:
> [1] https://lkml.org/lkml/2017/2/3/716
> [2] https://lkml.org/lkml/2017/2/3/719
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: chunhui dai <chunhui.dai@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 0dbe9345fa2e..08915e1765f8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -14,6 +14,7 @@
> #include <drm/drmP.h>
> #include <drm/drm_crtc.h>
> #include <drm/drm_crtc_helper.h>
> +#include <drm/drm_of.h>
> #include <linux/kernel.h>
> #include <linux/component.h>
> #include <linux/platform_device.h>
> @@ -668,7 +669,6 @@ static int mtk_dpi_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct mtk_dpi *dpi;
> struct resource *mem;
> - struct device_node *bridge_node;
> int comp_id;
> int ret;
>
> @@ -714,16 +714,12 @@ static int mtk_dpi_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - bridge_node = of_graph_get_remote_node(dev->of_node, 0, 0);
> - if (!bridge_node)
> - return -ENODEV;
> -
> - dev_info(dev, "Found bridge node: %pOF\n", bridge_node);
> + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
> + NULL, &dpi->bridge);
> + if (ret)
> + return ret;
>
> - dpi->bridge = of_drm_find_bridge(bridge_node);
> - of_node_put(bridge_node);
> - if (!dpi->bridge)
> - return -EPROBE_DEFER;
> + dev_info(dev, "Found bridge node: %pOF\n", dpi->bridge->of_node);
>
> comp_id = mtk_ddp_comp_get_id(dev->of_node, MTK_DPI);
> if (comp_id < 0) {
next prev parent reply other threads:[~2018-10-02 8:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 8:10 [PATCH v4 00/11] drm/mediatek: support hdmi output for mt2701 and mt7623 Bibby Hsieh
2018-10-02 8:10 ` [PATCH v4 01/11] drm/mediatek: add refcount for DPI power on/off Bibby Hsieh
2018-10-02 8:28 ` CK Hu
2018-10-02 8:10 ` [PATCH v4 02/11] drm/mediatek: move hardware register to node data Bibby Hsieh
2018-10-02 8:10 ` [PATCH v4 03/11] drm/mediatek: adjust EDGE to match clock and data Bibby Hsieh
2018-10-02 8:10 ` [PATCH v4 04/11] drm/mediatek: add clock factor for different IC Bibby Hsieh
2018-10-02 8:10 ` [PATCH v4 05/11] drm/mediatek: convert dpi driver to use drm_of_find_panel_or_bridge Bibby Hsieh
2018-10-02 8:32 ` CK Hu [this message]
2018-10-02 8:10 ` [PATCH v4 06/11] drm/mediatek: add dpi driver for mt2701 and mt7623 Bibby Hsieh
2018-10-02 8:10 ` [PATCH v4 07/11] drm/mediatek: separate hdmi phy to different file Bibby Hsieh
2018-10-02 8:40 ` CK Hu
2018-10-02 8:10 ` [PATCH v4 08/11] drm/mediatek: add support for SPDIF audio in HDMI Bibby Hsieh
2018-10-02 8:10 ` [PATCH v4 09/11] drm/mediatek: add hdmi driver for MT2701 and MT7623 Bibby Hsieh
2018-10-02 8:10 ` [PATCH v4 10/11] drm/mediatek: implement connection from BLS to DPI0 Bibby Hsieh
2018-10-02 8:10 ` [PATCH v4 11/11] drm/mediatek: add a error return value when clock driver has been prepared Bibby Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538469136.24335.1.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox