From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: BCM5301X: add restart support
Date: Wed, 21 Jan 2015 10:03:29 +0100 [thread overview]
Message-ID: <1539307.ZYqgppcXBA@wuerfel> (raw)
In-Reply-To: <1421829866-9769-1-git-send-email-zajec5@gmail.com>
On Wednesday 21 January 2015 09:44:26 Rafa? Mi?ecki wrote:
>
> +static void bcm5301x_restart(enum reboot_mode mode, const char *cmd)
> +{
> + struct bcma_bus *bus = bcm5301x_get_bcma_bus();
> +
> + if (bus)
> + bcma_chipco_watchdog_timer_set(&bus->drv_cc, 1);
> + else
> + pr_warn("Unable to access bcma bus\n");
> +
> + while (1)
> + ;
> +}
> +
Please move the restart implementation into the driver that provides
the bcma_chipco_watchdog_timer_set() function, and use the new
restart notifier to hook it up, instead of the machine_descriptor
field.
Arnd
prev parent reply other threads:[~2015-01-21 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 8:44 [PATCH RFC] ARM: BCM5301X: add restart support Rafał Miłecki
2015-01-21 9:03 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539307.ZYqgppcXBA@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox