[PATCH V2] clk: Add composite clock type

Prashant Gaikwad
2013-02-05T08:33:41Z

On Monday 04 February 2013 03:07 PM, Hiroshi Doyu wrote:
> Hi Prashant,
>
> Prashant Gaikwad <pgaikwad@nvidia.com> wrote @ Mon, 4 Feb 2013 09:11:22 +0100:
>
>> +struct clk *clk_register_composite(struct device *dev, const char *name,
>> + const char **parent_names, int num_parents,
>> + struct clk_hw *mux_hw, const struct clk_ops *mux_ops,
>> + struct clk_hw *div_hw, const struct clk_ops *div_ops,
>> + struct clk_hw *gate_hw, const struct clk_ops *gate_ops,
>> + unsigned long flags)
>> +{
>> + struct clk *clk;
>> + struct clk_init_data init;
>> + struct clk_composite *composite;
>> + struct clk_ops *clk_composite_ops;
>> +
>> + composite = kzalloc(sizeof(*composite), GFP_KERNEL);
>> + if (!composite) {
>> + pr_err("%s: could not allocate composite clk\n", __func__);
>> + return ERR_PTR(-ENOMEM);
>> + }
>> +
>> + init.name = name;
>> + init.flags = flags | CLK_IS_BASIC;
>> + init.parent_names = parent_names;
>> + init.num_parents = num_parents;
>> +
>> + /* allocate the clock ops */
>> + clk_composite_ops = kzalloc(sizeof(*clk_composite_ops), GFP_KERNEL);
> The members of "clk_composite_ops" seems to be always assigned
> statically. Istead of dynamically allocating/assigning, can't we just
> have "clk_composite_ops" statically as below?
>
> static struct clk_ops clk_composite_ops = {
> .get_parent = clk_composite_get_parent;
> .set_parent = clk_composite_set_parent;
> .recalc_rate = clk_composite_recalc_rate;
> .round_rate = clk_composite_round_rate;
> .set_rate = clk_composite_set_rate;
> .is_enabled = clk_composite_is_enabled;
> .enable = clk_composite_enable;
> .disable = clk_composite_disable;
> };
>
> struct clk *clk_register_composite(struct device *dev, const char *name,
> const char **parent_names, int num_parents,
> struct clk_hw *mux_hw, const struct clk_ops *mux_ops,
> struct clk_hw *div_hw, const struct clk_ops *div_ops,
> struct clk_hw *gate_hw, const struct clk_ops *gate_ops,
> unsigned long flags)
> {
> .....
>
> init.ops = &clk_composite_ops;

No, clk_ops depends on the clocks you are using. There could be a clock
with mux and gate while another one with mux and div.