linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew.murray@arm.com (Andrew Murray)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm64: arm_pmu: Exclude EL1,2 with :G :H perf attributes
Date: Thu, 15 Nov 2018 12:55:48 +0000	[thread overview]
Message-ID: <1542286549-4501-4-git-send-email-andrew.murray@arm.com> (raw)
In-Reply-To: <1542286549-4501-1-git-send-email-andrew.murray@arm.com>

When using VHE, EL1 is unused by the host and EL2 is unused by the
guest - therefore we can filter out these events with the PMU as per
the 'exclude_host' and 'exclude_guest' attributes.

With both VHE and non-VHE we switch the counters between host/guest
at EL2. With non-VHE when using 'exclude_host' we filter out EL2.

These changes eliminate counters counting host events on the
boundaries of guest entry/exit when using :G. However when using :H
unless exclude_hv is set on non-VHE then there is a small blackout
window at the guest entry/exit where host events are not captured.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 arch/arm64/kernel/perf_event.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 89d444f..c079c1f 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -971,12 +971,14 @@ static int armv8pmu_set_event_filter(struct hw_perf_event *event,
 	 * with other architectures (x86 and Power).
 	 */
 	if (is_kernel_in_hyp_mode()) {
-		if (!attr->exclude_kernel)
+		if (!attr->exclude_kernel && !attr->exclude_host)
 			config_base |= ARMV8_PMU_INCLUDE_EL2;
+		if (attr->exclude_guest)
+			config_base |= ARMV8_PMU_EXCLUDE_EL1;
 	} else {
 		if (attr->exclude_kernel)
 			config_base |= ARMV8_PMU_EXCLUDE_EL1;
-		if (!attr->exclude_hv)
+		if (!attr->exclude_hv && !attr->exclude_host)
 			config_base |= ARMV8_PMU_INCLUDE_EL2;
 	}
 	if (attr->exclude_user)
-- 
2.7.4

  parent reply	other threads:[~2018-11-15 12:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 12:55 [PATCH 0/4] arm64: Support perf event modifiers :G and :H Andrew Murray
2018-11-15 12:55 ` [PATCH 1/4] arm64: KVM: add accessors to track guest/host only counters Andrew Murray
2018-11-15 12:55 ` [PATCH 2/4] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes Andrew Murray
2018-11-15 12:55 ` Andrew Murray [this message]
2018-11-15 14:57   ` [PATCH 3/4] arm64: arm_pmu: Exclude EL1,2 with :G :H perf attributes Suzuki K Poulose
2018-11-15 16:06     ` Andrew Murray
2018-11-15 12:55 ` [PATCH 4/4] arm64: KVM: Enable support for :G/:H perf event modifiers Andrew Murray
2018-11-15 14:00   ` Julien Thierry
2018-11-15 15:57     ` Andrew Murray
2018-11-15 17:40       ` Suzuki K Poulose
2018-11-16 12:12         ` Andrew Murray
2018-11-16 17:53           ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542286549-4501-4-git-send-email-andrew.murray@arm.com \
    --to=andrew.murray@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).