From: mtk15107 <qii.wang@mediatek.com>
To: Sean Wang <sean.wang@kernel.org>
Cc: devicetree@vger.kernel.org, ryder.lee@mediatek.com,
srv_heupstream@mediatek.com, wsa@the-dreams.de,
leilk.liu@mediatek.com, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] dt-bindings: i2c: Add Mediatek MT7629 i2c binding
Date: Tue, 11 Dec 2018 14:28:28 +0800 [thread overview]
Message-ID: <1544509708.14641.6.camel@mhfsdcap03> (raw)
In-Reply-To: <CAGp9Lzppg3NXBtfgG2SLzMxKBiV9ozgDbBQRTffYA2JhT48Efg@mail.gmail.com>
On Tue, 2018-12-04 at 12:19 -0800, Sean Wang wrote:
> <qii.wang@mediatek.com> 於 2018年12月3日 週一 上午5:34寫道：
> >
> > From: qii wang <qii.wang@mediatek.com>
> >
> > Add MT7629 i2c binding to i2c-mt2712.txt and there is no need to
>
> where's i2c-mt2712.txt mentioned here?
>
Sorry, I will rewrite this commit. Such as:
Add MT7629 i2c binding to binding file.
> > modify i2c driver.
>
> suggest not to mention driver in any dt-binding, dt-binding self
> should be os-agnostic
>
Yes, I will remove it.
> >
> > Signed-off-by: qii wang <qii.wang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > index e199695..7729e57 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > @@ -10,6 +10,7 @@ Required properties:
> > "mediatek,mt6589-i2c": for MediaTek MT6589
> > "mediatek,mt7622-i2c": for MediaTek MT7622
> > "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for MediaTek MT7623
> > + "mediatek,mt7629-i2c", "mediatek,mt2712-i2c": for MediaTek mt7629
>
> change mt7629 to MT7629 to align to the others
>
OK.
> > "mediatek,mt8173-i2c": for MediaTek MT8173
> > - reg: physical base address of the controller and dma base, length of memory
> > mapped region.
> > --
> > 1.7.9.5
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-11 6:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 13:32 [PATCH 0/5] add i2c support for mt7629 and mt8183 qii.wang
2018-12-03 13:32 ` [PATCH 1/5] dt-bindings: i2c: Add Mediatek MT7629 i2c binding qii.wang
2018-12-04 20:19 ` Sean Wang
2018-12-11 6:28 ` mtk15107 [this message]
2018-12-03 13:32 ` [PATCH 2/5] i2c: mediatek: remove useless code and replace definitions qii.wang
2018-12-04 20:37 ` Sean Wang
2018-12-11 20:20 ` Wolfram Sang
2018-12-13 9:13 ` Qii Wang
2018-12-03 13:32 ` [PATCH 3/5] i2c: mediatek: Add offsets array for new i2c registers qii.wang
2018-12-04 20:45 ` Sean Wang
2018-12-03 13:32 ` [PATCH 4/5] dt-bindings: i2c: Add Mediatek MT8183 i2c binding qii.wang
2018-12-04 20:59 ` Sean Wang
2018-12-11 20:29 ` Wolfram Sang
2018-12-13 9:32 ` Qii Wang
2018-12-17 23:06 ` Wolfram Sang
2018-12-18 2:35 ` Qii Wang
2018-12-03 13:32 ` [PATCH 5/5] i2c: mediatek: Add i2c compatible for MediaTek MT8183 qii.wang
2018-12-04 5:49 ` Sean Wang
2018-12-12 7:18 ` Qii Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544509708.14641.6.camel@mhfsdcap03 \
--to=qii.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox