From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2309C5CFFE for ; Tue, 11 Dec 2018 17:18:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7741620870 for ; Tue, 11 Dec 2018 17:18:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oKjA+2ab"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="svMzx1Nh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7741620870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t1E9cN3hfjS4AiHDB4vuGw7QOZLQSqi06Rhw4YjYFNo=; b=oKjA+2abwD84+X TkNAdp9KJpVuijxzf9A+PRybk1rlEDCMz+hWgH8T39L6zw+BQApsIT+iuM2aQAH4kaIp8jd7b4vMU 21MFjzb1KrTqtz2oXd4cSxuDbZCgmkKwOCWwKl4T06GxIdsD4uJamxKGvIzxQ+v0hkI4Ai5VFXzWq JsrE4MDdW/GZJkITeXveHZv7fC070tFFC8OQLtadeJrORsGxpCPUH3ygwTcvNR11VeMd1qQ/l4Biv 0mWYQoHnHR+Qi3RlXTN3Rs2BFBV6GnUFhLO73IYsS5QNTrazTAwziai6negguFZWTjtl9CuUIuSqK bjeqsyQeOwXHheYBV/FA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWlgE-0007Od-SE; Tue, 11 Dec 2018 17:18:46 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWlgB-0007Ny-KH for linux-arm-kernel@lists.infradead.org; Tue, 11 Dec 2018 17:18:45 +0000 Received: by mail-qt1-x842.google.com with SMTP id d19so17248657qtq.9 for ; Tue, 11 Dec 2018 09:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=h0hsgksLXZZZ+Za4ufYtYeUu6sbcdg1JL7mSLK44kUY=; b=svMzx1NhUA9/VSxg+zlHTLuVM1Ssqd+JJ3soT1feYkYRvsGy51GQxFr+fTh2/vEanU Vh3X3biNlEDE0T3+3TqTxCgKWoA3IBZaeQKhaH7Y4MRY/dYP95rmNdkMlF6s9VZvL2Up i05Lg8dUO8w4zpxnyWrMDxNbQxQs8WV6Mw6r+CojIOzDnUeMhFgYDGmRX+iqCYmtkHEj v0cMyZnE6QlWqtyOkrzmHFvdtkfi1qvAgUmuU2uk4wiy8r1+TMG3iZQEJRZZ5oyRVK5n TSA9+yGqA0UP3yA786ErRqWFNIBnhwPp+C9sSL8YxAvulCbOfLRUX9Tx9pppJ72twWzP Mh7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=h0hsgksLXZZZ+Za4ufYtYeUu6sbcdg1JL7mSLK44kUY=; b=kAK2gIcce61yGpd9sR1DpSDN5/MqB4hSrQiHa2NWeIzCyYVmUQKJl3PNcfncmdBp3Y 6rwA/SrfNv1ubtc/i5MSI7Qq/W88LI5qVDMXK9nUv9qBZFDR8RSRmP+EgdNiwtonUEKd 7I1pabgIdVjm4odt3YeAy9uaxLPCy7Lk68rbvHxod7WlDU6ooufhF+uQhKDvkCyM6GKM 7/GPZDO5Jow/K3+6baHuXjxqrSOJUaNHVnm+pp9LrLqv2QKFsvpDg3BcnO0QVINL6BME MCwgnj0o+wABs8Dey3yz2ZukSXzFx0BOL0JOVnMshGkHx/GB+SIY3p54iAdoefNhGCp1 vqPw== X-Gm-Message-State: AA+aEWYEjaUQLmfr8lLgVJY9F+u1zHxgTD+P0BflV9nsfP2oimF7l8Uq /yIRa/rh0FJ+eBNCISAi3QYvLw== X-Google-Smtp-Source: AFSGD/VjSceHo1CAZ9W5GfynGWR67gmlWIo3i6anGONMRu4EZeLaCyiYEothGKkUaRykwx+4aL7APw== X-Received: by 2002:ac8:16d8:: with SMTP id y24mr17243898qtk.253.1544548709912; Tue, 11 Dec 2018 09:18:29 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id e89sm8298135qtb.78.2018.12.11.09.18.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Dec 2018 09:18:29 -0800 (PST) Message-ID: <1544548707.18411.3.camel@lca.pw> Subject: Re: [PATCH] arm64: increase stack size for KASAN_EXTRA From: Qian Cai To: Arnd Bergmann Date: Tue, 11 Dec 2018 12:18:27 -0500 In-Reply-To: References: <721E7B42-2D55-4866-9C1A-3E8D64F33F9C@gmx.us> <20181207223449.38808-1-cai@lca.pw> X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181211_091843_707338_DBA21A85 X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , Linux Kernel Mailing List , kasan-dev , Linux-MM , Alexander Potapenko , Linux ARM , Andrey Ryabinin , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2018-12-11 at 13:42 +0100, Arnd Bergmann wrote: > On Fri, Dec 7, 2018 at 11:35 PM Qian Cai wrote: > > > > If the kernel is configured with KASAN_EXTRA, the stack size is > > increasted significantly due to enable this option will set > > -fstack-reuse to "none" in GCC [1]. As the results, it could trigger > > stack overrun quite often with 32k stack size compiled using GCC 8. For > > example, this reproducer > > > > size > > 7536 shrink_inactive_list > > 7440 shrink_page_list > > 6560 fscache_stats_show > > 3920 jbd2_journal_commit_transaction > > 3216 try_to_unmap_one > > 3072 migrate_page_move_mapping > > 3584 migrate_misplaced_transhuge_page > > 3920 ip_vs_lblcr_schedule > > 4304 lpfc_nvme_info_show > > 3888 lpfc_debugfs_nvmestat_data.constprop > > > > There are other 49 functions are over 2k in size while compiling kernel > > with "-Wframe-larger-than=" on this machine. Hence, it is too much work > > to change Makefiles for each object to compile without > > -fsanitize-address-use-after-scope individually. > > > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715#c23 > > Could you clarify: are the numbers you see with or without the bugfix > from that bugzilla? > The numbers were from GCC8 which does NOT contain this patch [1]. GCC9 is awesome which reduced the numbers in half even for KASAN_EXTRA. Only thing is that GCC9 has not been officially released yet, so it is a bit inconvenient for users need to compile the compiler by themselves first. I am fine either way to drop this patch or keep it until GCC9 is GA. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715#c35 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel