From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A03BC65BAE for ; Thu, 13 Dec 2018 09:14:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF77420811 for ; Thu, 13 Dec 2018 09:14:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JvM8XICw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF77420811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oog2l5IX7266wEdRbN9+ZWhm0mJVV/v2VGPUQwiiKgM=; b=JvM8XICwC81Tcg nSVRmXoj5GBHdCb50GhOwDH5nt4GfeqTmVEjauY2ikfd24261sZrIoWXEs4zYb0pv56NE7w9FwGGd Qgo3x14CeEMTuFO4JODCT06khS2SI5NlIHtHOI96M8s4zVu22dFK3nBCKhfRgNJwCGUvXREDekQL5 hLHZG6B2D56s6/vOo6hFz38KZcVgOz0Ji5HoAlfN0q0SERPKAS4sRCF79MzdBz9XrJ5K4/U3xEsQ9 vdbVEMC953F4wVSspFvGxIaV4OhrmwdBrHyJJWn0J/vSbowMVuEPMSryCXUPg/9kC6bAlaF3htlSM /Jc9CwN6makR5dC9hDuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXN4i-0004hv-1w; Thu, 13 Dec 2018 09:14:32 +0000 Received: from [1.203.163.81] (helo=mailgw02.mediatek.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXN4Y-0003ps-95; Thu, 13 Dec 2018 09:14:26 +0000 X-UUID: c80aa5f96e3445abb442e1da0c70cc33-20181213 X-UUID: c80aa5f96e3445abb442e1da0c70cc33-20181213 Received: from mtkcas34.mediatek.inc [(172.27.4.250)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1045786807; Thu, 13 Dec 2018 17:14:01 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 13 Dec 2018 17:13:50 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 13 Dec 2018 17:13:50 +0800 Message-ID: <1544692429.11699.31.camel@mhfsdcap03> Subject: Re: [PATCH 2/5] i2c: mediatek: remove useless code and replace definitions From: Qii Wang To: Wolfram Sang Date: Thu, 13 Dec 2018 17:13:49 +0800 In-Reply-To: <20181211202058.cd4wyz4so66iqspt@ninjato> References: <1543843974-4054-1-git-send-email-qii.wang@mediatek.com> <1543843974-4054-3-git-send-email-qii.wang@mediatek.com> <20181211202058.cd4wyz4so66iqspt@ninjato> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181213_011422_741900_2DE8E453 X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ryder.lee@mediatek.com, srv_heupstream@mediatek.com, leilk.liu@mediatek.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2018-12-11 at 21:20 +0100, Wolfram Sang wrote: > On Mon, Dec 03, 2018 at 09:32:51PM +0800, qii.wang@mediatek.com wrote: > > From: qii wang > > > > Completion_done is useless when we don't use its return value, > > so we remove it. Different speeds have been defined by macros, > > so we use macros definitions. > > Those are two seperate patches, or? > These two changes are relatively small, but it seems better to be divided into two seperate patches. > > > > Signed-off-by: qii wang > > --- > > drivers/i2c/busses/i2c-mt65xx.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c > > index a74ef76..660de1e 100644 > > --- a/drivers/i2c/busses/i2c-mt65xx.c > > +++ b/drivers/i2c/busses/i2c-mt65xx.c > > @@ -456,7 +456,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs, > > > > control_reg = readw(i2c->base + OFFSET_CONTROL) & > > ~(I2C_CONTROL_DIR_CHANGE | I2C_CONTROL_RS); > > - if ((i2c->speed_hz > 400000) || (left_num >= 1)) > > + if ((i2c->speed_hz > MAX_FS_MODE_SPEED) || (left_num >= 1)) > > control_reg |= I2C_CONTROL_RS; > > > > if (i2c->op == I2C_MASTER_WRRD) > > @@ -465,7 +465,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs, > > writew(control_reg, i2c->base + OFFSET_CONTROL); > > > > /* set start condition */ > > - if (i2c->speed_hz <= 100000) > > + if (i2c->speed_hz <= I2C_DEFAULT_SPEED) > > writew(I2C_ST_START_CON, i2c->base + OFFSET_EXT_CONF); > > else > > writew(I2C_FS_START_CON, i2c->base + OFFSET_EXT_CONF); > > @@ -642,8 +642,6 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs, > > return -ETIMEDOUT; > > } > > > > - completion_done(&i2c->msg_complete); > > - > > if (i2c->irq_stat & (I2C_HS_NACKERR | I2C_ACKERR)) { > > dev_dbg(i2c->dev, "addr: %x, transfer ACK error\n", msgs->addr); > > mtk_i2c_init_hw(i2c); > > -- > > 1.7.9.5 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel