From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7ED6C43387 for ; Sat, 29 Dec 2018 02:49:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8525D218FD for ; Sat, 29 Dec 2018 02:49:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JINBH0Gm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8525D218FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yY5GzFuep8imFyne1vaBmyG/Z+eaQnIYJ0igUKl0cYo=; b=JINBH0Gmbg7J4O OgocHqD12rmyWH31K6PhPY9sFXXlwkSI5t4Oxzr3NCHfirvTJPcIXso1xGx2Fp7EgR1CuX14/L2qC VMdu/4kKL6L4VrQFIxmAxdDoKVUp68tSg+ZrPfkxUWj1KycGB8xo4vTLeWN58Gmo1XdYgoZ+GKDft YGh1f52BQkKoXVWpwg1Avc98cZ1BzxWMH490KxvcLTvAKcB5n9FncpdJxr6n3Vf8OdWVKzOdNnIqB kwHqm2ccajTukDm1+NxEW+YqR1NTQQvuNrXjcqDpRAmGvStyU+axY12Mtw6MYy9VwbbrR3cNNQimk JRsPCNrIRihIadkvnk4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gd4ge-0002zp-BA; Sat, 29 Dec 2018 02:49:16 +0000 Received: from [1.203.163.81] (helo=mailgw02.mediatek.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gd4gY-0002yi-3K; Sat, 29 Dec 2018 02:49:12 +0000 X-UUID: 82db1c0ec9f14e29a3abd3678ac361f7-20181229 X-UUID: 82db1c0ec9f14e29a3abd3678ac361f7-20181229 Received: from mtkcas34.mediatek.inc [(172.27.4.250)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1276222270; Sat, 29 Dec 2018 10:48:42 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Dec 2018 10:48:40 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 29 Dec 2018 10:48:40 +0800 Message-ID: <1546051720.32173.139.camel@mhfsdcap03> Subject: Re: [PATCH] usb: devio: update max count of DPs per interval for ISOC From: Chunfeng Yun To: Greg Kroah-Hartman Date: Sat, 29 Dec 2018 10:48:40 +0800 In-Reply-To: <20181228105148.GA22073@kroah.com> References: <1545992864-9530-1-git-send-email-chunfeng.yun@mediatek.com> <20181228105148.GA22073@kroah.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181228_184910_367020_302C74A3 X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, 2018-12-28 at 11:51 +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 28, 2018 at 06:27:44PM +0800, Chunfeng Yun wrote: > > The host shall be able to accept and send up to 96 DPs for > > devices operating at Gen 2 speed. > > Why? What is this keeping from working properly today? The failure happened when I tried to send up to 96DPs per an interval for SSP ISOC transations by libusb, this is used to verify SSP ISOC function of USB3 GEN2 controller. Maybe for normal scenarios they needn't transfer greater than 48 DPs in an ISOC interval. (refer usb3.1r1.0 section 8.12.6 Isochronous Transactions) > > I need a much better changelog text here in order to be able to accept > this patch. I'll make the change in next version > > > > > Signed-off-by: Chunfeng Yun > > --- > > drivers/usb/core/devio.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > > index a75bc0b8a50f..82c16210e34c 100644 > > --- a/drivers/usb/core/devio.c > > +++ b/drivers/usb/core/devio.c > > @@ -1564,12 +1564,10 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb > > } > > for (totlen = u = 0; u < number_of_packets; u++) { > > /* > > - * arbitrary limit need for USB 3.0 > > - * bMaxBurst (0~15 allowed, 1~16 packets) > > - * bmAttributes (bit 1:0, mult 0~2, 1~3 packets) > > - * sizemax: 1024 * 16 * 3 = 49152 > > + * arbitrary limit need for USB 3.1 Gen2 > > + * sizemax: 96 DPs at SSP, 96 * 1024 = 98304 > > */ > > - if (isopkt[u].length > 49152) { > > + if (isopkt[u].length > 98304) { > > Are we going to have to keep bumping this up as speeds get faster and > faster? Or remove the check of data length? I'm not sure which way is better > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel